From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 482E943B45; Mon, 19 Feb 2024 03:13:23 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C91974029B; Mon, 19 Feb 2024 03:13:22 +0100 (CET) Received: from mail-pj1-f41.google.com (mail-pj1-f41.google.com [209.85.216.41]) by mails.dpdk.org (Postfix) with ESMTP id D80E640278 for ; Mon, 19 Feb 2024 03:13:21 +0100 (CET) Received: by mail-pj1-f41.google.com with SMTP id 98e67ed59e1d1-299b55f2344so42675a91.2 for ; Sun, 18 Feb 2024 18:13:21 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1708308801; x=1708913601; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=5XhvZV5yxZgmz3I/G6UFTw4Y+wE14IdlfHbIkRd8pgM=; b=MoGsd5kMR9je9cycy09zL06uGWy8FvRqY+rkOXQuP+TeNrUlC2e0QhbX8iIKaFwOKK 2YNiipj+jt/2lGllh7Pt23aNDXN2i1XuZ7UJ5RDg8mJCSleK3Dsy2m4gkF13Fx366s6d JY97X3UokhxT7I16/e24afAIINbWyzMomX1fw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1708308801; x=1708913601; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=5XhvZV5yxZgmz3I/G6UFTw4Y+wE14IdlfHbIkRd8pgM=; b=PQaGUJJjwr/nEnu+VwwlPUR1DEiVUcfjbvKPl7/Pe5TO3UqPhbu79ZRvb4fGXZYX0n TgVFwcXXnXoYZ2AFvZmwTKtn6ff7O+M0iT9UKLQ6ko28QWJ0ycUCKvEvyoCt1SPIUVj+ iY3TFn3arnpGBpqbB7iWop+6ABpo5Xu1ICBD5KXL0iVRlDaJgnRDNbGAkA2VSxOYvHAs gf5BgyjjxA58T3zA9EpwVxEJIYwLzRWKANU/JKVMkrDEM1m47ywWBG7vusrSg5PZXJsn 2IYnX7ntkPgGh+JsrUKw5syjgAwLkTTVb8tcOaCERxxWhxiIHgjr0hysFcmHtM3E1bvl WW5g== X-Gm-Message-State: AOJu0YxLTAaO5jkRRVlitUFf698P5C4b+BeSd71dWbRzkY0PleiBiPE8 h0LvCDZFl9Ta/tesmiiDlQ1T+/RWnyt35gd1s+0pkKRqDAcn3SUOaAtcQpAE770PYAbDUkDJcbK PUXUS8Kw+LqPdh/UXFDtYcXbq5EjpRa63OmPt X-Google-Smtp-Source: AGHT+IFNLs888wkf/XXpQGsL35x//viKPoY6o2VSo2tkl31du5ojxZX+Fh8jsKH72eUSm9n/7sQYpCZuCCOllpahzXo= X-Received: by 2002:a17:90a:e2d3:b0:299:559b:bfee with SMTP id fr19-20020a17090ae2d300b00299559bbfeemr2429926pjb.38.1708308800860; Sun, 18 Feb 2024 18:13:20 -0800 (PST) MIME-Version: 1.0 References: <1700089378-26197-1-git-send-email-roretzla@linux.microsoft.com> <20240216102454.4156609-1-david.marchand@redhat.com> <20240216102454.4156609-3-david.marchand@redhat.com> In-Reply-To: <20240216102454.4156609-3-david.marchand@redhat.com> From: Ajit Khaparde Date: Sun, 18 Feb 2024 18:13:03 -0800 Message-ID: Subject: Re: [PATCH v2 2/3] drivers: use common min/max macros To: David Marchand Cc: dev@dpdk.org, Somnath Kotur , Devendra Singh Rawat , Alok Prasad , Rosen Xu Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000043223d0611b2a39e" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000043223d0611b2a39e Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Feb 16, 2024 at 2:25=E2=80=AFAM David Marchand wrote: > > Use newly introduced macro. > > Signed-off-by: David Marchand Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/bnxt_ethdev.c | 12 +----------- > drivers/net/qede/base/bcm_osal.h | 6 ++---- > drivers/raw/ifpga/base/osdep_rte/osdep_generic.h | 11 ++--------- > 3 files changed, 5 insertions(+), 24 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethde= v.c > index 45d840d7af..8cc012206a 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -4867,17 +4867,7 @@ static void bnxt_free_ctx_mem(struct bnxt *bp) > > #define bnxt_roundup(x, y) ((((x) + ((y) - 1)) / (y)) * (y)) > > -#define min_t(type, x, y) ({ \ > - type __min1 =3D (x); \ > - type __min2 =3D (y); \ > - __min1 < __min2 ? __min1 : __min2; }) > - > -#define max_t(type, x, y) ({ \ > - type __max1 =3D (x); \ > - type __max2 =3D (y); \ > - __max1 > __max2 ? __max1 : __max2; }) > - > -#define clamp_t(type, _x, min, max) min_t(type, max_t(type, _x, min)= , max) > +#define clamp_t(type, _x, min, max) RTE_MIN_T(RTE_MAX_T(_x, min, type), = max, type) > > int bnxt_alloc_ctx_mem(struct bnxt *bp) > { > diff --git a/drivers/net/qede/base/bcm_osal.h b/drivers/net/qede/base/bcm= _osal.h > index 11019b5623..7869103c63 100644 > --- a/drivers/net/qede/base/bcm_osal.h > +++ b/drivers/net/qede/base/bcm_osal.h > @@ -443,10 +443,8 @@ u32 qede_osal_log2(u32); > #define OSAL_IOMEM volatile > #define OSAL_UNUSED __rte_unused > #define OSAL_UNLIKELY(x) __builtin_expect(!!(x), 0) > -#define OSAL_MIN_T(type, __min1, __min2) \ > - ((type)(__min1) < (type)(__min2) ? (type)(__min1) : (type)(__min2= )) > -#define OSAL_MAX_T(type, __max1, __max2) \ > - ((type)(__max1) > (type)(__max2) ? (type)(__max1) : (type)(__max2= )) > +#define OSAL_MIN_T(type, __min1, __min2) RTE_MIN_T(__min1, __min2, type) > +#define OSAL_MAX_T(type, __max1, __max2) RTE_MAX_T(__max1, __max2, type) > > void qede_get_mcp_proto_stats(struct ecore_dev *, enum ecore_mcp_protoco= l_type, > union ecore_mcp_protocol_stats *); > diff --git a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h b/drivers/r= aw/ifpga/base/osdep_rte/osdep_generic.h > index 62c5666ca9..427793a578 100644 > --- a/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > +++ b/drivers/raw/ifpga/base/osdep_rte/osdep_generic.h > @@ -44,15 +44,8 @@ extern int ifpga_rawdev_logtype; > #define min(a, b) RTE_MIN(a, b) > #define max(a, b) RTE_MAX(a, b) > > -#define min_t(type, x, y) ({ \ > - type __min1 =3D (x); \ > - type __min2 =3D (y); \ > - __min1 < __min2 ? __min1 : __min2; }) > - > -#define max_t(type, x, y) ({ \ > - type __max1 =3D (x); \ > - type __max2 =3D (y); \ > - __max1 > __max2 ? __max1 : __max2; }) > +#define min_t(type, x, y) RTE_MIN_T(x, y, type) > +#define max_t(type, x, y) RTE_MAX_T(x, y, type) > > #define spinlock_t rte_spinlock_t > #define spinlock_init(x) rte_spinlock_init(x) > -- > 2.43.0 > --00000000000043223d0611b2a39e Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIKTTZ3Xf4wMEfLTtDamA wZZ8hLQSfA37jjrJMKkolx9UMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI0MDIxOTAyMTMyMVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQASxRJsWxVrU2EtMYBKwS8kLyLQ9aa1N249i0kd gOjE+9YhnM9AQyW01T1A0qvaxSpCQr0LzE3754OPOYUhHdSNnladROgyKxHKbRNm4yrflWPQkfQ0 2Nuzfbv5tDMYIrdViglcUDCPrQ6ju/tf70OveMJ9TudKtaUxO4F0r+hAibRbpyxFi0pxfsuvrs5L 8UsBovEHFvVGFPL93Yo/l4xH9G54/oPbZw38u74M5ERIHNMiyLnCGoAOYbWXgYh3ZtYwAYfBpjyZ rI7nT0n8oLgfP9ZEcC/kChX2zOi2NJ83MWDs6R0WX4LVfKNX9zUcWavNbgwsxs4hGWnyqkJll5I7 --00000000000043223d0611b2a39e--