From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1CCADA0546; Wed, 7 Apr 2021 05:04:50 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 045C5140FF9; Wed, 7 Apr 2021 05:04:50 +0200 (CEST) Received: from mail-qv1-f47.google.com (mail-qv1-f47.google.com [209.85.219.47]) by mails.dpdk.org (Postfix) with ESMTP id 7AE94407FF for ; Wed, 7 Apr 2021 05:04:48 +0200 (CEST) Received: by mail-qv1-f47.google.com with SMTP id e19so1904688qvu.3 for ; Tue, 06 Apr 2021 20:04:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=sO1yi9fyR4UIgifaGRApYkPCTDK2vxFunD7A4Ca5uWc=; b=Reug8+9CASer2AVS6vMLefYtSQoVRYK3IwLywBTLkJxnjhV+j6Yi+JMSLjYf21BjIJ zoFU60VrkYsbBJqMq1qp/eSYhStwjgalusx8j+m9qqOYS2Yec6LyoiSvWwfaACuyUPUI /VZ5rsV5CGWMRZLaAdXDxiBAGE6yUf85k2NG8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=sO1yi9fyR4UIgifaGRApYkPCTDK2vxFunD7A4Ca5uWc=; b=QsezWr+XXpAI8w5gPMFQxOBzNPVg4pnlQQQ3uzivJo/UDFCpdmDSxA1mq9OfM5ma1C jcohmo2140UOB9QTGFeugwyaWF2Ldtdbg6bVfQdLtJ2ffVc/HzPGGChkkAYqOoOOeWT/ B/7qil96r80DjFH0VrWK1XB08w6Y3FwwiK+7mGFUs88KVkofgbmmbS917+npbNPqc++F QhzLv0I7iqVDKWtTlbg4M8gw5ao2J6t5SUMIEPOKoPmz5zV+NfjwP+ZZ42dTu+3ubKP2 2DBGxLM6SNmYTNpH0LdKq6xKJ9E93Nxr+CRiz9WCvL2zOdccDHJOGZZVXGLaxwmtANrk skIQ== X-Gm-Message-State: AOAM530dyCBES+yIAyqcBc85gkrSQyyCfI9CUg22elZ1EBOCgxQ0McAH R5UPSO+2R/ahPUEDrsPRB8nC1GJBhv1TMofPN0regWtaQwNCYQ== X-Google-Smtp-Source: ABdhPJyXkmVC1aJi4/vPGbajUcO8sETKG6dQ7/rT4AFhftXUsOCfTTC0bxu9P87wS7I9DMFmZWBC+lELQtx/V2YA6Nk= X-Received: by 2002:a0c:9e0f:: with SMTP id p15mr1285987qve.33.1617764687767; Tue, 06 Apr 2021 20:04:47 -0700 (PDT) MIME-Version: 1.0 References: <20210402032551.24484-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210402032551.24484-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Tue, 6 Apr 2021 20:04:31 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000090ebde05bf5931c1" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix configuring LRO X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000090ebde05bf5931c1 Content-Type: text/plain; charset="UTF-8" On Thu, Apr 1, 2021 at 8:03 PM Kalesh A P wrote: > > From: Kalesh AP > > While configuring LRO, driver should check the return value > of bnxt_hwrm_vnic_tpa_cfg() HWRM command and return error > when the FW command fails. > > Fixes: 0958d8b6435d ("net/bnxt: support LRO") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > > --- > drivers/net/bnxt/bnxt_ethdev.c | 9 +++++---- > 1 file changed, 5 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 0042d8a..463beaa 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -479,10 +479,11 @@ static int bnxt_setup_one_vnic(struct bnxt *bp, uint16_t vnic_id) > > bnxt_hwrm_vnic_plcmode_cfg(bp, vnic); > > - if (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) > - bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 1); > - else > - bnxt_hwrm_vnic_tpa_cfg(bp, vnic, 0); > + rc = bnxt_hwrm_vnic_tpa_cfg(bp, vnic, > + (rx_offloads & DEV_RX_OFFLOAD_TCP_LRO) ? > + true : false); > + if (rc) > + goto err_out; > > return 0; > err_out: > -- > 2.10.1 > --00000000000090ebde05bf5931c1--