From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Thomas Monjalon <thomas@monjalon.net>
Cc: Ferruh Yigit <ferruh.yigit@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Josh Soref <jsoref@gmail.com>,
Josh Soref <jsoref@users.noreply.github.com>,
dpdk-dev <dev@dpdk.org>,
David Marchand <david.marchand@redhat.com>
Subject: Re: [PATCH] Spelling
Date: Mon, 29 Nov 2021 10:11:37 -0800 [thread overview]
Message-ID: <CACZ4nhsGENbybJ2XU0vmVr=y5YFvq3iOLUD09OS3_Hgvb6+SCw@mail.gmail.com> (raw)
In-Reply-To: <2048067.usQuhbGJ8B@thomas>
On Mon, Nov 29, 2021 at 6:02 AM Thomas Monjalon <thomas@monjalon.net> wrote:
>
> 29/11/2021 14:59, Bruce Richardson:
> > On Mon, Nov 29, 2021 at 12:49:56PM +0000, Ferruh Yigit wrote:
> > > On 11/26/2021 7:58 PM, Josh Soref wrote:
> > > > diff --git a/app/test-eventdev/test_order_common.c b/app/test-eventdev/test_order_common.c
> > > > index ff7813f9..603e7c91 100644
> > > > --- a/app/test-eventdev/test_order_common.c
> > > > +++ b/app/test-eventdev/test_order_common.c
> > > > @@ -253,7 +253,7 @@ void
> > > > order_opt_dump(struct evt_options *opt)
> > > > {
> > > > evt_dump_producer_lcores(opt);
> > > > - evt_dump("nb_wrker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
> > > > + evt_dump("nb_worker_lcores", "%d", evt_nr_active_lcores(opt->wlcores));
> > >
> > > Hi Josh, Thanks for the patch.
> > >
> > > The typo fixes for comments and logs are more straightforward, but I have
> > > mixed feeling about the variable / macro typo fixes, let's see what others
> > > think.
> > >
> > > And I think we should get this patch either one of the first patch or last
> > > patch to prevent conflict with other patches.
> >
> > +1 to being a first patch to start things off clean.
> >
> > For the macros, since there is quick a bit of content in the patch, could
> > we have the patch split into a separate patch for macro changes to review
> > separately, allowing the simple doc/printf spelling changes to go in
> > immediately?
>
> +1 to start with a patch on doc, comments and log messages
+1
>
>
next prev parent reply other threads:[~2021-11-29 18:11 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-11-26 19:58 Josh Soref
2021-11-29 12:49 ` Ferruh Yigit
2021-11-29 13:59 ` Bruce Richardson
2021-11-29 14:02 ` Thomas Monjalon
2021-11-29 18:11 ` Ajit Khaparde [this message]
2021-11-29 14:03 ` Ferruh Yigit
2021-11-29 14:12 ` Josh Soref
2021-11-29 14:47 ` Bruce Richardson
2021-11-29 14:52 ` Ferruh Yigit
2021-11-29 16:08 ` [PATCH v2] Spelling comments/text Josh Soref
2022-01-06 16:46 ` Thomas Monjalon
2022-01-11 10:51 ` Thomas Monjalon
2022-01-11 14:00 ` Kevin Traynor
2022-01-11 14:23 ` Thomas Monjalon
2022-01-06 16:52 ` Thomas Monjalon
2022-01-07 11:23 ` Bruce Richardson
2022-01-07 14:58 ` Thomas Monjalon
2022-01-07 15:04 ` Josh Soref
2022-01-07 15:28 ` Bruce Richardson
2022-01-07 16:27 ` Morten Brørup
2022-01-07 16:37 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhsGENbybJ2XU0vmVr=y5YFvq3iOLUD09OS3_Hgvb6+SCw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=bruce.richardson@intel.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=jsoref@gmail.com \
--cc=jsoref@users.noreply.github.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).