From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Kalesh A P <kalesh-anakkur.purayil@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix FW version log
Date: Wed, 20 Jan 2021 23:10:12 -0800 [thread overview]
Message-ID: <CACZ4nhsRpwxHVSV3gHKdBkXypDWF8V6+WsU_gbVBZVOY-P3KUg@mail.gmail.com> (raw)
In-Reply-To: <20210118041211.30707-1-kalesh-anakkur.purayil@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1585 bytes --]
On Sun, Jan 17, 2021 at 7:58 PM Kalesh A P
<kalesh-anakkur.purayil@broadcom.com> wrote:
>
> From: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
>
> Driver is not logging the complete FW version along with HSI version.
> Fix it to indicate complete FW version string.
>
> Fixes: 9a891c1764ea ("net/bnxt: update HWRM to version 1.9.2")
> Cc: stable@dpdk.org
>
> Signed-off-by: Kalesh AP <kalesh-anakkur.purayil@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
> Reviewed-by: Ajit Kumar Khaparde <ajit.khaparde@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index 6d54b16..4d8ca9e 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -1102,10 +1102,11 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout)
> else
> HWRM_CHECK_RESULT();
>
> - PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d\n",
> + PMD_DRV_LOG(INFO, "%d.%d.%d:%d.%d.%d.%d\n",
> resp->hwrm_intf_maj_8b, resp->hwrm_intf_min_8b,
> resp->hwrm_intf_upd_8b, resp->hwrm_fw_maj_8b,
> - resp->hwrm_fw_min_8b, resp->hwrm_fw_bld_8b);
> + resp->hwrm_fw_min_8b, resp->hwrm_fw_bld_8b,
> + resp->hwrm_fw_rsvd_8b);
> bp->fw_ver = (resp->hwrm_fw_maj_8b << 24) |
> (resp->hwrm_fw_min_8b << 16) |
> (resp->hwrm_fw_bld_8b << 8) |
> --
> 2.10.1
>
prev parent reply other threads:[~2021-01-21 7:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-01-18 4:12 Kalesh A P
2021-01-21 7:10 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhsRpwxHVSV3gHKdBkXypDWF8V6+WsU_gbVBZVOY-P3KUg@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=kalesh-anakkur.purayil@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).