From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 723B6A0A03; Tue, 19 Jan 2021 08:40:01 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 50F64140D06; Tue, 19 Jan 2021 08:40:01 +0100 (CET) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id A812C140CF4 for ; Tue, 19 Jan 2021 08:39:59 +0100 (CET) Received: by mail-qk1-f170.google.com with SMTP id h4so21039885qkk.4 for ; Mon, 18 Jan 2021 23:39:59 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=waLmYW5WNBi3KQVyYnMJor9WWcnFfM+mj4VJnQzRXJ0=; b=JgdK2KZpkK00i4fyzCLW+UnkuVqBfFQ/qQYkdouCSpcLbmy6bfxUYJ4Ql0SiUPNfb5 MJr+I8Hc5RHT6gPxPnddzCpyhQfeSbU2IpoelYcVSRgEHqo3SDp3HTJhWCT8cMzSjy3k unf9WfLY36W5Jp/WlMHrgxbFjgw2lOr4SND8o= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=waLmYW5WNBi3KQVyYnMJor9WWcnFfM+mj4VJnQzRXJ0=; b=lgQnc79ZmR6LnqKg58pXKg+zdW0jEC22h4OmBBmqXgjfkwm4+0D0bauAOeP2JT9ddY HrU3tzRhpJ6LlFJVC7WMVwYcML49knV/dra/S6F2AGt/zrk2ckIgWvF/oZ9K497FdckK fdp4Xzqb30y/DfEl2d1qxJMGChSduw6Bzj+laz/pl+Kp7AaYHE6t0R4fQJvmYeQsx36y w7siBJYRX9VomqrCYzl+HHVReNblUjmaUmzemCqtZ8U3vGZfEYJzfrSq4rUS3VXgsK+a scPYn/FD6fK1DAlqAy4qB4kAL5h0fh6oyq9HXRhNxqCqR4P3Gzp2LXYkW4JyV/e8ixIy Zpjw== X-Gm-Message-State: AOAM532sWeE2eAmesEiNvpk1VCtNrZfXRB3w/9Jqx39VKEW2+/K04vg+ mS2HjXFSphxa509bWu9fzWwk5elfPsUT3xJ0DDZPZQ== X-Google-Smtp-Source: ABdhPJyo9raGjg5+8/j7u+6zAdl9ODXl+PBs6Y2g95kqDUi7BaCOo+bG5Jpe3kCT5IlghGDHS5hM5P6UZoBz1HyhKdc= X-Received: by 2002:a05:620a:528:: with SMTP id h8mr3257531qkh.40.1611041998972; Mon, 18 Jan 2021 23:39:58 -0800 (PST) MIME-Version: 1.0 References: <1608303356-13089-2-git-send-email-xuemingl@nvidia.com> <6467622.ieihe5XLyd@thomas> <4783704.kY4qWPY9W3@thomas> In-Reply-To: From: Ajit Khaparde Date: Mon, 18 Jan 2021 23:39:42 -0800 Message-ID: To: "Xueming(Steven) Li" Cc: NBU-Contact-Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Olivier Matz , dpdk-dev , Slava Ovsiienko , Asaf Penso Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000016ce9305b93bf217" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000016ce9305b93bf217 Content-Type: text/plain; charset="UTF-8" On Mon, Jan 18, 2021 at 3:41 PM Xueming(Steven) Li wrote: > > >-----Original Message----- > >From: Ajit Khaparde > >Sent: Tuesday, January 19, 2021 2:18 AM > >To: NBU-Contact-Thomas Monjalon > >Cc: Xueming(Steven) Li ; Ferruh Yigit > >; Andrew Rybchenko > >; Olivier Matz ; > >dpdk-dev ; Slava Ovsiienko ; Asaf > >Penso > >Subject: Re: [dpdk-dev] [PATCH v4 1/9] ethdev: introduce representor type > > > >On Mon, Jan 18, 2021 at 10:15 AM Thomas Monjalon > >wrote: > >> > >> 18/01/2021 19:00, Ajit Khaparde: > >> > On Mon, Jan 18, 2021 at 9:57 AM Thomas Monjalon > > wrote: > >> > > 18/01/2021 18:42, Ajit Khaparde: > >> > > > On Mon, Jan 18, 2021 at 3:17 AM Xueming Li > >wrote: > >> > > > > +enum rte_eth_representor_type { > >> > > > > + RTE_ETH_REPRESENTOR_NONE, /**< not a representor. */ > >> > > > > + RTE_ETH_REPRESENTOR_VF, /**< representor of VF. */ > >> > > > > + RTE_ETH_REPRESENTOR_SF, /**< representor of SF. */ > >> > > > Till we get used to the terminology... > >> > > > Can we also have SF = "Sub Function" mentioned in the docs or > >comments? > >> > > > >> > > Are we sure about the definition? > >> > > I remember seeing SF = Scalable Function somewhere else (maybe from > >Intel) > >> > That complicates it. But if they mean the same thing, let's pick one. > >> > >> I think "Sub Function" and "Virtual Function" are easy to understand > >> for everybody. > >> I suggest picking these two for comments above. > >+1 > > There was an internal discussion and the conclusion is to align with kernel driver name. > Will update comment in next version, thanks! Ok. In that case for the series: Acked-by: Ajit Khaparde > > > > >> --00000000000016ce9305b93bf217--