From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C68A8A034F; Mon, 22 Mar 2021 19:29:49 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5B30B40040; Mon, 22 Mar 2021 19:29:49 +0100 (CET) Received: from mail-qk1-f173.google.com (mail-qk1-f173.google.com [209.85.222.173]) by mails.dpdk.org (Postfix) with ESMTP id C673E4003D for ; Mon, 22 Mar 2021 19:29:47 +0100 (CET) Received: by mail-qk1-f173.google.com with SMTP id y18so11606721qky.11 for ; Mon, 22 Mar 2021 11:29:47 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=bT0Mmm53dCk806wB4CrE/05hArgi/WMJavGdYwb7u9k=; b=Drw1QvTcFc3p3g+ZhzjMjjMSkxr0hFImPrXkJdBvmVZUw/5jRelNpr0zv8sgTOaUzw IaBCDxe7XK70gteoJtQX3rK0zEPstkwnrgsaPxHtHNY5f/YBBmRqjIhgNX/FyNoIw+Qf 3DTquS5RArSBdwMxMrtvUmisLBBN5WdyX1G4A= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=bT0Mmm53dCk806wB4CrE/05hArgi/WMJavGdYwb7u9k=; b=JPlRnG1zKJmwh3j4ogl/NkdFd+OQo/Qg8J9RlmmVrXGcHy/Im1Zx0PP6A7iZ/rkXlj IULDP1hx5jdpS6vlULalGwD4hJjjyPpZR0fU93LrapROjIE8PSZZuzyTh+noBly5oseG Oot0hlTp+spNqtx+Dw/1sVBCAMXOvuHPk35fpCeqQR9dglHybjm/S0IDPeo/sUyYufMh KuFjeY957YMc3f5wI2oDywUoAkyz3h/FqIfXaxerb0cfTI9ty+xjGwIaNxxm5GinSqPy 07QWniVd2x1y1vHiI/TuSmBbH9wCb75OuLRmfqLHhK9CNBOotCY28PzrSy7dI3B17v7g FLJA== X-Gm-Message-State: AOAM531JmgW6deU+p5J4Y49WW1R7VAlj+tgUhiCmYt5bKzmiJQtsoTp9 fGMvcWswBiOn10jgUg1ARtoM1ksj3bsW7zvF5Ehv+w== X-Google-Smtp-Source: ABdhPJwlvZr0NqbQVH+62w+FctZaXBF/0EBXiUhHYujMEm0lmXG7KnbPUjD+g52+eiA0Kew8lEYh0LwM+Z9tYhg61tY= X-Received: by 2002:a05:620a:14ac:: with SMTP id x12mr1345524qkj.409.1616437787084; Mon, 22 Mar 2021 11:29:47 -0700 (PDT) MIME-Version: 1.0 References: <20210320064917.11740-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20210320064917.11740-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Mon, 22 Mar 2021 11:29:31 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000001f3a7305be2440cf" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix memory allocation for command response X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000001f3a7305be2440cf Content-Type: text/plain; charset="UTF-8" On Fri, Mar 19, 2021 at 11:27 PM Kalesh A P wrote: > > From: Kalesh AP > > Driver re-allocates memory for the command response buffer > when the installed firmware version is newer (and has a larger > max response length) than the version of HWRM that was used to > build the PMD. > > This change helps to avoid the re-allocation by allocating the > memory for the command response buffer with PAGE_SIZE. > > Coverity issue: 366256, 366204, 366180 > Fixes: b7778e8a1c00 ("net/bnxt: refactor to properly allocate resources for PF/VF") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Reviewed-by: Ajit Kumar Khaparde > Reviewed-by: Lance Richardson Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 2 +- > drivers/net/bnxt/bnxt_hwrm.c | 27 ++++----------------------- > 2 files changed, 5 insertions(+), 24 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 3724752..ed2ae45 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -5608,7 +5608,7 @@ static int bnxt_drv_init(struct rte_eth_dev *eth_dev) > rc = bnxt_alloc_hwrm_resources(bp); > if (rc) { > PMD_DRV_LOG(ERR, > - "Failed to allocate hwrm resource rc: %x\n", rc); > + "Failed to allocate response buffer rc: %x\n", rc); > return rc; > } > rc = bnxt_alloc_leds_info(bp); > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index e3a0731..6a70b6e 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -1284,28 +1284,8 @@ int bnxt_hwrm_ver_get(struct bnxt *bp, uint32_t timeout) > max_resp_len = rte_le_to_cpu_16(resp->max_resp_len); > dev_caps_cfg = rte_le_to_cpu_32(resp->dev_caps_cfg); > > - if (bp->max_resp_len != max_resp_len) { > - sprintf(type, "bnxt_hwrm_" PCI_PRI_FMT, > - bp->pdev->addr.domain, bp->pdev->addr.bus, > - bp->pdev->addr.devid, bp->pdev->addr.function); > - > - rte_free(bp->hwrm_cmd_resp_addr); > - > - bp->hwrm_cmd_resp_addr = rte_malloc(type, max_resp_len, 0); > - if (bp->hwrm_cmd_resp_addr == NULL) { > - rc = -ENOMEM; > - goto error; > - } > - bp->hwrm_cmd_resp_dma_addr = > - rte_malloc_virt2iova(bp->hwrm_cmd_resp_addr); > - if (bp->hwrm_cmd_resp_dma_addr == RTE_BAD_IOVA) { > - PMD_DRV_LOG(ERR, > - "Unable to map response buffer to physical memory.\n"); > - rc = -ENOMEM; > - goto error; > - } > - bp->max_resp_len = max_resp_len; > - } > + RTE_VERIFY(max_resp_len <= bp->max_resp_len); > + bp->max_resp_len = max_resp_len; > > if ((dev_caps_cfg & > HWRM_VER_GET_OUTPUT_DEV_CAPS_CFG_SHORT_CMD_SUPPORTED) && > @@ -2804,7 +2784,7 @@ int bnxt_alloc_hwrm_resources(struct bnxt *bp) > > sprintf(type, "bnxt_hwrm_" PCI_PRI_FMT, pdev->addr.domain, > pdev->addr.bus, pdev->addr.devid, pdev->addr.function); > - bp->max_resp_len = HWRM_MAX_RESP_LEN; > + bp->max_resp_len = BNXT_PAGE_SIZE; > bp->hwrm_cmd_resp_addr = rte_malloc(type, bp->max_resp_len, 0); > if (bp->hwrm_cmd_resp_addr == NULL) > return -ENOMEM; > @@ -6057,6 +6037,7 @@ int bnxt_hwrm_poll_ver_get(struct bnxt *bp) > int rc = 0; > > bp->max_req_len = HWRM_MAX_REQ_LEN; > + bp->max_resp_len = BNXT_PAGE_SIZE; > bp->hwrm_cmd_timeout = SHORT_HWRM_CMD_TIMEOUT; > > HWRM_PREP(&req, HWRM_VER_GET, BNXT_USE_CHIMP_MB); > -- > 2.10.1 > --0000000000001f3a7305be2440cf--