From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: dpdk stable <stable@dpdk.org>,
Somnath Kotur <somnath.kotur@broadcom.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix VNIC config error in port start
Date: Tue, 24 Aug 2021 20:50:59 -0700 [thread overview]
Message-ID: <CACZ4nhsa81ZE482FMw0s035L2AoS3sOf=u41+es4ko76xOk8Kw@mail.gmail.com> (raw)
In-Reply-To: <20210825012901.80499-1-ajit.khaparde@broadcom.com>
[-- Attachment #1: Type: text/plain, Size: 1845 bytes --]
On Tue, Aug 24, 2021 at 6:29 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> During port stop/start sequence the Thor FW is returning an error.
> This is because we are deriving incorrect active Rx ring and using
> that wrong information in the bnxt_vnic_rss_cfg HWRM command.
>
> Fix it by using the rx_queue_state from eth_dev.
>
> Fixes: 0105ea1296c91 ("net/bnxt: support runtime queue setup")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Somnath Kotur <somnath.kotur@broadcom.com>
Patch applied to dpdk-next-net-brcm.
> ---
> drivers/net/bnxt/bnxt_hwrm.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c
> index eb9de45cb9..f29d574235 100644
> --- a/drivers/net/bnxt/bnxt_hwrm.c
> +++ b/drivers/net/bnxt/bnxt_hwrm.c
> @@ -5078,6 +5078,7 @@ static int
> bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic)
> {
> struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr;
> + uint8_t *rxq_state = bp->eth_dev->data->rx_queue_state;
> struct hwrm_vnic_rss_cfg_input req = {.req_type = 0 };
> struct bnxt_rx_queue **rxqs = bp->rx_queues;
> uint16_t *ring_tbl = vnic->rss_table;
> @@ -5111,7 +5112,7 @@ bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic)
>
> /* Find next active ring. */
> for (cnt = 0; cnt < max_rings; cnt++) {
> - if (rxqs[k]->rx_started)
> + if (rxq_state[k] != RTE_ETH_QUEUE_STATE_STOPPED)
> break;
> if (++k == max_rings)
> k = 0;
> --
> 2.21.1 (Apple Git-122.3)
>
prev parent reply other threads:[~2021-08-25 3:51 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-08-25 1:29 Ajit Khaparde
2021-08-25 3:50 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhsa81ZE482FMw0s035L2AoS3sOf=u41+es4ko76xOk8Kw@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).