From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 771F3A0C57; Wed, 25 Aug 2021 05:51:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 2EF5E406A3; Wed, 25 Aug 2021 05:51:18 +0200 (CEST) Received: from mail-qk1-f170.google.com (mail-qk1-f170.google.com [209.85.222.170]) by mails.dpdk.org (Postfix) with ESMTP id 1D6E840041 for ; Wed, 25 Aug 2021 05:51:16 +0200 (CEST) Received: by mail-qk1-f170.google.com with SMTP id t4so11317559qkb.9 for ; Tue, 24 Aug 2021 20:51:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=rqGO+JlJNCRjWFvH3bwo00qzoGijXll3WLIKpeb/aQU=; b=N6MhstY187SedKHJtZgJ2b5OSgTIsrP4MEekRJHsp79NhCO6Tko31SGhYeIGj8phhb tPcEtgHGFFfO7kFFQgVyimVMr9ie9dH71n1gYBB8QqzNo926Jsu6rFHemx/b0cFkQZMz 8F7aF2oHgcFpicR3c8645RX7M9OBAx2Bn/TIg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=rqGO+JlJNCRjWFvH3bwo00qzoGijXll3WLIKpeb/aQU=; b=e6tVlG6JoGJlShH2wr67sq8mtBAQGzWXYRKPPLiHmexdVUIr7TtO0xu0gKFaCGdxxt crk+/ZI0t2AbALfB3XtynrVDzF+Ajzv8aD321ivdskIsOOo2bEUngQR+zYvL6ZgtO8WC 93rWT3wugWL4kOb1izDs45YZVR6ENKxyIYUEkP/lZEvWVziwFI6M17umlZXMD7y9uiFT Kwnl8WccaN7ZJtoy98c3WUkgH/JU1mpjnCMbAfE/YrdTwvUIsANLlNCOOe24Yb2HzP1f k8Y1nYUUKmu1AQs9NmqBYrzDvQcWGjawPAdLdnndcrB+Nzgkj2liQrEF4E6e4/R7fcFZ ReJQ== X-Gm-Message-State: AOAM531Vx4v4a7gB8j1okc23N35ukx5R3F/6Ak5fulYDDGB5VNjTh3vB cRiCnIcc1z55liMl+1DQWmHt+k7MnoBoZMf29h4VeMQ5Xlg= X-Google-Smtp-Source: ABdhPJyJYjqY/T8XBzPlbXk85G3VxI7I3vPjYjANA1DP74xgf6JbTZZomBCnsRzTWIJgI1Ea9TwYqeKEL7k44nojtPI= X-Received: by 2002:a05:620a:179e:: with SMTP id ay30mr29620952qkb.333.1629863475144; Tue, 24 Aug 2021 20:51:15 -0700 (PDT) MIME-Version: 1.0 References: <20210825012901.80499-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210825012901.80499-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Tue, 24 Aug 2021 20:50:59 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable , Somnath Kotur Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007c104005ca5a296d" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix VNIC config error in port start X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000007c104005ca5a296d Content-Type: text/plain; charset="UTF-8" On Tue, Aug 24, 2021 at 6:29 PM Ajit Khaparde wrote: > > During port stop/start sequence the Thor FW is returning an error. > This is because we are deriving incorrect active Rx ring and using > that wrong information in the bnxt_vnic_rss_cfg HWRM command. > > Fix it by using the rx_queue_state from eth_dev. > > Fixes: 0105ea1296c91 ("net/bnxt: support runtime queue setup") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_hwrm.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index eb9de45cb9..f29d574235 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -5078,6 +5078,7 @@ static int > bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) > { > struct hwrm_vnic_rss_cfg_output *resp = bp->hwrm_cmd_resp_addr; > + uint8_t *rxq_state = bp->eth_dev->data->rx_queue_state; > struct hwrm_vnic_rss_cfg_input req = {.req_type = 0 }; > struct bnxt_rx_queue **rxqs = bp->rx_queues; > uint16_t *ring_tbl = vnic->rss_table; > @@ -5111,7 +5112,7 @@ bnxt_vnic_rss_configure_p5(struct bnxt *bp, struct bnxt_vnic_info *vnic) > > /* Find next active ring. */ > for (cnt = 0; cnt < max_rings; cnt++) { > - if (rxqs[k]->rx_started) > + if (rxq_state[k] != RTE_ETH_QUEUE_STATE_STOPPED) > break; > if (++k == max_rings) > k = 0; > -- > 2.21.1 (Apple Git-122.3) > --0000000000007c104005ca5a296d--