From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E46FCA04F3; Tue, 7 Jan 2020 22:50:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4B7A21D983; Tue, 7 Jan 2020 22:50:58 +0100 (CET) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id 6E5401D543 for ; Tue, 7 Jan 2020 22:50:56 +0100 (CET) Received: by mail-oi1-f193.google.com with SMTP id a67so857809oib.6 for ; Tue, 07 Jan 2020 13:50:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+W+eP64TmEc4PqX0VOvjLORORUnSV1oFcYrlxxInFnI=; b=Qn2SyBz6htkqDTS1ZhgxkXQeWwKh0/xrq3PNlRJ6Zejq/Bk+zOgzm6qgupFZ7mifIS ugLg8nzD6+JZ9w7lHPPuINBUh7ZtuS1B0CguXFjdzAuw5Nk1GmqP9GbdDD4SkxbFcg6G z6iY1jf4zTCX8Fa6lUGrbHFY61a8bNjjAFp3Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+W+eP64TmEc4PqX0VOvjLORORUnSV1oFcYrlxxInFnI=; b=ZPLK7GWH1tMwq8NDlN3ItCXCjHXmOe3zEOWXnbMP9JhpKt9xOsS3qi2p3uFQnjw+NI O8PNe71liN+z62gOJwIWKVkVwtXyXJ0lVlREaOPYBk3eFqi0+5obDcduHutBv6Kgfuo4 a3Uj4woYAs/JsVvG72y7DIrvuomgmYk6roBkIJzRSQfOmCyzt3LdPLsE5r8MkURpI33N Fdr6B3YXQTIuqRAj6LEkI+PG8JNUMu1/YWlVq1INQrUrCaiI5J4+Ir0y2WnjyyTZLqRO uCbJHAVFlwYsO/dhzM0tpbzQGByRLlgBmJrKXUZOwQjlvQsq/8rYYmsvWOQZdXsFwkLw hRlA== X-Gm-Message-State: APjAAAU9UOrVMo6IwIuUMPkqMurcDkI863I3R7sWffw0nIGv1KaiIU4V aY73ibHvawbvUpQE1+9+qOzuiQiQnZy17ytd6P1Dyw== X-Google-Smtp-Source: APXvYqy9FbtgeMRHV8ejXIDQJLCAPMobKADng5xSZtUVFM4uoNbo6RspzQSszAuY/LPqjYj0lHIiCrufoQLdJElAghQ= X-Received: by 2002:a05:6808:81:: with SMTP id s1mr445550oic.179.1578433855359; Tue, 07 Jan 2020 13:50:55 -0800 (PST) MIME-Version: 1.0 References: <20191221022937.54397-1-ajit.khaparde@broadcom.com> <20200107003735.96055-1-ajit.khaparde@broadcom.com> <20200107003735.96055-8-ajit.khaparde@broadcom.com> <3cceeb84-3f0f-6876-272f-cfba399f8ba3@intel.com> In-Reply-To: <3cceeb84-3f0f-6876-272f-cfba399f8ba3@intel.com> From: Ajit Khaparde Date: Tue, 7 Jan 2020 13:50:38 -0800 Message-ID: To: Ferruh Yigit Cc: dpdk-dev , dpdk stable , Lance Richardson Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 7/7] net/bnxt: fix to not overwrite error message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Jan 7, 2020 at 1:18 AM Ferruh Yigit wrote: > On 1/7/2020 12:37 AM, Ajit Khaparde wrote: > > In some cases when flow creation fails, we overwrite the specific > > error message with a generic error message. This patch fixes it. > > > > Fixes: d24610f7bfda ("net/bnxt: allow flow creation when RSS is enabled") > > Cc: stable@dpdk.org > > > > Signed-off-by: Ajit Khaparde > > Reviewed-by: Lance Richardson > > --- > > drivers/net/bnxt/bnxt_flow.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > > index 707aedcec..cde1fa41c 100644 > > --- a/drivers/net/bnxt/bnxt_flow.c > > +++ b/drivers/net/bnxt/bnxt_flow.c > > @@ -1485,7 +1485,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev > *dev, > > if (rxq && !vnic->rx_queue_cnt) > > rxq->vnic = &bp->vnic_info[0]; > > } > > - return rc; > > + return -rte_errno; > > The result will be same as far as I can see, you may get rid of the "rc = > -rte_errno;" assignments before "goto ret;" with this change if you want. > I had that change lined up for my next set. But I can send it early. > > Also commit log seems describing the below change not this one ... > > > } > > > > static > > @@ -1815,7 +1815,7 @@ bnxt_flow_create(struct rte_eth_dev *dev, > > rte_flow_error_set(error, 0, > > RTE_FLOW_ERROR_TYPE_NONE, NULL, > > "Flow with pattern exists, updating > destination queue"); > > - else > > + else if (!rte_errno) > > rte_flow_error_set(error, -ret, > > RTE_FLOW_ERROR_TYPE_HANDLE, NULL, > > "Failed to create flow."); > > > >