From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1A4CFA00BE; Thu, 28 May 2020 03:05:32 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 329921D9F4; Thu, 28 May 2020 03:05:31 +0200 (CEST) Received: from mail-oo1-f66.google.com (mail-oo1-f66.google.com [209.85.161.66]) by dpdk.org (Postfix) with ESMTP id 53C131D9E9 for ; Thu, 28 May 2020 03:05:29 +0200 (CEST) Received: by mail-oo1-f66.google.com with SMTP id i9so5409924ool.5 for ; Wed, 27 May 2020 18:05:29 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=AXVuAd75XRvZtOjo2I22OiTB5JNpYnmMgTzqta7vIe0=; b=A21MlH7Vd4KSIJqcoF9VxiM5D6THtKyRBBtlN7VELacAPFVi4SF5NS5e2GilaCTaNH +s9mpg5S+KVF5j90omr5jXPa2+xouHjZxXqjOSTTAOGHVF6c+yM3HhYT8BZWByF+BG8+ NE9AenL5UmkTd0cpM1BioHfPcKK+uvc56qsFQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=AXVuAd75XRvZtOjo2I22OiTB5JNpYnmMgTzqta7vIe0=; b=F81VxMrauQ7wovLBF7XgvGTloPZXwC5fWoe2BNBfu+UtwZZBXvZ+/k4mbRozxfIMQ1 VkIHPuOFQNKvkFwZMiDCEaOPkm2uyTvKmO8MFwbmmgdYSqbc1+mVO1x9tUUdbgd+8/K6 vjdia1aFUjuBBy7U37JhYWGbIyTMhq3+QlYzrW/YWq6SgOcJS1xzmYk50H4a32lyyf3I gC2sEgxg6RbBbcMYjyqOM8YRnKGyru6fWWG3LruZmcrGZVSGyyBPaA77xeBcbLVp9XcH kfr/szMAuqwAOqW0RGssEy2FgA3TmfEYcQJoLL/0IehhsIfyqpfrfMwhOiSdwVaWFBol AfaQ== X-Gm-Message-State: AOAM530ga+kcfqXt0QzOFpZ4gh/GGHNabN/Q9LYzUgNjAawxbsnL9kdh 3GHlPWJjIMFfqPVgof6aorQFqOi0N6g6YRHPrF6mHw== X-Google-Smtp-Source: ABdhPJybljT5paF+jLesMa43w5vN19IFGuNSNjXNP7fBB3PJKKhSpCSUl/ROox3u9x9Reo4NRjN9Ma9FYLb9GQedPGI= X-Received: by 2002:a4a:5548:: with SMTP id e69mr689421oob.23.1590627928279; Wed, 27 May 2020 18:05:28 -0700 (PDT) MIME-Version: 1.0 References: In-Reply-To: From: Ajit Khaparde Date: Wed, 27 May 2020 18:05:12 -0700 Message-ID: To: Somnath Kotur Cc: wangyunjian , dev , jerry.lilijun@huawei.com, xudingke@huawei.com, dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix missed unlock reported by coverity X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, May 27, 2020 at 5:13 AM Somnath Kotur wrote: > On Wed, May 27, 2020 at 5:42 PM wangyunjian > wrote: > > > > From: Yunjian Wang > > > > Coverity issue: 357741 > > Fixes: 02a95625fe9c ("net/bnxt: add flow stats in extended stats") > > Cc: stable@dpdk.org > > > > Signed-off-by: Yunjian Wang > Patch applied to dpdk-next-net-brcm. Thanks > > --- > > drivers/net/bnxt/bnxt_stats.c | 4 +++- > > 1 file changed, 3 insertions(+), 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_stats.c > b/drivers/net/bnxt/bnxt_stats.c > > index cfe193284..8df6922f5 100644 > > --- a/drivers/net/bnxt/bnxt_stats.c > > +++ b/drivers/net/bnxt/bnxt_stats.c > > @@ -1008,8 +1008,10 @@ int bnxt_flow_stats_req(struct bnxt *bp) > > } > > } > > > > - if (!in_flow_tbl_cnt) > > + if (!in_flow_tbl_cnt) { > > + bnxt_release_flow_lock(bp); > > goto out; > > + } > > > > rc = bnxt_update_fc_tbl(bp, counter_type, valid_en_tbl, > > in_flow_tbl_cnt); > > -- > > 2.23.0 > > > > > Acked-by: Somnath Kotur >