From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 70CEBA0C43;
	Tue, 12 Oct 2021 06:09:15 +0200 (CEST)
Received: from [217.70.189.124] (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 37113410E4;
	Tue, 12 Oct 2021 06:09:15 +0200 (CEST)
Received: from mail-io1-f42.google.com (mail-io1-f42.google.com
 [209.85.166.42]) by mails.dpdk.org (Postfix) with ESMTP id B99DC40E0F
 for <dev@dpdk.org>; Tue, 12 Oct 2021 06:09:14 +0200 (CEST)
Received: by mail-io1-f42.google.com with SMTP id h196so9431986iof.2
 for <dev@dpdk.org>; Mon, 11 Oct 2021 21:09:14 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=mriTzRn0DquvxB9BiWu9FVkEEc/YKr+o/Z35c4OzZls=;
 b=bnF7RDsS8G51MhU5ecu9218+QMoE2OHzSx7twHv6yp3d4ZObsnlj5A81AfqxXoEEIb
 8j05BLJGFIEZb/zBqHxTONXGzovfGoqi2S5XlVY8dWGKqUFym3d6Aw/OZlu+fctEuOOh
 N6qz+jWarjbxHqw5qw4MCHIfmx6ERkBvJQpGo=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20210112;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=mriTzRn0DquvxB9BiWu9FVkEEc/YKr+o/Z35c4OzZls=;
 b=vZhbyBqT4ANnqG2tbkWRbejVU5qfnc+MILhYC4p3DrCbg/XvPNqINtq7GJpND9fTG4
 zsOL1cgaN5kF9sqMvuno/wV2ntbh83Tpn4AZSvZA2vINipSutNhzGXP9HnWa4lJ6UQLY
 V326sp1iDci0NtAYKE2Q0ZBBDW6JGI+ood0o9rw/D7HJNoyU+u9pokN21rtkZx/T7gSk
 SWpsp3v15wupozHUNpnqqfDnVl9J9HdYBB9I9vrfIy3RJ6CFCpM25kTfP830mu1cL2Cv
 W5KGQDHyjXEGAG+jvgNmp88Bzf6USxRoMEJJ9DU8g9SFhqfvATchCOSrXjSH970bY1bk
 sohQ==
X-Gm-Message-State: AOAM533N4ssSMGI/8bz6mjL5BYPZrwkqTyfTjx1MfGEAijTbAwL5vLW6
 OdXA88D4/XeoMd9oTNAYhAvIpPUCJHmJ9dx+c83f0H2yggI=
X-Google-Smtp-Source: ABdhPJxcbIOsIxxwvMr9M5jRm4iWpfNha+gHRrKL0ZxhdAFgt2ABgEih90GOWKNWR4xZg/VNBWBsiW14GtqbmvTKm2E=
X-Received: by 2002:a6b:3b85:: with SMTP id
 i127mr21355862ioa.111.1634011754078; 
 Mon, 11 Oct 2021 21:09:14 -0700 (PDT)
MIME-Version: 1.0
References: <20211010040755.3882-1-ajit.khaparde@broadcom.com>
 <20211011194626.34709481@hermes.local>
In-Reply-To: <20211011194626.34709481@hermes.local>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Mon, 11 Oct 2021 21:08:58 -0700
Message-ID: <CACZ4nhsr2n0pVWSHJOGfkBm_HpLBXXeHYVAqkwyObNUMPaX2wA@mail.gmail.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dpdk-dev <dev@dpdk.org>, Shahaji Bhosle <sbhosle@broadcom.com>
Content-Type: multipart/signed; protocol="application/pkcs7-signature";
 micalg=sha-256; boundary="0000000000002cb9a605ce20021e"
X-Content-Filtered-By: Mailman/MimeDel 2.1.29
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix clang compiler warnings
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

--0000000000002cb9a605ce20021e
Content-Type: text/plain; charset="UTF-8"

On Mon, Oct 11, 2021 at 7:46 PM Stephen Hemminger
<stephen@networkplumber.org> wrote:
>
> On Sat,  9 Oct 2021 21:07:55 -0700
> Ajit Khaparde <ajit.khaparde@broadcom.com> wrote:
>
> > +             if ((uint32_t)item->type >=
> > +                 (uint32_t)BNXT_RTE_FLOW_ITEM_TYPE_END) {
>
>
> This doesn't look right, you are casting away your troubles, not addressing
> the root cause.
>
> item->type is type rte_flow_item_type
> BNXT_FLOW_ITEM_TYPE_END is the first item in that enum.
>
> So yes the warning is valid and the code is wrong.
Thanks. We will work on the proper fix.

--0000000000002cb9a605ce20021e--