From: Ajit Khaparde <ajit.khaparde@broadcom.com> To: Alexander Kozyrev <akozyrev@nvidia.com> Cc: dpdk-dev <dev@dpdk.org>, Slava Ovsiienko <viacheslavo@nvidia.com>, Ori Kam <orika@nvidia.com>, Thomas Monjalon <thomas@monjalon.net>, Ferruh Yigit <ferruh.yigit@intel.com>, Andrew Rybchenko <andrew.rybchenko@oktetlabs.ru>, Jerin Jacob <jerinjacobk@gmail.com> Subject: Re: [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support Date: Mon, 18 Jan 2021 12:05:23 -0800 Message-ID: <CACZ4nhssd8a7gNKMgeXcU3-tPbaDbx4mD1EhH5fUCjDbJJCHgg@mail.gmail.com> (raw) In-Reply-To: <20210118161825.31516-1-akozyrev@nvidia.com> [-- Attachment #1: Type: text/plain, Size: 2255 bytes --] On Mon, Jan 18, 2021 at 8:18 AM Alexander Kozyrev <akozyrev@nvidia.com> wrote: > > Implement a generic modify rte flow API as described in RFC: > http://patches.dpdk.org/patch/85384/ > > This API allows modifying a destination header field with data from > a source header field. Number of bits to use from the source is specified. > Tag, Mark or Metadata can also be used as a source/destination to allow > saving/overwriting an arbitrary header field with a user-specified value. > Alternatively, an immediate value can be provided by a user as a source. > > Outermost/innermost packet fields (and Tag array elements) are > accessible via the level parameter to facilitate the modification > of encapsulated packet header fields. The offset parameter provides > the flexibility to copy/set any part of a packet starting the > specified packet header field. > > Example of RTE_FLOW_ACTION_TYPE_MODIFY_FIELD implementation for MLX5: > https://patchwork.dpdk.org/patch/86736/ > > --- > v1: https://patchwork.dpdk.org/patch/86173/ > Initial design. > v2: https://patchwork.dpdk.org/cover/86369/ > Added testpmd support. > v3: https://patchwork.dpdk.org/cover/86442/ > Made dst_type, src_type and width only mandatory parameters. > v4: https://patchwork.dpdk.org/cover/86488/ > Renamed action to RTE_FLOW_ACTION_TYPE_COPY_FIELD. > v5: https://patchwork.dpdk.org/cover/86705/ > Redesigned as RTE_FLOW_ACTION_TYPE_MODIFY_FIELD. > v6: https://patchwork.dpdk.org/cover/86715/ > Fixed typos in documentation. > v7: https://patchwork.dpdk.org/cover/86718/ > Fixed warnings. > v8: > Added doxygen comments. > > Alexander Kozyrev (2): > ethdev: introduce generic modify rte flow action > app/testpmd: add support for modify field flow action I see Thomas has some comments on one of the patches. Please address that. Otherwise ack for the series. Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com> > > app/test-pmd/cmdline_flow.c | 246 +++++++++++++++++++++++++ > doc/guides/prog_guide/rte_flow.rst | 66 +++++++ > doc/guides/rel_notes/release_21_02.rst | 8 + > lib/librte_ethdev/rte_flow.c | 2 + > lib/librte_ethdev/rte_flow.h | 87 ++++++++- > 5 files changed, 408 insertions(+), 1 deletion(-) > > -- > 2.24.1 >
next prev parent reply other threads:[~2021-01-18 20:05 UTC|newest] Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top 2021-01-08 6:32 [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-10 8:00 ` Ori Kam 2021-01-10 9:36 ` Asaf Penso 2021-01-12 14:15 ` Alexander Kozyrev 2021-01-12 14:52 ` Ori Kam 2021-01-12 15:13 ` Ori Kam 2021-01-12 17:19 ` Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-12 5:01 ` [dpdk-dev] [PATCH v2 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-12 14:58 ` Ori Kam 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-13 11:12 ` Ori Kam 2021-01-13 3:38 ` [dpdk-dev] [PATCH v3 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 0/2] generic copy rte flow action support Alexander Kozyrev 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 1/2] ethdev: introduce generic copy rte flow action Alexander Kozyrev 2021-01-14 12:22 ` Ori Kam 2021-01-13 17:07 ` [dpdk-dev] [PATCH v4 2/2] app/testpmd: add support for " Alexander Kozyrev 2021-01-14 15:18 ` Ori Kam 2021-01-15 15:37 ` Alexander Kozyrev 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-15 18:03 ` Ori Kam 2021-01-17 9:23 ` Slava Ovsiienko 2021-01-15 15:42 ` [dpdk-dev] [PATCH v5 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-15 18:04 ` Ori Kam 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-16 4:44 ` [dpdk-dev] [PATCH v6 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-17 23:15 ` Thomas Monjalon 2021-01-18 16:03 ` Alexander Kozyrev 2021-01-16 4:50 ` [dpdk-dev] [PATCH v7 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-18 17:51 ` Thomas Monjalon 2021-01-18 16:18 ` [dpdk-dev] [PATCH v8 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-18 20:05 ` Ajit Khaparde [this message] 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 0/2] generic modify rte flow action support Alexander Kozyrev 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 1/2] ethdev: introduce generic modify rte flow action Alexander Kozyrev 2021-01-18 21:40 ` [dpdk-dev] [PATCH v9 2/2] app/testpmd: add support for modify field " Alexander Kozyrev 2021-01-19 1:21 ` [dpdk-dev] [PATCH v9 0/2] generic modify rte flow action support Ferruh Yigit 2021-01-14 13:59 ` [dpdk-dev] [PATCH] ethdev: introduce generic copy rte flow action Jerin Jacob 2021-01-14 15:02 ` Ori Kam 2021-01-15 14:00 ` Jerin Jacob 2021-01-15 15:33 ` Alexander Kozyrev
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=CACZ4nhssd8a7gNKMgeXcU3-tPbaDbx4mD1EhH5fUCjDbJJCHgg@mail.gmail.com \ --to=ajit.khaparde@broadcom.com \ --cc=akozyrev@nvidia.com \ --cc=andrew.rybchenko@oktetlabs.ru \ --cc=dev@dpdk.org \ --cc=ferruh.yigit@intel.com \ --cc=jerinjacobk@gmail.com \ --cc=orika@nvidia.com \ --cc=thomas@monjalon.net \ --cc=viacheslavo@nvidia.com \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
DPDK patches and discussions This inbox may be cloned and mirrored by anyone: git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git # If you have public-inbox 1.1+ installed, you may # initialize and index your mirror using the following commands: public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \ dev@dpdk.org public-inbox-index dev Example config snippet for mirrors. Newsgroup available over NNTP: nntp://inbox.dpdk.org/inbox.dpdk.dev AGPL code for this site: git clone https://public-inbox.org/public-inbox.git