DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Lance Richardson <lance.richardson@broadcom.com>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>,
	dpdk-dev <dev@dpdk.org>,  Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix powerpc build
Date: Tue, 15 Sep 2020 08:38:43 -0700
Message-ID: <CACZ4nht2H6F_VDzC4TfpXGVi066mtajD3Zy-Gj9YtydpnHFvHQ@mail.gmail.com> (raw)
In-Reply-To: <20200915140735.209826-1-lance.richardson@broadcom.com>

On Tue, Sep 15, 2020 at 7:07 AM Lance Richardson <
lance.richardson@broadcom.com> wrote:

> A previous commit broke compilation for builds other than x86 and
> aarch64. Fix by moving macro definitions to more appropriate header
> files.
>
> Fixes: 479387565605 ("net/bnxt: improve small ring sizes support")
> Signed-off-by: Lance Richardson <lance.richardson@broadcom.com>
>
Ferruh,
Let me know if you can pick this directly or would like to pull through the
subtree.

Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
Also adding
Reported-by: Raslan Darawsheh <rasland@nvidia.com>

---
>  drivers/net/bnxt/bnxt_rxq.c             | 1 -
>  drivers/net/bnxt/bnxt_rxq.h             | 3 +++
>  drivers/net/bnxt/bnxt_rxr.c             | 1 -
>  drivers/net/bnxt/bnxt_rxr.h             | 3 +++
>  drivers/net/bnxt/bnxt_rxtx_vec_common.h | 4 ----
>  drivers/net/bnxt/bnxt_txq.c             | 1 -
>  drivers/net/bnxt/bnxt_txq.h             | 3 +++
>  7 files changed, 9 insertions(+), 7 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxq.c b/drivers/net/bnxt/bnxt_rxq.c
> index 57ba9a157..793a47d11 100644
> --- a/drivers/net/bnxt/bnxt_rxq.c
> +++ b/drivers/net/bnxt/bnxt_rxq.c
> @@ -14,7 +14,6 @@
>  #include "bnxt_rxq.h"
>  #include "bnxt_rxr.h"
>  #include "bnxt_vnic.h"
> -#include "bnxt_rxtx_vec_common.h"
>  #include "hsi_struct_def_dpdk.h"
>
>  /*
> diff --git a/drivers/net/bnxt/bnxt_rxq.h b/drivers/net/bnxt/bnxt_rxq.h
> index 96c6e06a5..fae92ea45 100644
> --- a/drivers/net/bnxt/bnxt_rxq.h
> +++ b/drivers/net/bnxt/bnxt_rxq.h
> @@ -6,6 +6,9 @@
>  #ifndef _BNXT_RQX_H_
>  #define _BNXT_RQX_H_
>
> +/* Maximum receive burst supported in vector mode. */
> +#define RTE_BNXT_MAX_RX_BURST          64U
> +
>  struct bnxt;
>  struct bnxt_rx_ring_info;
>  struct bnxt_cp_ring_info;
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 89a964a49..ca3e0a521 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -20,7 +20,6 @@
>  #ifdef RTE_LIBRTE_IEEE1588
>  #include "bnxt_hwrm.h"
>  #endif
> -#include "bnxt_rxtx_vec_common.h"
>
>  #include <bnxt_tf_common.h>
>  #include <ulp_mark_mgr.h>
> diff --git a/drivers/net/bnxt/bnxt_rxr.h b/drivers/net/bnxt/bnxt_rxr.h
> index 4f5e23b85..250033690 100644
> --- a/drivers/net/bnxt/bnxt_rxr.h
> +++ b/drivers/net/bnxt/bnxt_rxr.h
> @@ -167,6 +167,9 @@ static inline uint16_t bnxt_tpa_start_agg_id(struct
> bnxt *bp,
>
>  #define BNXT_RX_POST_THRESH    32
>
> +/* Number of descriptors to process per inner loop in vector mode. */
> +#define RTE_BNXT_DESCS_PER_LOOP                4U
> +
>  enum pkt_hash_types {
>         PKT_HASH_TYPE_NONE,     /* Undefined type */
>         PKT_HASH_TYPE_L2,       /* Input: src_MAC, dest_MAC */
> diff --git a/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> index 8c10fdfa1..4a48152fc 100644
> --- a/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> +++ b/drivers/net/bnxt/bnxt_rxtx_vec_common.h
> @@ -9,10 +9,6 @@
>  #include "bnxt_rxq.h"
>  #include "bnxt_rxr.h"
>
> -#define RTE_BNXT_MAX_RX_BURST          64U
> -#define RTE_BNXT_MAX_TX_BURST          64U
> -#define RTE_BNXT_DESCS_PER_LOOP                4U
> -
>  #define TX_BD_FLAGS_CMPL ((1 << TX_BD_LONG_FLAGS_BD_CNT_SFT) | \
>                           TX_BD_SHORT_FLAGS_COAL_NOW | \
>                           TX_BD_SHORT_TYPE_TX_BD_SHORT | \
> diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c
> index 42930abbf..bdc7ffaaa 100644
> --- a/drivers/net/bnxt/bnxt_txq.c
> +++ b/drivers/net/bnxt/bnxt_txq.c
> @@ -11,7 +11,6 @@
>  #include "bnxt_ring.h"
>  #include "bnxt_txq.h"
>  #include "bnxt_txr.h"
> -#include "bnxt_rxtx_vec_common.h"
>
>  /*
>   * TX Queues
> diff --git a/drivers/net/bnxt/bnxt_txq.h b/drivers/net/bnxt/bnxt_txq.h
> index 83a98536d..9f849fc71 100644
> --- a/drivers/net/bnxt/bnxt_txq.h
> +++ b/drivers/net/bnxt/bnxt_txq.h
> @@ -6,6 +6,9 @@
>  #ifndef _BNXT_TXQ_H_
>  #define _BNXT_TXQ_H_
>
> +/* Maximum transmit burst for vector mode.  */
> +#define RTE_BNXT_MAX_TX_BURST          64U
> +
>  struct bnxt_tx_ring_info;
>  struct bnxt_cp_ring_info;
>  struct bnxt_tx_queue {
> --
> 2.25.1
>
>

  reply	other threads:[~2020-09-15 15:39 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-09-15 14:07 Lance Richardson
2020-09-15 15:38 ` Ajit Khaparde [this message]
2020-09-15 16:08   ` Ferruh Yigit
2020-09-15 17:04     ` Ferruh Yigit

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nht2H6F_VDzC4TfpXGVi066mtajD3Zy-Gj9YtydpnHFvHQ@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=lance.richardson@broadcom.com \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

This inbox may be cloned and mirrored by anyone:

	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev

Example config snippet for mirrors.
Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git