From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51C5BA0C45; Thu, 28 Oct 2021 06:25:04 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CB4474067B; Thu, 28 Oct 2021 06:25:03 +0200 (CEST) Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mails.dpdk.org (Postfix) with ESMTP id EA9C04003F for ; Thu, 28 Oct 2021 06:25:01 +0200 (CEST) Received: by mail-io1-f43.google.com with SMTP id o184so6447326iof.6 for ; Wed, 27 Oct 2021 21:25:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZiGWSRD+r1JCctHzsHy0Jmc4dhiOPy40aD5+ROATaoc=; b=MaGwf8URXv/z3+uRaS7/C2TdzE8euSmJ5c4MtWKMVUqKJhDoZm10SRJMWjsDgYULk5 wi4OKWSWirn0c7rF3DUS5MMBaXhnuXHtBj0semat5wZR1cgBCTKyRc1BCcsYsejbPYl+ RrpqxRknXFt+yBcMuhNFUEyonmRj6PoyKB7bY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZiGWSRD+r1JCctHzsHy0Jmc4dhiOPy40aD5+ROATaoc=; b=iFJ1Wyi+d8SXr3UIISGluGDGa4mN/7owPbEUj5gaIfziLJ8YWKl+3+g8AQvFLwqXcE r3l/sR+y0biELzlbMrfx0asvtIxUxluQUAhLYsUUDftIwKZ4TUHvHuPZRVqAJD23KSge LN7WJNcxRzrBuYO4rKpWDLMHj6II3QuuPS2/sGhoo1rf3xxT6RmJlhPEtqvhBF3XEWk/ 1jReaPTvXnMSwn7vxqBsL/3WMhpRg/XMZpyuecufaGShwCQ7SYyLi/8kEaDMTavq7qNe jxCnU2REpw1ljMS4csF5mOX8VsJB67xdm6VlFYkgOnDn9h6T57YqUJHB1IYWbaQTmXpS WTzg== X-Gm-Message-State: AOAM5325PnzVWHJ5RP9zsEUQ1Y4ijpWfRpGmNJ4L4UelAYIGiyALv7Hp /55ymkckvdXqJOeLG9eRgeekkUGOx5g3j0wATFs64g== X-Google-Smtp-Source: ABdhPJyskN/Td34s/UgWZuY0+1p86Cq9dMIv2Et5+zlR+FbIvbmp8z0pAe1D9Vg16G7+FmZmd3fJvkjGglWYw3E5UTw= X-Received: by 2002:a5d:878e:: with SMTP id f14mr1319649ion.111.1635395101219; Wed, 27 Oct 2021 21:25:01 -0700 (PDT) MIME-Version: 1.0 References: <20211028022944.26402-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20211028022944.26402-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Wed, 27 Oct 2021 21:24:45 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to set flow error in case of failure X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Wed, Oct 27, 2021 at 7:09 PM Kalesh A P wrote: > > From: Kalesh AP > > With commit 239695f754cb ("net/bnxt: enhance RSS action support"), > when bnxt_hwrm_vnic_rss_cfg() call fails, driver was not setting > flow error using "rte_flow_error_set". > > Fixes: 239695f754cb ("net/bnxt: enhance RSS action support") > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_flow.c | 11 ++++++++++- > 1 file changed, 10 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c > index 9526a8f..b3c68b1 100644 > --- a/drivers/net/bnxt/bnxt_flow.c > +++ b/drivers/net/bnxt/bnxt_flow.c > @@ -1226,6 +1226,15 @@ bnxt_vnic_rss_cfg_update(struct bnxt *bp, > > skip_rss_table: > rc = bnxt_hwrm_vnic_rss_cfg(bp, vnic); > + if (rc != 0) { > + rte_flow_error_set(error, > + -rc, > + RTE_FLOW_ERROR_TYPE_ACTION, > + act, > + "VNIC RSS configure failed"); > + rc = -rte_errno; > + goto ret; > + } > ret: > return rc; > } > @@ -1515,7 +1524,7 @@ bnxt_validate_and_parse_flow(struct rte_eth_dev *dev, > /* RSS config update requested */ > rc = bnxt_vnic_rss_cfg_update(bp, vnic, act, error); > if (rc != 0) > - return -rte_errno; > + goto ret; > > filter->dst_id = vnic->fw_vnic_id; > break; > -- > 2.10.1 >