From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6835F4254E; Sat, 9 Sep 2023 02:02:17 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 101D040295; Sat, 9 Sep 2023 02:02:17 +0200 (CEST) Received: from mail-pj1-f49.google.com (mail-pj1-f49.google.com [209.85.216.49]) by mails.dpdk.org (Postfix) with ESMTP id 274254027F for ; Sat, 9 Sep 2023 02:02:15 +0200 (CEST) Received: by mail-pj1-f49.google.com with SMTP id 98e67ed59e1d1-26d0d376ec7so2007019a91.2 for ; Fri, 08 Sep 2023 17:02:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1694217734; x=1694822534; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=cBjLZRTaPzpxMh6+uI51btku5Ya1Jx3vUUVWlq2+Wro=; b=IC95Ghi0Y0Kto7mtlR0ERUh1SQUhZeJCK3t0ZIAnAA/+1ZSgkd0tSTxZc35gwx1g/+ 1ny4a2V/Uyv4OkYxm05YdUuJTFwGgop/LoGQGc0j2B25KCwjPg5KQQVIXlLoSXyTn0CW 7FA3q949AxQkjBV/XQWd4V6SG7d485fY5SOIU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1694217734; x=1694822534; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=cBjLZRTaPzpxMh6+uI51btku5Ya1Jx3vUUVWlq2+Wro=; b=I749nCZazuFLMRSH811+F5T2cP5/Wfmb6uCSji8YWvRtkyeLlKfoQ1FDlEuQWqZ/kc C2BeEoSP6YW7EjUud1U5efZWBKwJIdW4xh7m1X2Zhrg5g7QOyOZMmrTd4FsvKMWrFc8V RGm/NrJFgZjXWZgnVYsxFaaSZEvZSHhq0UzqZyschJnSjGh5x18Aj+4MT40kposcnWU9 VAe5ra9IfyRbmF545qO0tXCXf7q6ThxmrzlUCB791n7W5Srg78Hmj83yxbzTAT3YHC8n LmUirQ7ATzGvMajaH1SQ2bkpk8X2tcVUdzEAhBcmsCQByYo5wIH8TipCpZeT0JJOgOwd iHxQ== X-Gm-Message-State: AOJu0YxfuxK2PbHG94ZFUYWdM32G51To+BhmTnYQt5CVDT7sLI9dfXRf HtWPS8Lwb2uc21E7LWQTkfcfIrVbYP0JY7udaV0jjA== X-Google-Smtp-Source: AGHT+IG+pL46E9DUmZpl2CQ5hyScgiqtPg+G22bJ6Ai45ojo5pzVUl6T/qYRUxx96NB3rXd4QC+V6JiAdyPnrwc6MOA= X-Received: by 2002:a17:90b:14e:b0:270:1586:b014 with SMTP id em14-20020a17090b014e00b002701586b014mr4468685pjb.28.1694217734219; Fri, 08 Sep 2023 17:02:14 -0700 (PDT) MIME-Version: 1.0 References: <20230315110033.30143-1-liudongdong3@huawei.com> <1939253.PYKUYFuaPT@thomas> <9abeba8a-4596-6e69-ded1-59d7a518b3d7@huawei.com> <2922097.o0KrE1Onz3@thomas> <6f9d565d-b9b7-030b-8daf-ffcd4faa39f1@huawei.com> In-Reply-To: <6f9d565d-b9b7-030b-8daf-ffcd4faa39f1@huawei.com> From: Ajit Khaparde Date: Fri, 8 Sep 2023 17:01:57 -0700 Message-ID: Subject: Re: [PATCH v2 1/5] ethdev: support setting and querying RSS algorithm To: Jie Hai Cc: Thomas Monjalon , dev@dpdk.org, Ferruh Yigit , Andrew Rybchenko , liudongdong3@huawei.com, orika@nvidia.com, jerinj@marvell.com Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003d18a00604e1cec5" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000003d18a00604e1cec5 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Fri, Sep 8, 2023 at 1:44=E2=80=AFAM Jie Hai wrote: > > Hi, Thomas > Thanks for your review. > > On 2023/9/4 15:45, Thomas Monjalon wrote: > > 04/09/2023 09:10, Jie Hai: > >> On 2023/8/30 19:46, Thomas Monjalon wrote: > >>> 26/08/2023 09:46, Jie Hai: > > >> + * The *func* field of the *rss_conf* structure indicates the has= h algorithm > >>>> + * applied by the RSS hashing. Passing RTE_ETH_HASH_FUNCTION_DEFAUL= T allows > >>>> + * the PMD to use its best-effort algorithm rather than a specific = one. > >>>> */ > >>> > >>> I don't like commenting a field on top of the structure. > >>> By the way, the first sentence does not look helpful. > >>> RTE_ETH_HASH_FUNCTION_DEFAULT may be explained in the enum. > >>> > >> Other fields above the structure 'rte_eth_rss_conf' have comments. > >> If the new fields 'func' do not have comments, it may be misleading. > >> Unless all the comments above are removed. I'm not sure whether to > >> delete them or not. > > > > You should explain RTE_ETH_HASH_FUNCTION_DEFAULT in its enum. > > The rest of the explanation can be on the struct field. > > I'm OK to have another patch moving old explanations from the struct > > to the fields. > Fixed in V4, please check it. > > > >>>> struct rte_eth_rss_conf { > >>>> uint8_t *rss_key; /**< If not NULL, 40-byte hash key. = */ > >>>> uint8_t rss_key_len; /**< hash key length in bytes. */ > >>>> uint64_t rss_hf; /**< Hash functions to apply - see b= elow. */ > >>>> + enum rte_eth_hash_function func; /**< Hash algorithm to ap= ply. */ > >>> > >>> You can drop "to apply" words. > >> Fixed in V3. > >>> > >>> How the algorithms support combinations in rss_hf? > >>> > >> The rss_hf defines the input of the RSS hash algorithms. > >> For example, rss_hf =3D RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_IPV= 4, > >> these two kinds of packets can be dispatched to different queues > >> according to their tuple field value. > >> For ipv4-tcp packets, src-ip, dst-ip, src-port, dst-port are used as > >> parameters of RSS hash algorithms to compute hash value. > >> For ipv4 packets src-ip, dst-ip are used. > >> > >> If rss_hf =3D RTE_ETH_RSS_NONFRAG_IPV4_TCP | RTE_ETH_RSS_L4_SRC_ONLY, = for > >> ipv4-tcp packets, src-port is used as parameters of RSS hash algorithm= s > >> to compute hash value. > > > > I know what is rss_hf. > > My question is about the algorithms. > > Do they all support any combination in rss_hf? > > > > > I don't know about all vendors' hardware implementations, > so here's just my simple opinion. > > Theoretically, I think that all algorithms should support all > combinations in rss_hf, The reasons are as follows. Leave it to the driver and hardware to decide what combinations can be supported. > > 1. The rss_hf and algorithms are independent. For different algorithms > and the same packets and hash key, the input parameters for different > algorithms should be the same, which depends on implemetation of hardware= . > > 2. As long as hardware and driver support, all packet types defined by > rss_hf could generate the the input parameters for the algorithm to compu= te. > > Thanks, > Jie Hai > > . --0000000000003d18a00604e1cec5 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIP8MhbkxEaS58c/m8CdS /beOhJKOEsgMMSxtrictmIgCMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMDkwOTAwMDIxNFowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQAdYXcLxPRjYIXMX2/52thCuT79jSU6Dl/uwEpm XJnW+Izj8IIQoJeu8Zr/LjuSfQePAZjQ0y2JZhEvGG8cnjEe5b34jshRM5K5vRHeiag/qdc2Jii0 ZpUDz+aS0LbJsYbOjWHK8SZGLbhFgajf1lmShOXA5EdLM6yM9XAo/n26D4GfCBr6HthorGEqYOwp mhhR40uQ2b21m647rrY5fMW/iKZUhChdW4Z0dzgtwDnWc9WjH2m0vwqiM3T8T3NSBWqnRVFNLg7n LZ5kxWTyXcDOrtAasgYSJ4GGNsYH+ALZtw/VMyyuUFKTTNAG6545SjmWoGlQpZrHSi9V2t5afyp9 --0000000000003d18a00604e1cec5--