From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 51423A04DB; Tue, 24 Nov 2020 19:10:20 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B4B8AC926; Tue, 24 Nov 2020 19:10:18 +0100 (CET) Received: from mail-oi1-f194.google.com (mail-oi1-f194.google.com [209.85.167.194]) by dpdk.org (Postfix) with ESMTP id B4133C90E for ; Tue, 24 Nov 2020 19:10:17 +0100 (CET) Received: by mail-oi1-f194.google.com with SMTP id a130so16665316oif.7 for ; Tue, 24 Nov 2020 10:10:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=8m19NDJXM24hFgBhcCkTGSOoiu5ZZT2XDq0c1tFq2Ec=; b=fhkGlHPFvFrAnnCXArLh5U340dnwgEl4kkbPbU1reAjTwcsxB+W5jD+WKSMI3ibUx2 EezV58Kr2GWYolbGfFya9VU1yQQrGf9r359ZlDj92nk/61ioU7zrcfiK3OObetJAnNbW tZ+aUKYF0hoI8PPVzJqE7C+MdNybdahxB/CeA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=8m19NDJXM24hFgBhcCkTGSOoiu5ZZT2XDq0c1tFq2Ec=; b=evNtzuvDzcHh+VPR6L/U01Dwk1oOHTPfREcdvKyT9Brbgar/VPLDT78L59RoQLo4bo yKxdaO00xPkEDDzBvjCLqKBwMLZ8wo1x6/VYVjfcT6rwZadk1GW3KgQc8XA/9UKYfi2K KUoFDzYc5KyJ/BXgc2+nXonnKgdinsk6z6PbgUlswy6UEj6RXA3I9nj37DfHu6S78nk2 VfrGyD6a27OHI1SJToSbKPFguWCIbH1m/PKblvUXEQkTm1GKKo74L3/d8c4IJBP1POOB NPgPAFM693yOyp0Hbsg7dLzBCxszbE31HgE0ky6kahs7iUGfZH4oYp2uunPZOuxwZkRe 3qDQ== X-Gm-Message-State: AOAM531266J4Ek0Nn2WLijgTQcYTZ77LaO4LmqXQ9SGa07Q0hJez616d 3wGxy5NcriEt5FFa4wgNZ5qWBt9GTbkH96kWzvu2eQ== X-Google-Smtp-Source: ABdhPJy5eot++e+pryETwJybllRvTA1gAFhfxIvRMd2XZLL+rwJg+J0fq2N5fcorHLWhtTzXJN2T4OVvP+lIyW24iPA= X-Received: by 2002:aca:5a41:: with SMTP id o62mr3600276oib.179.1606241415813; Tue, 24 Nov 2020 10:10:15 -0800 (PST) MIME-Version: 1.0 References: <1603961577-13264-1-git-send-email-arybchenko@solarflare.com> <362bab6b-1dcc-2254-20a0-4ee62b0cd69b@oktetlabs.ru> In-Reply-To: From: Ajit Khaparde Date: Tue, 24 Nov 2020 10:09:59 -0800 Message-ID: To: Ferruh Yigit Cc: Andrew Rybchenko , "Xueming(Steven) Li" , Andrew Rybchenko , "dev@dpdk.org" , declan.doherty@intel.com, Andrey Vesnovaty , NBU-Contact-Thomas Monjalon , Ray Kinsella , Neil Horman , Ori Kam , "Wei Hu (Xavier)" , "Min Hu (Connor)" , Yisen Zhuang , Lijun Ou , Matan Azrad , Shahaf Shuler , Viacheslav Ovsiienko , Jasvinder Singh , Cristian Dumitrescu , Somnath Kotur , Qiming Yang , Qi Zhang Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action attribute X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Nov 2, 2020 at 8:01 AM Ferruh Yigit wrote: > > On 11/1/2020 10:45 AM, Andrew Rybchenko wrote: > > On 10/30/20 7:12 PM, Xueming(Steven) Li wrote: > >> Hi Andrew, > >> > >>> -----Original Message----- > >>> From: dev On Behalf Of Andrew Rybchenko > >>> Sent: Thursday, October 29, 2020 4:53 PM > >>> To: dev@dpdk.org > >>> Cc: Andrey Vesnovaty ; NBU-Contact-Thomas > >>> Monjalon ; Ferruh Yigit ; > >>> Ray Kinsella ; Neil Horman ; > >>> Ori Kam ; Andrew Rybchenko > >>> > >>> Subject: [dpdk-dev] [PATCH] ethdev: deprecate shared counters using action > >>> attribute > >>> > >>> A new generic shared actions API may be used to create shared counter. > >>> There is no point to keep duplicate COUNT action specific capability to create > >>> shared counters. > >>> > >>> Signed-off-by: Andrew Rybchenko > >>> --- > >>> In fact, it looks like the next logical step is to remove struct > >>> rte_flow_action_count completely since counter ID makes sense for shared > >>> counters only. I think it will just make it easiser to use COUNT action. > >>> Comments are welcome. > >>> > >>> doc/guides/rel_notes/deprecation.rst | 4 ++++ > >>> lib/librte_ethdev/rte_flow.h | 6 +++++- > >>> 2 files changed, 9 insertions(+), 1 deletion(-) > >>> > >>> diff --git a/doc/guides/rel_notes/deprecation.rst > >>> b/doc/guides/rel_notes/deprecation.rst > >>> index 2e082499b8..4f3bac1a6d 100644 > >>> --- a/doc/guides/rel_notes/deprecation.rst > >>> +++ b/doc/guides/rel_notes/deprecation.rst > >>> @@ -138,6 +138,10 @@ Deprecation Notices > >>> will be limited to maximum 256 queues. > >>> Also compile time flag ``RTE_ETHDEV_QUEUE_STAT_CNTRS`` will be > >>> removed. > >>> > >>> +* ethdev: Attribute ``shared`` of the ``struct rte_flow_action_count`` > >>> + is deprecated and will be removed in DPDK 21.11. Shared counters > >>> +should > >>> + be managed using shared actions API (``rte_flow_shared_action_create`` > >>> etc). > >>> + > >>> * cryptodev: support for using IV with all sizes is added, J0 still can > >>> be used but only when IV length in following structs > >>> ``rte_crypto_auth_xform``, > >>> ``rte_crypto_aead_xform`` is set to zero. When IV length is greater or equal > >>> diff --git a/lib/librte_ethdev/rte_flow.h b/lib/librte_ethdev/rte_flow.h index > >>> a8eac4deb8..2bb93d237a 100644 > >>> --- a/lib/librte_ethdev/rte_flow.h > >>> +++ b/lib/librte_ethdev/rte_flow.h > >>> @@ -2287,6 +2287,9 @@ struct rte_flow_query_age { > >>> * Counters can be retrieved and reset through ``rte_flow_query()``, see > >>> * ``struct rte_flow_query_count``. > >>> * > >>> + * @deprecated Shared attribute is deprecated, use generic > >>> + * RTE_FLOW_ACTION_TYPE_SHARED action. > >>> + * > >>> * The shared flag indicates whether the counter is unique to the flow rule > >>> the > >>> * action is specified with, or whether it is a shared counter. > >>> * > >>> @@ -2299,7 +2302,8 @@ struct rte_flow_query_age { > >>> * to all ports within that switch domain. > >>> */ > >>> struct rte_flow_action_count { > >>> - uint32_t shared:1; /**< Share counter ID with other flow rules. */ > >>> + /** @deprecated Share counter ID with other flow rules. */ > >>> + uint32_t shared:1; > >>> uint32_t reserved:31; /**< Reserved, must be zero. */ > >>> uint32_t id; /**< Counter ID. */ > >> Do you think id could be removed as well? neither non-shared flow counter query, > >> nor shared action query. > > > > I'm not 100% sure, but yes, as I write above just after my Signed-off-by. > > > > cc'ed Declan + maintainers of PMDs for the 'id' field, but as far as I can see > it is used out of the 'shared' context, so I am for going on with existing patch > for now. > > Reviewed-by: Ferruh Yigit Acked-by: Ajit Khaparde