Re: [dpdk-dev] [PATCH] net/bnxt: fix build with gcc10 default fno-common

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

On Tue, May 5, 2020 at 7:56 AM Kevin Traynor <ktraynor@redhat.com> wrote:

> On 05/05/2020 05:03, Ajit Khaparde wrote:
> > From: Randy Schacher <stuart.schacher@broadcom.com>
> >
> > Remove the defensive compile-time checker macro.
> >
>
> Thanks Ajit/Randy. This removes the error for bnxt on my Fedora 32 system.
>
> Was chatting to David and he suggest if 'static __rte_used' could be
> added to the macro as an alternative.
>
> Checked and it [1] is working also. It seems like a cleaner fix for the
> specific issue to me. If you have an additional reason to remove the
> compile checks, it could be a separate patch or a comment added to the
> commit message.
>
> [1]
> --- a/drivers/net/bnxt/tf_core/hwrm_tf.h
> +++ b/drivers/net/bnxt/tf_core/hwrm_tf.h
> @@ -40,5 +40,5 @@ typedef enum tf_subtype {
>
>  #define __BUILD_BUG_ON(condition, line) \
> -       char p##line[(condition) ? 1 : -1]
> +       static __rte_unused char p##line[(condition) ? 1 : -1]
>
> > Bugzilla ID: 468
> > Fixes: 8430a8b841c8 ("net/bnxt: add initial TruFlow core session open")
> > Signed-off-by: Randy Schacher <stuart.schacher@broadcom.com>
> > Reviewed-by: Peter Spreadborough <peter.spreadborough@broadcom.com>
> > Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks

>
>