From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 848E5A0524; Fri, 19 Mar 2021 17:53:28 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6BF17140FF7; Fri, 19 Mar 2021 17:53:28 +0100 (CET) Received: from mail-qt1-f175.google.com (mail-qt1-f175.google.com [209.85.160.175]) by mails.dpdk.org (Postfix) with ESMTP id 1782E40143 for ; Fri, 19 Mar 2021 17:53:27 +0100 (CET) Received: by mail-qt1-f175.google.com with SMTP id x9so7225703qto.8 for ; Fri, 19 Mar 2021 09:53:27 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=aDATlejcJ2372U+CfhH1T+K5ABJ3jkmpYYDQHRMSiY8=; b=DQlsY5Bf3u7+7qayxhatnfkYEENaTArIQpJFntHFc0SNNRSXEir/5HtkQickEHfWqS Bco8QvYBNenjrfhHQ0cKtzbzSGRmUvOD3VCwDUSHulrEnBCd970j18Vf+1pgj1T/YcNf 2DLDPawqgVwRXahqgCVPhaF1ymgWpkoohd5XU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=aDATlejcJ2372U+CfhH1T+K5ABJ3jkmpYYDQHRMSiY8=; b=F7X/3oPIecvpssp3FlqgxjTNFJQmaRpTVOKSI86BSuubSUj30oT5C43Uo92K97DfY7 PggRNyQCj7itbXo9T073RLa/slDiABGg++IOk2vmz7Jm8iitvIuviwO95qvUW9LCQDND URduQho4X0OjBvMiBWaIewTKK2gzBURsv5sfYONHMIACtToLXoB6J6/BB76+DvLONzxd EuZSnu3r0phMrYllhhhLSwvFTadUZze300uGZwZGiDRO/pWTvkjjSUQ+9hxojh7dxcvP xBChhi554tpLCZjNdI/hqDpr1Qwv+J8Vdi3BvWb/C8k94H+GORWzxGS+8CHyYj3ROU/q Lo9Q== X-Gm-Message-State: AOAM533UJEKIbwXfIpZDZCgHxkeUqbDEIjCFE6nDX9eK2bicCAh4De2p mc3c34t+dTmkvc3PCHl+G6a5ezJiZaD+Qk8R/VEK0Kwkb8CBqGd2 X-Google-Smtp-Source: ABdhPJyjZVm14yRAuV4dCdez0bHHO+900dwf9gv9MmLURxsHfBqwMYdmOz3S2ufLcz2bOHPg6eFruAEC3bKcdBsBm/c= X-Received: by 2002:ac8:5e07:: with SMTP id h7mr9140933qtx.225.1616172806316; Fri, 19 Mar 2021 09:53:26 -0700 (PDT) MIME-Version: 1.0 References: <20210310140107.2730088-1-thomas@monjalon.net> <20210310140107.2730088-4-thomas@monjalon.net> In-Reply-To: <20210310140107.2730088-4-thomas@monjalon.net> From: Ajit Khaparde Date: Fri, 19 Mar 2021 09:53:09 -0700 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , John Griffin , Fiona Trahe , Deepak Kumar Jain , Raveendra Padasalagi , Vikas Gupta , Rosen Xu , Tianfei zhang , Bruce Richardson , Nipun Gupta , Hemant Agrawal , Xiao Wang Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000000a6e2c05bde68e22" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 3/3] drivers: align log names X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000000a6e2c05bde68e22 Content-Type: text/plain; charset="UTF-8" On Wed, Mar 10, 2021 at 6:01 AM Thomas Monjalon wrote: > > The log levels are configured by using the name of the logs. > Some drivers are aligned to follow a common log name standard: > pmd.class.driver[.sub] > Some "common" drivers skip the "class" part: > pmd.driver.sub > > Signed-off-by: Thomas Monjalon > --- > doc/guides/cryptodevs/qat.rst | 10 +++++----- > drivers/common/qat/qat_logs.c | 4 ++-- > drivers/crypto/bcmfs/bcmfs_logs.c | 4 ++-- For bcmfs, Acked-by: Ajit Khaparde > drivers/raw/ifpga/ifpga_rawdev.c | 2 +- > drivers/raw/ioat/ioat_rawdev.c | 2 +- > drivers/raw/skeleton/skeleton_rawdev.c | 2 +- > drivers/vdpa/ifc/ifcvf_vdpa.c | 2 +- > 7 files changed, 13 insertions(+), 13 deletions(-) > > diff --git a/doc/guides/cryptodevs/qat.rst b/doc/guides/cryptodevs/qat.rst > index cf16f03503..224b22b3f7 100644 > --- a/doc/guides/cryptodevs/qat.rst > +++ b/doc/guides/cryptodevs/qat.rst > @@ -659,15 +659,15 @@ Debugging > > There are 2 sets of trace available via the dynamic logging feature: > > -* pmd.qat_dp exposes trace on the data-path. > -* pmd.qat_general exposes all other trace. > +* pmd.qat.dp exposes trace on the data-path. > +* pmd.qat.general exposes all other trace. > > pmd.qat exposes both sets of traces. > They can be enabled using the log-level option (where 8=maximum log level) on > the process cmdline, e.g. using any of the following:: > > - --log-level="pmd.qat_general,8" > - --log-level="pmd.qat_dp,8" > + --log-level="pmd.qat.general,8" > + --log-level="pmd.qat.dp,8" > --log-level="pmd.qat,8" > > .. Note:: > @@ -678,4 +678,4 @@ the process cmdline, e.g. using any of the following:: > Also the dynamic global log level overrides both sets of trace, so e.g. no > QAT trace would display in this case:: > > - --log-level="7" --log-level="pmd.qat_general,8" > + --log-level="7" --log-level="pmd.qat.general,8" > diff --git a/drivers/common/qat/qat_logs.c b/drivers/common/qat/qat_logs.c > index fa48be53c3..adbe163cd9 100644 > --- a/drivers/common/qat/qat_logs.c > +++ b/drivers/common/qat/qat_logs.c > @@ -17,5 +17,5 @@ qat_hexdump_log(uint32_t level, uint32_t logtype, const char *title, > return 0; > } > > -RTE_LOG_REGISTER(qat_gen_logtype, pmd.qat_general, NOTICE); > -RTE_LOG_REGISTER(qat_dp_logtype, pmd.qat_dp, NOTICE); > +RTE_LOG_REGISTER(qat_gen_logtype, pmd.qat.general, NOTICE); > +RTE_LOG_REGISTER(qat_dp_logtype, pmd.qat.dp, NOTICE); > diff --git a/drivers/crypto/bcmfs/bcmfs_logs.c b/drivers/crypto/bcmfs/bcmfs_logs.c > index 701da9ecf3..9faf12f238 100644 > --- a/drivers/crypto/bcmfs/bcmfs_logs.c > +++ b/drivers/crypto/bcmfs/bcmfs_logs.c > @@ -21,5 +21,5 @@ bcmfs_hexdump_log(uint32_t level, uint32_t logtype, const char *title, > return 0; > } > > -RTE_LOG_REGISTER(bcmfs_conf_logtype, pmd.bcmfs_config, NOTICE) > -RTE_LOG_REGISTER(bcmfs_dp_logtype, pmd.bcmfs_fp, NOTICE) > +RTE_LOG_REGISTER(bcmfs_conf_logtype, pmd.crypto.bcmfs.config, NOTICE) > +RTE_LOG_REGISTER(bcmfs_dp_logtype, pmd.crypto.bcmfs.fp, NOTICE) > diff --git a/drivers/raw/ifpga/ifpga_rawdev.c b/drivers/raw/ifpga/ifpga_rawdev.c > index 27129b133e..56b1866f77 100644 > --- a/drivers/raw/ifpga/ifpga_rawdev.c > +++ b/drivers/raw/ifpga/ifpga_rawdev.c > @@ -1611,7 +1611,7 @@ static struct rte_pci_driver rte_ifpga_rawdev_pmd = { > RTE_PMD_REGISTER_PCI(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd); > RTE_PMD_REGISTER_PCI_TABLE(ifpga_rawdev_pci_driver, rte_ifpga_rawdev_pmd); > RTE_PMD_REGISTER_KMOD_DEP(ifpga_rawdev_pci_driver, "* igb_uio | uio_pci_generic | vfio-pci"); > -RTE_LOG_REGISTER(ifpga_rawdev_logtype, driver.raw.init, NOTICE); > +RTE_LOG_REGISTER(ifpga_rawdev_logtype, pmd.raw.ifpga, NOTICE); > > static const char * const valid_args[] = { > #define IFPGA_ARG_NAME "ifpga" > diff --git a/drivers/raw/ioat/ioat_rawdev.c b/drivers/raw/ioat/ioat_rawdev.c > index a95854d5ac..15af07017c 100644 > --- a/drivers/raw/ioat/ioat_rawdev.c > +++ b/drivers/raw/ioat/ioat_rawdev.c > @@ -28,7 +28,7 @@ static struct rte_pci_driver ioat_pmd_drv; > #define IOAT_DEVICE_ID_BDXF 0x6f2F > #define IOAT_DEVICE_ID_ICX 0x0b00 > > -RTE_LOG_REGISTER(ioat_pmd_logtype, rawdev.ioat, INFO); > +RTE_LOG_REGISTER(ioat_pmd_logtype, pmd.raw.ioat, INFO); > > #define DESC_SZ sizeof(struct rte_ioat_generic_hw_desc) > #define COMPLETION_SZ sizeof(__m128i) > diff --git a/drivers/raw/skeleton/skeleton_rawdev.c b/drivers/raw/skeleton/skeleton_rawdev.c > index aa3beaad18..8896f0c9c5 100644 > --- a/drivers/raw/skeleton/skeleton_rawdev.c > +++ b/drivers/raw/skeleton/skeleton_rawdev.c > @@ -768,4 +768,4 @@ static struct rte_vdev_driver skeleton_pmd_drv = { > }; > > RTE_PMD_REGISTER_VDEV(SKELETON_PMD_RAWDEV_NAME, skeleton_pmd_drv); > -RTE_LOG_REGISTER(skeleton_pmd_logtype, rawdev.skeleton, INFO); > +RTE_LOG_REGISTER(skeleton_pmd_logtype, pmd.raw.skeleton, INFO); > diff --git a/drivers/vdpa/ifc/ifcvf_vdpa.c b/drivers/vdpa/ifc/ifcvf_vdpa.c > index 6a1b44bc77..bf7afe4610 100644 > --- a/drivers/vdpa/ifc/ifcvf_vdpa.c > +++ b/drivers/vdpa/ifc/ifcvf_vdpa.c > @@ -25,7 +25,7 @@ > > #include "base/ifcvf.h" > > -RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.net.ifcvf_vdpa, NOTICE); > +RTE_LOG_REGISTER(ifcvf_vdpa_logtype, pmd.vdpa.ifcvf, NOTICE); > #define DRV_LOG(level, fmt, args...) \ > rte_log(RTE_LOG_ ## level, ifcvf_vdpa_logtype, \ > "IFCVF %s(): " fmt "\n", __func__, ##args) > -- > 2.30.1 > --0000000000000a6e2c05bde68e22--