From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id A114CA0A0C; Mon, 2 Aug 2021 23:21:06 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5FC874117A; Mon, 2 Aug 2021 23:21:06 +0200 (CEST) Received: from mail-qv1-f45.google.com (mail-qv1-f45.google.com [209.85.219.45]) by mails.dpdk.org (Postfix) with ESMTP id 8699141147 for ; Mon, 2 Aug 2021 23:21:05 +0200 (CEST) Received: by mail-qv1-f45.google.com with SMTP id js7so7035950qvb.4 for ; Mon, 02 Aug 2021 14:21:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=gcrkktG5hIk7XB/qv+xPz2siy88boqeKFE7dJCe5mis=; b=Op3uwERa8APlS2Mkm0oNP5cAd+Wpk1ewwJBVnTFFJQrU00Nak7xLo+70NCy00H6Sgk oY2c3gE1jMuaYh6s4ijRYuoPhwHwmBUyiwm1SwGNTDlLYibgHSTQCpEDxagTK09b9zF1 UZRq1IivWrduJEfntGYoNGUg6gGqHhl04AGts= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=gcrkktG5hIk7XB/qv+xPz2siy88boqeKFE7dJCe5mis=; b=h8TXxFON41UX+9Wv+hYpU7QNz1C+zjYBYIWrUE+tqSDwsy/V8gmu9szNCe0DkgQEpi iqzMHgsE77fk7buponQujuk29/tdqPADsnByno3W2iWQPhl+T0At38laWJxu6LH3yzVK lOSSL5x2HPA1cQeHhGJmomvaSxDCRhU9LT3H2HtZ1jZ14LpwvHlStSL3h2wu6jISbBRF aJJIDWuUTLj5Ig70R8HgEVs4wKNzZxNTItHiyoZ/NTIATedCDdhUtquuxEUrJgVh1BQq 87eQsMN4mBR/GsxdBG6+VrD19nUFh+/gsQRFqplPPt903hRJesU4f1qm9u72RMa5A1rg 4jjg== X-Gm-Message-State: AOAM530DF+WRL+noOlshsTW8n5brsXXnhFiorC9+PzqXmEiaWZ2SKpw8 FTKOIyWzrIdzT3inrEmyx53Us4Mdo+5b5+jXOt+WRw== X-Google-Smtp-Source: ABdhPJwABZdbfSflZaAhzJxPdLTRNBFWPKYVQyPyeglrcd9Yp3uF8VRqFaDQGvfUvPoZ0lL5jlOO5mAA1DNVPOG0pwU= X-Received: by 2002:a05:6214:948:: with SMTP id dn8mr18416074qvb.30.1627939264914; Mon, 02 Aug 2021 14:21:04 -0700 (PDT) MIME-Version: 1.0 References: <20210801102214.1566104-1-andrew.rybchenko@oktetlabs.ru> <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> In-Reply-To: <20210802195723.2153114-1-andrew.rybchenko@oktetlabs.ru> From: Ajit Khaparde Date: Mon, 2 Aug 2021 14:20:48 -0700 Message-ID: To: Andrew Rybchenko Cc: Thomas Monjalon , Ferruh Yigit , Ori Kam , dpdk-dev , Eli Britstein , Ilya Maximets , Matan Azrad , Ivan Malov , Viacheslav Galaktionov Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000009e060405c89a2527" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v3 1/2] ethdev: announce flow API action PORT_ID changes X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000009e060405c89a2527 Content-Type: text/plain; charset="UTF-8" On Mon, Aug 2, 2021 at 12:57 PM Andrew Rybchenko wrote: > > By its very name, action PORT_ID means that packets hit an ethdev with the > given DPDK port ID. At least the current comments don't state the opposite. > > However some drivers implement it in a different way and direct traffic to > the opposite end of the "wire" plugged to the given ethdev. For example in > the case of a VF representor traffic is redirected to the corresponding VF > itself rather than to the representor ethdev and OvS uses PORT_ID action > this way. > > The documentation must be clarified and, likely, rte_flow_action_port_id > structure should be extended to support both meanings. > > Signed-off-by: Andrew Rybchenko > Acked-by: Ori Kam > --- > doc/guides/rel_notes/deprecation.rst | 5 +++++ > 1 file changed, 5 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index d9c0e65921..6e6413c89f 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -158,3 +158,8 @@ Deprecation Notices > * security: The functions ``rte_security_set_pkt_metadata`` and > ``rte_security_get_userdata`` will be made inline functions and additional > flags will be added in structure ``rte_security_ctx`` in DPDK 21.11. > + > +* ethdev: Definition of the flow API action PORT_ID is ambiguous and needs > + clarification. Structure rte_flow_action_port_id will be extended to > + specify traffic direction to represented entity or ethdev port itself in Nit! "to the represented entity"? Otherwise Acked-by: Ajit Khaparde > + DPDK 21.11. > -- > 2.30.2 > --0000000000009e060405c89a2527--