DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Somnath Kotur <somnath.kotur@broadcom.com>
Cc: dpdk-dev <dev@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: fix to remove spurious warning in Rx handler
Date: Thu, 30 Jan 2020 22:25:31 -0800	[thread overview]
Message-ID: <CACZ4nht9u6rECYQNWKnrR68ryHqA28wSB7xrjCSEycayXS4XtQ@mail.gmail.com> (raw)
In-Reply-To: <20200131061658.17364-1-somnath.kotur@broadcom.com>

On Thu, Jan 30, 2020 at 10:18 PM Somnath Kotur <somnath.kotur@broadcom.com>
wrote:

> HW seems to populate the cfa code in the Rx descriptor even
> if an explicit flow rule is not configured via application as
> there might be a default rule configured in HW even for promisc
> mode.
>
> Fixes: 94eb699bc82e ("net/bnxt: support flow mark action")
>
> Reviewed-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Signed-off-by: Somnath Kotur <somnath.kotur@broadcom.com>
>
Patch applied to dpdk-next-net-brcm. Thanks

---
> v1->v2: Used the correct commit id for the fixes tag
>  drivers/net/bnxt/bnxt_rxr.c | 5 +----
>  1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c
> index 1960b05..1f47db9 100644
> --- a/drivers/net/bnxt/bnxt_rxr.c
> +++ b/drivers/net/bnxt/bnxt_rxr.c
> @@ -909,11 +909,8 @@ void bnxt_set_mark_in_mbuf(struct bnxt *bp,
>         if (!cfa_code)
>                 return;
>
> -       if (cfa_code && !bp->mark_table[cfa_code].valid) {
> -               PMD_DRV_LOG(WARNING, "Invalid mark_tbl entry! cfa_code:
> 0x%x\n",
> -                           cfa_code);
> +       if (cfa_code && !bp->mark_table[cfa_code].valid)
>                 return;
> -       }
>
>         flags2 = rte_le_to_cpu_16(rxcmp1->flags2);
>         meta = rte_le_to_cpu_32(rxcmp1->metadata);
> --
> 1.8.3.1
>
>

      reply	other threads:[~2020-01-31  6:25 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-31  6:16 Somnath Kotur
2020-01-31  6:25 ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CACZ4nht9u6rECYQNWKnrR68ryHqA28wSB7xrjCSEycayXS4XtQ@mail.gmail.com \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=somnath.kotur@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).