Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management

[Ajit Khaparde <ajit.khaparde@broadcom.com>]

On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit <ferruh.yigit@intel.com>
wrote:

> On 4/15/2020 9:18 AM, Venkat Duvvuru wrote:
> > This patchset introduces a new mechanism to allow host-memory based
> > flow table management. This should allow higher flow scalability
> > than what is currently supported. This new approach also defines a
> > new rte_flow parser, and mapper which currently supports basic packet
> > classification in receive path. The patchset uses a newly implemented
> > control-plane firmware interface which optimizes flow insertions and
> > deletions.
> >
> > This is a baseline patchset with limited scale. Follow on patches will
> > add support for more protocol headers, rte_flow attributes, actions
> > and such.
> >
> > This is a tech preview feature, hence disabled by default and can be
> enabled
> > using bnxt devargs. For ex: "-w 0000:0d:00.0,host-based-truflow=1”.
> >
> > v3==>v4
> > =======
> > 1. Fixed some more compilation issues reported by CI
> >
> > Ajit Kumar Khaparde (1):
> >   net/bnxt: add updated dpdk hsi structure
> >
> > Farah Smith (2):
> >   net/bnxt: add tf core identifier support
> >   net/bnxt: add tf core table scope support
> >
> > Kishore Padmanabha (8):
> >   net/bnxt: match rte flow items with flow template patterns
> >   net/bnxt: match rte flow actions with flow template actions
> >   net/bnxt: add support for rte flow item parsing
> >   net/bnxt: add support for rte flow action parsing
> >   net/bnxt: add support for rte flow create driver hook
> >   net/bnxt: add support for rte flow validate driver hook
> >   net/bnxt: add support for rte flow destroy driver hook
> >   net/bnxt: add support for rte flow flush driver hook
> >
> > Michael Wildt (4):
> >   net/bnxt: add initial tf core session open
> >   net/bnxt: add initial tf core session close support
> >   net/bnxt: add tf core session sram functions
> >   net/bnxt: add resource manager functionality
> >
> > Mike Baucom (5):
> >   net/bnxt: add helper functions for blob/regfile ops
> >   net/bnxt: add support to process action tables
> >   net/bnxt: add support to process key tables
> >   net/bnxt: add support to free key and action tables
> >   net/bnxt: add support to alloc and program key and act tbls
> >
> > Pete Spreadborough (2):
> >   net/bnxt: add truflow message handlers
> >   net/bnxt: add EM/EEM functionality
> >
> > Randy Schacher (1):
> >   net/bnxt: update hwrm prep to use ptr
> >
> > Shahaji Bhosle (2):
> >   net/bnxt: add initial tf core resource mgmt support
> >   net/bnxt: add tf core TCAM support
> >
> > Venkat Duvvuru (9):
> >   net/bnxt: fetch SVIF information from the firmware
> >   net/bnxt: fetch vnic info from DPDK port
> >   net/bnxt: add devargs parameter for host memory based TRUFLOW feature
> >   net/bnxt: add support for ULP session manager init
> >   net/bnxt: add support for ULP session manager cleanup
> >   net/bnxt: register tf rte flow ops
> >   net/bnxt: disable vector mode when host based TRUFLOW is enabled
> >   net/bnxt: add support for injecting mark into packet’s mbuf
> >   net/bnxt: enable meson build on truflow code
> >
>
> Hi Ajit,
>
> If there will be a new version, I suggest following commit titles, if they
> make
> sense can you update accordingly?
>
>  net/bnxt: update HSI structure
>  net/bnxt: update HWRM prep to use pointer
>  net/bnxt: add TruFlow message handlers
>  net/bnxt: add initial TruFlow core session open
>  net/bnxt: add initial TruFlow core session close
>  net/bnxt: add TruFlow core session SRAM
>  net/bnxt: add initial TruFlow core resource management
>  net/bnxt: add resource manager
>  net/bnxt: add TruFlow core identifier
>  net/bnxt: support TruFlow core TCAM
>  net/bnxt: support TruFlow core table scope
>  net/bnxt: support EM/EEM
>  net/bnxt: fetch SVIF information from firmware
>  net/bnxt: fetch VNIC info
>  net/bnxt: support host memory based TruFlow
>  net/bnxt: support ULP session manager init
>  net/bnxt: support ULP session manager cleanup
>  net/bnxt: add helper functions for blob/regfile ops
>  net/bnxt: support process action tables
>  net/bnxt: support process key tables
>  net/bnxt: support freeing key and action tables
>  net/bnxt: support alloc and program key and act tables
>  net/bnxt: match flow API items with flow template patterns
>  net/bnxt: match flow API actions with flow template actions
>  net/bnxt: support flow API item parsing
>  net/bnxt: support flow API action parsing
>  net/bnxt: support flow API create
>  net/bnxt: support flow API validate
>  net/bnxt: support flow API destroy
>  net/bnxt: support flow API flush
>  net/bnxt: register TruFlow flow API ops
>  net/bnxt: disable vector mode on host based TruFlow
>  net/bnxt: support marking packet
>  net/bnxt: enable meson build on TruFlow
>
Ferruh,
These look ok to me.
Do you want me to respin the set or can you handle it this time?
I am fine with both.

Thanks
Ajit