From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3F401A0588; Thu, 16 Apr 2020 19:51:20 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 155E61DDEE; Thu, 16 Apr 2020 19:51:19 +0200 (CEST) Received: from mail-oi1-f193.google.com (mail-oi1-f193.google.com [209.85.167.193]) by dpdk.org (Postfix) with ESMTP id CEB701DDE2 for ; Thu, 16 Apr 2020 19:51:17 +0200 (CEST) Received: by mail-oi1-f193.google.com with SMTP id k133so16573069oih.12 for ; Thu, 16 Apr 2020 10:51:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=fjiDrzp5hcPHwE7iVXG95xYdkx+pT8jLn4D9n6EPRxk=; b=UBuGcoI9hA7K4adTxqaXT2yqLkFwAZeIeJIvriv6jmnUXZQjLk5q4yFEEBCVfMtev2 hNK+XCkY64IWB8FZVO03rjRiftZXcT0XBuu/d3XnHlI/hp1d2lRR0X9KhY1DuumIeJh+ Z2HoTHr+FVa5II3wILhvVqznsXPZIcLEKoaFE= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=fjiDrzp5hcPHwE7iVXG95xYdkx+pT8jLn4D9n6EPRxk=; b=CvC9sXIIIs+G1qfxDZvFvzY5H0d0Khw+WqQwm9pa6zJeqO0189WzdZJ+49zFst2XvQ BGHZjq5VwByd7LsikEGOfuywLt9ghRWt8aGkMfcTqeaKU/BCscMRChq7nMqif9LU3XPK W2M7LjEf0xFQLIVtkNdwvOnKqQ2bMXdF+AhEBpYPRT9X06Hw64tbNd+ReFIP6224b4+f lN+dbMN/grNhaGipS0B5CGrSgL+m4umCeJt63YYfgw9gtk3/9yFOObQCsDo2u8ssl/Wk 2vC4AjT8AKfiCSKmR7xyqnmJ2F4XDbUL3UIPOtRpOx9D9hpGoYHYfEgQz+LCrlOJrNQ+ He4A== X-Gm-Message-State: AGi0Puav8oBz+hpvru9jDYBwGBkl7v5wxXaZIe+QDb4MqSwvdDFV0QEK 8lgYYjs9gl2pd0E3XgrzpsW9WImfTr8qAYw/lzLjwARD X-Google-Smtp-Source: APiQypIoAI5bN5ny2Vl8kQ5cdybCWWQk41o0k8c5UOCIvoI+wfZzxxxdtzcg940GM4UNBkppAvlCGZijri4LsmTIhAU= X-Received: by 2002:aca:5583:: with SMTP id j125mr67380oib.179.1587059476970; Thu, 16 Apr 2020 10:51:16 -0700 (PDT) MIME-Version: 1.0 References: <1586852011-37536-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <1586938751-32808-1-git-send-email-venkatkumar.duvvuru@broadcom.com> <8320ae09-1b90-63c6-e61e-5891d54daef0@intel.com> In-Reply-To: <8320ae09-1b90-63c6-e61e-5891d54daef0@intel.com> From: Ajit Khaparde Date: Thu, 16 Apr 2020 10:51:00 -0700 Message-ID: To: Ferruh Yigit Cc: Venkat Duvvuru , dpdk-dev Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v4 00/34] add support for host based flow table management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Apr 16, 2020 at 10:40 AM Ferruh Yigit wrote: > On 4/15/2020 9:18 AM, Venkat Duvvuru wrote: > > This patchset introduces a new mechanism to allow host-memory based > > flow table management. This should allow higher flow scalability > > than what is currently supported. This new approach also defines a > > new rte_flow parser, and mapper which currently supports basic packet > > classification in receive path. The patchset uses a newly implemented > > control-plane firmware interface which optimizes flow insertions and > > deletions. > > > > This is a baseline patchset with limited scale. Follow on patches will > > add support for more protocol headers, rte_flow attributes, actions > > and such. > > > > This is a tech preview feature, hence disabled by default and can be > enabled > > using bnxt devargs. For ex: "-w 0000:0d:00.0,host-based-truflow=3D1=E2= =80=9D. > > > > v3=3D=3D>v4 > > =3D=3D=3D=3D=3D=3D=3D > > 1. Fixed some more compilation issues reported by CI > > > > Ajit Kumar Khaparde (1): > > net/bnxt: add updated dpdk hsi structure > > > > Farah Smith (2): > > net/bnxt: add tf core identifier support > > net/bnxt: add tf core table scope support > > > > Kishore Padmanabha (8): > > net/bnxt: match rte flow items with flow template patterns > > net/bnxt: match rte flow actions with flow template actions > > net/bnxt: add support for rte flow item parsing > > net/bnxt: add support for rte flow action parsing > > net/bnxt: add support for rte flow create driver hook > > net/bnxt: add support for rte flow validate driver hook > > net/bnxt: add support for rte flow destroy driver hook > > net/bnxt: add support for rte flow flush driver hook > > > > Michael Wildt (4): > > net/bnxt: add initial tf core session open > > net/bnxt: add initial tf core session close support > > net/bnxt: add tf core session sram functions > > net/bnxt: add resource manager functionality > > > > Mike Baucom (5): > > net/bnxt: add helper functions for blob/regfile ops > > net/bnxt: add support to process action tables > > net/bnxt: add support to process key tables > > net/bnxt: add support to free key and action tables > > net/bnxt: add support to alloc and program key and act tbls > > > > Pete Spreadborough (2): > > net/bnxt: add truflow message handlers > > net/bnxt: add EM/EEM functionality > > > > Randy Schacher (1): > > net/bnxt: update hwrm prep to use ptr > > > > Shahaji Bhosle (2): > > net/bnxt: add initial tf core resource mgmt support > > net/bnxt: add tf core TCAM support > > > > Venkat Duvvuru (9): > > net/bnxt: fetch SVIF information from the firmware > > net/bnxt: fetch vnic info from DPDK port > > net/bnxt: add devargs parameter for host memory based TRUFLOW feature > > net/bnxt: add support for ULP session manager init > > net/bnxt: add support for ULP session manager cleanup > > net/bnxt: register tf rte flow ops > > net/bnxt: disable vector mode when host based TRUFLOW is enabled > > net/bnxt: add support for injecting mark into packet=E2=80=99s mbuf > > net/bnxt: enable meson build on truflow code > > > > Hi Ajit, > > If there will be a new version, I suggest following commit titles, if the= y > make > sense can you update accordingly? > > net/bnxt: update HSI structure > net/bnxt: update HWRM prep to use pointer > net/bnxt: add TruFlow message handlers > net/bnxt: add initial TruFlow core session open > net/bnxt: add initial TruFlow core session close > net/bnxt: add TruFlow core session SRAM > net/bnxt: add initial TruFlow core resource management > net/bnxt: add resource manager > net/bnxt: add TruFlow core identifier > net/bnxt: support TruFlow core TCAM > net/bnxt: support TruFlow core table scope > net/bnxt: support EM/EEM > net/bnxt: fetch SVIF information from firmware > net/bnxt: fetch VNIC info > net/bnxt: support host memory based TruFlow > net/bnxt: support ULP session manager init > net/bnxt: support ULP session manager cleanup > net/bnxt: add helper functions for blob/regfile ops > net/bnxt: support process action tables > net/bnxt: support process key tables > net/bnxt: support freeing key and action tables > net/bnxt: support alloc and program key and act tables > net/bnxt: match flow API items with flow template patterns > net/bnxt: match flow API actions with flow template actions > net/bnxt: support flow API item parsing > net/bnxt: support flow API action parsing > net/bnxt: support flow API create > net/bnxt: support flow API validate > net/bnxt: support flow API destroy > net/bnxt: support flow API flush > net/bnxt: register TruFlow flow API ops > net/bnxt: disable vector mode on host based TruFlow > net/bnxt: support marking packet > net/bnxt: enable meson build on TruFlow > Ferruh, These look ok to me. Do you want me to respin the set or can you handle it this time? I am fine with both. Thanks Ajit