From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 85A84A04DC; Mon, 19 Oct 2020 05:30:48 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id E47F6BE59; Mon, 19 Oct 2020 05:30:45 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id A0C52BCC2 for ; Mon, 19 Oct 2020 05:30:43 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id m22so9204206ots.4 for ; Sun, 18 Oct 2020 20:30:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Q9dsu9E8GyrLxvFBGlB8NWktBOlWzLChWDSY92A52C4=; b=Gvha+l/LaBZyU/wRPu3mIMDHROUoFvVUd9GTJaITUHPcCo2mVPCuoqE2JxrFVvjTwP dO7I/mfaiBwe0W2j3iAM72biA8m5qVh9LQ1bDu2UqhXS5vzXjAlNjxV4qEFN1kaZOW+z UX7cuhHSBTpLLPLn6LbnB5U034vpDxVs+vDMI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Q9dsu9E8GyrLxvFBGlB8NWktBOlWzLChWDSY92A52C4=; b=MXDa7SxzILj280KJzQAoibPx8XHD2Ct1NPRkV1cFqfm6OyEDutwjL53TTdvtCtKWT4 fnaG1HpNW839bWEDWVjBt5O+LchxwspKPTRJQxeE8fcstpgl7301cXPdje0t1URHggig 1Eof4mu3vuVBjEqVaIgIlFW7UjDa3z4agSMK6+Rgua8G4qskU8evydovl+6Jpp5luRxu dcLkpatB+GJ35TaknIT68I3glxnh4whvgca3x8fA9GJxZLIc9xA4xawZT+YcRZMOVbBH 0TUI9rxS35eCkx2i3v2qUXRLZiPvZRun4ruKlgroZgBeDGuzQ4LJdelUqu2MhQQq4RfR BP0w== X-Gm-Message-State: AOAM53002wgjjCJVZJyC66SebeKZrGcA3CWn0Xz8OIcggfPfCF1mHFN8 svW4cX+K0KAq8Anj4TbaKL0fBznxtvxPrmkH87cFKw== X-Google-Smtp-Source: ABdhPJwecTM5iM3r9o6rKxdfQlzkzzhj1ICD9111cNm4IAsrrBKT0fKTq/fGF7q5m0YIDCGFhqvJfkQEjIHJAL4U9RM= X-Received: by 2002:a9d:1909:: with SMTP id j9mr11143324ota.283.1603078241550; Sun, 18 Oct 2020 20:30:41 -0700 (PDT) MIME-Version: 1.0 References: <20200831075333.10135-1-nipun.gupta@nxp.com> <20201015132343.4050-1-nipun.gupta@nxp.com> In-Reply-To: <20201015132343.4050-1-nipun.gupta@nxp.com> From: Ajit Khaparde Date: Sun, 18 Oct 2020 20:30:25 -0700 Message-ID: To: nipun.gupta@nxp.com Cc: dpdk-dev , Thomas Monjalon , Ferruh Yigit , Andrew Rybchenko , Hemant Agrawal , Sachin Saxena , rohit.raj@nxp.com, Jerin Jacob , Stephen Hemminger , asafp@nvidia.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/3 v4] ethdev: add Rx offload to drop error packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Oct 15, 2020 at 6:24 AM wrote: > > From: Nipun Gupta > > This change adds a Rx offload capability and configuration to > enable hardware to drop the packets in case of any error in the > packets such as L3 checksum error or L4 checksum. > > Signed-off-by: Nipun Gupta > Signed-off-by: Rohit Raj > Reviewed-by: Asaf Penso > --- > > v4: > - renamed 'rte_rx_err_pkt_drop_conf' to > 'rte_eth_rx_err_pkt_drop_conf' > - updated function 'port_offload_cap_display' to display newly > added offloads > - added placeholder for L1 FCS, L3 Checksum, L4 Checksum error > packet drops > - updated doc/guides/nics/features.rst > - updated new added 'DEV_RX_OFFLOAD_*' to 'RTE_DEV_RX_OFFLOAD*' > - updated RX to Rx > > v3: > - Add additional rx_err_drop_offload_capa, which is specific > capability flag for RX packets error drop offload. Currently > only 'all' error packet drops are enabled, but can be extended > to provide capability to drop any specific errors like L1 FCS, > L3 Checksum etc. > - Added separate config structure to enable the drop configuration. > - Updated doc with the new updated option in testbbdev (patch 3/3) > > v2: > - Add support in DPAA1 driver (patch 2/3) > - Add support and config parameter in testpmd (patch 3/3) > > lib/librte_ethdev/rte_ethdev.c | 1 + > lib/librte_ethdev/rte_ethdev.h | 39 +++++++++++++++++++++++++++++++++- > 2 files changed, 39 insertions(+), 1 deletion(-) > > diff --git a/lib/librte_ethdev/rte_ethdev.c b/lib/librte_ethdev/rte_ethdev.c > index 48d1333b1..be25e947e 100644 > --- a/lib/librte_ethdev/rte_ethdev.c > +++ b/lib/librte_ethdev/rte_ethdev.c > @@ -128,6 +128,7 @@ static const struct { > RTE_RX_OFFLOAD_BIT2STR(SCTP_CKSUM), > RTE_RX_OFFLOAD_BIT2STR(OUTER_UDP_CKSUM), > RTE_RX_OFFLOAD_BIT2STR(RSS_HASH), > + RTE_RX_OFFLOAD_BIT2STR(ERR_PKT_DROP), > }; > > #undef RTE_RX_OFFLOAD_BIT2STR > diff --git a/lib/librte_ethdev/rte_ethdev.h b/lib/librte_ethdev/rte_ethdev.h > index d2bf74f12..0db4b4021 100644 > --- a/lib/librte_ethdev/rte_ethdev.h > +++ b/lib/librte_ethdev/rte_ethdev.h > @@ -1194,6 +1194,28 @@ struct rte_intr_conf { > uint32_t rmv:1; > }; > > +/** > + * A structure used to enable/disable error packet drop on Rx. > + */ > +struct rte_eth_rx_err_pkt_drop_conf { > + /** enable/disable L1 FSC error packet drop on Rx. s/FSC/FCS Its L2 FCS. FCS is a part of Ethernet frame. > + * 0 (default) - disable, 1 enable > + */ > + uint32_t l1_fcs:1; l2_fcs; > + /** enable/disable L3 Checksum error packet drop on Rx. > + * 0 (default) - disable, 1 enable > + */ > + uint32_t l3_csum:1; > + /** enable/disable L4 Checksum error packet drop on Rx. > + * 0 (default) - disable, 1 enable > + */ > + uint32_t l4_csum:1; > + /** enable/disable all Rx error packet drop. > + * 0 (default) - disable, 1 enable > + */ > + uint32_t all:1; > +}; > + > /** > * A structure used to configure an Ethernet port. > * Depending upon the RX multi-queue mode, extra advanced > @@ -1236,10 +1258,12 @@ struct rte_eth_conf { > uint32_t dcb_capability_en; > struct rte_fdir_conf fdir_conf; /**< FDIR configuration. DEPRECATED */ > struct rte_intr_conf intr_conf; /**< Interrupt mode configuration. */ > + struct rte_eth_rx_err_pkt_drop_conf err_pkt_drop_conf; > + /**< Rx error packet drop configuration. */ > }; > > /** > - * RX offload capabilities of a device. > + * Rx offload capabilities of a device. > */ > #define DEV_RX_OFFLOAD_VLAN_STRIP 0x00000001 > #define DEV_RX_OFFLOAD_IPV4_CKSUM 0x00000002 > @@ -1260,6 +1284,7 @@ struct rte_eth_conf { > #define DEV_RX_OFFLOAD_SCTP_CKSUM 0x00020000 > #define DEV_RX_OFFLOAD_OUTER_UDP_CKSUM 0x00040000 > #define DEV_RX_OFFLOAD_RSS_HASH 0x00080000 > +#define DEV_RX_OFFLOAD_ERR_PKT_DROP 0x00100000 > > #define DEV_RX_OFFLOAD_CHECKSUM (DEV_RX_OFFLOAD_IPV4_CKSUM | \ > DEV_RX_OFFLOAD_UDP_CKSUM | \ > @@ -1274,6 +1299,16 @@ struct rte_eth_conf { > * mentioned in rte_rx_offload_names in rte_ethdev.c file. > */ > > +/** > + * Rx Error Drop offload config/capabilities of a device. These > + * are valid only when Rx capability RTE_DEV_RX_OFFLOAD_ERR_PKT_DROP > + * is supported by the device. > + */ > +#define RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_L1_FCS 0x00000001 RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_L2_FCS > +#define RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_L3_CSUM 0x00000002 > +#define RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_L4_CSUM 0x00000004 > +#define RTE_DEV_RX_ERR_PKT_DROP_OFFLOAD_ALL 0x80000000 > + > /** > * TX offload capabilities of a device. > */ > @@ -1411,6 +1446,8 @@ struct rte_eth_dev_info { > /**< Device per-queue RX offload capabilities. */ > uint64_t tx_queue_offload_capa; > /**< Device per-queue TX offload capabilities. */ > + uint64_t rx_err_drop_offload_capa; > + /**< RX error packet drop offload capabilities. */ > uint16_t reta_size; > /**< Device redirection table size, the total number of entries. */ > uint8_t hash_key_size; /**< Hash key size in bytes */ > -- > 2.17.1 >