From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: Somnath Kotur <somnath.kotur@broadcom.com>, dpdk-dev <dev@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: don't log at error level on flow creation
Date: Thu, 31 Oct 2019 11:35:59 -0700 [thread overview]
Message-ID: <CACZ4nhtLtYz5ZemLJHMC3Qe0-=ku3_mo8ULs68jaBHx+=EF7PA@mail.gmail.com> (raw)
In-Reply-To: <CACZ4nhvMMPJ2WwL7rQMg=Yx66sCQd7DYw_noG7uYtfTwfGgjCw@mail.gmail.com>
On Thu, Oct 31, 2019 at 11:23 AM Ajit Khaparde <ajit.khaparde@broadcom.com>
wrote:
>
>
> On Mon, Oct 28, 2019 at 9:53 AM Stephen Hemminger <
> stephen@networkplumber.org> wrote:
>
>> Creating a flow is a normal event; should not be logged at error level.
>>
>> Fixes: 5c1171c97216 ("net/bnxt: refactor filter/flow")
>> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>>
> Acked-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
>
Patch applied to dpdk-next-net-brcm.
>
>
>> ---
>> drivers/net/bnxt/bnxt_flow.c | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/bnxt/bnxt_flow.c b/drivers/net/bnxt/bnxt_flow.c
>> index cad232aba7da..8f386cdf1331 100644
>> --- a/drivers/net/bnxt/bnxt_flow.c
>> +++ b/drivers/net/bnxt/bnxt_flow.c
>> @@ -1758,7 +1758,7 @@ bnxt_flow_create(struct rte_eth_dev *dev,
>> }
>>
>> STAILQ_INSERT_TAIL(&vnic->filter, filter, next);
>> - PMD_DRV_LOG(ERR, "Successfully created flow.\n");
>> + PMD_DRV_LOG(DEBUG, "Successfully created flow.\n");
>> STAILQ_INSERT_TAIL(&vnic->flow_list, flow, next);
>> bnxt_release_flow_lock(bp);
>> return flow;
>> --
>> 2.20.1
>>
>>
prev parent reply other threads:[~2019-10-31 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-28 16:53 Stephen Hemminger
2019-10-31 18:23 ` Ajit Khaparde
2019-10-31 18:35 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CACZ4nhtLtYz5ZemLJHMC3Qe0-=ku3_mo8ULs68jaBHx+=EF7PA@mail.gmail.com' \
--to=ajit.khaparde@broadcom.com \
--cc=dev@dpdk.org \
--cc=somnath.kotur@broadcom.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).