From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2EF51A0547; Fri, 12 Mar 2021 20:09:31 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DE1FD1608C9; Fri, 12 Mar 2021 20:09:30 +0100 (CET) Received: from mail-qt1-f182.google.com (mail-qt1-f182.google.com [209.85.160.182]) by mails.dpdk.org (Postfix) with ESMTP id B0D2C1608C7 for ; Fri, 12 Mar 2021 20:09:29 +0100 (CET) Received: by mail-qt1-f182.google.com with SMTP id f12so4632822qtq.4 for ; Fri, 12 Mar 2021 11:09:29 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=UEN5cG6tp4BwNZsXr/RNL7iM7Ou1zAtmI9KMuQ6VKmY=; b=FpFWspTr19a+7QfsAevwjQ17TXrfgbj51o+iUoesD2MbQXk0wV6Q9SLxS8dKls8pif f51bTzoZX4cH0BLuK57u4GhugouCIY/Ntj+F6yWgkh20mCFVaTU0kL8NtaW1Cle0cCXN 3UzilipkJDhvv2PoGFk56IBqepAp0vRiMZY+8= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=UEN5cG6tp4BwNZsXr/RNL7iM7Ou1zAtmI9KMuQ6VKmY=; b=cjIKbCBGI4DE7kVMIjFOynDDqIFSxhtMCe40EaC97ihFBfgGgP2nTRFjfcStlTDjZq 8EJoVujpcVAUvbzJkv91hNsWmDB0qpvl03UTAKTjqlzGPfTTCufLRxeRosIe5Cn4aZ3p jQn/cUX7D/PjeP9EJpuUgp37p7z6s7m6rYCy8nx3ONDziSYLXEzSvW/f0BFUFJ8mvpvx 0oGiXVaGK4rqvH5duU+e4UAsFtnyyYzdtX7sjnwH3UJ79NwYnwwHtkkoN8bJXzhewNnz KmBXV/0z1Fj8V/I7C/HQIOPR/Fr/8kFLY2d4CHwsAEST0avNjzeAkLso3/yLjewQv0Pg 0xEA== X-Gm-Message-State: AOAM5304Y+DL1O4nSMV+4TIcp39d36og8kizf4x88w1Z6rSUlxIJxU6M NAPQ8vqyOvuKu+c4VQXlJFiqTXTXgXBrQuEF9s9nSg== X-Google-Smtp-Source: ABdhPJxT7Kg76fXP1cyZMwMdOmEm3NmzItICpEY3XB/Uu2cxrG8A8OoP/9J0RcPI9sZjvutUafTFplIXv+PT/53eswo= X-Received: by 2002:a05:622a:28b:: with SMTP id z11mr13316256qtw.225.1615576168878; Fri, 12 Mar 2021 11:09:28 -0800 (PST) MIME-Version: 1.0 References: <20210309233116.1934666-1-thomas@monjalon.net> <20210309233116.1934666-12-thomas@monjalon.net> In-Reply-To: <20210309233116.1934666-12-thomas@monjalon.net> From: Ajit Khaparde Date: Fri, 12 Mar 2021 11:09:12 -0800 Message-ID: To: Thomas Monjalon Cc: dpdk-dev , David Marchand , Xiaoyun Li Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="000000000000ad435c05bd5ba361" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH 11/11] app/testpmd: fix usage text X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --000000000000ad435c05bd5ba361 Content-Type: text/plain; charset="UTF-8" On Tue, Mar 9, 2021 at 3:32 PM Thomas Monjalon wrote: > > The options help text was including an incomplete and redundant > summary of the options before explaining each. The summary is dropped. > > The details of the option --hairpin-mode had an extra space, > breaking the alignment with the next line. > > Signed-off-by: Thomas Monjalon Acked-by: Ajit Khaparde > --- > app/test-pmd/parameters.c | 26 ++------------------------ > 1 file changed, 2 insertions(+), 24 deletions(-) > > diff --git a/app/test-pmd/parameters.c b/app/test-pmd/parameters.c > index 7f41021d4d..efcbf1e845 100644 > --- a/app/test-pmd/parameters.c > +++ b/app/test-pmd/parameters.c > @@ -49,29 +49,7 @@ > void > usage(const char *progname) > { > - printf("usage: %s [EAL options] -- " > -#ifdef RTE_LIB_CMDLINE > - "[--interactive|-i] " > - "[--cmdline-file=FILENAME] " > -#endif > - "[--help|-h] | [--auto-start|-a] | [" > - "--tx-first | --stats-period=PERIOD | " > - "--coremask=COREMASK --portmask=PORTMASK --numa " > - "--portlist=PORTLIST " > - "--mbuf-size= | --total-num-mbufs= | " > - "--nb-cores= | --nb-ports= | " > -#ifdef RTE_LIB_CMDLINE > - "--eth-peers-configfile= | " > - "--eth-peer=X,M:M:M:M:M:M | " > - "--tx-ip=SRC,DST | --tx-udp=PORT | " > -#endif > - "--pkt-filter-mode= |" > - "--rss-ip | --rss-udp | --rss-level-inner | --rss-level-outer |" > - "--rxpt= | --rxht= | --rxwt= |" > - " --rxfreet= | --txpt= | --txht= | --txwt= | --txfreet= | " > - "--txrst= | --tx-offloads= | | --rx-offloads= | " > - "--vxlan-gpe-port= | --geneve-parsed-port= | " > - "--record-core-cycles | --record-burst-stats]\n", > + printf("\nUsage: %s [EAL options] -- [testpmd options]\n\n", > progname); > #ifdef RTE_LIB_CMDLINE > printf(" --interactive: run in interactive mode.\n"); > @@ -221,7 +199,7 @@ usage(const char *progname) > "enabled\n"); > printf(" --record-core-cycles: enable measurement of CPU cycles.\n"); > printf(" --record-burst-stats: enable display of RX and TX bursts.\n"); > - printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n " > + printf(" --hairpin-mode=0xXX: bitmask set the hairpin port mode.\n" > " 0x10 - explicit Tx rule, 0x02 - hairpin ports paired\n" > " 0x01 - hairpin ports loop, 0x00 - hairpin port self\n"); > } > -- > 2.30.1 > --000000000000ad435c05bd5ba361--