From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id DAA1AA04B7; Tue, 13 Oct 2020 23:37:14 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9E3C21D6AB; Tue, 13 Oct 2020 23:37:12 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id ADEBD1D426 for ; Tue, 13 Oct 2020 23:37:09 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id m13so1480992otl.9 for ; Tue, 13 Oct 2020 14:37:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=JNbwlnNNuWDUe755owgb5gXl2uSYrA4MBCznxw2CMSo=; b=aWXb2e/UNPM2zFAPZgX6uQTXwIznNa2fp334G8xUhf51/F3Uc0Ejb3izgC61SyPhVx L9GHqWxAZx/3Ge156xg5UW921OCcY303jvXMo0AIDLIkpqqAORhCAEfFTDyK6iGRDE+V myrJa2t17m74j36Vkb9lp0biZJ31SJzJwts3U= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=JNbwlnNNuWDUe755owgb5gXl2uSYrA4MBCznxw2CMSo=; b=s2N0oN+PMlxc9fTXGf1QdaQV7MSEztkRnj2AIEQu5dFsXtIShwpq8bkfqzco6CV5I0 C68IOTbCthVYcL/IaQYPvMO5O/wZq6uy5pbLMqzwB3oQdKHUD+4S3dZ75HKHtrA86+On tYyCM2+KN53IjLI+MKp1oLfxm5xOdlQ8Inu9RPDXvBm38HPe4d77ziP3WkavyR5FDAC/ AjQ3875Kp9wvKFmhwinVpU+f5cNa+70e7wRxvB2hpWV3eAIdfHxSF1aF/G+DKGUhamYV 1o+v1NdB9w/H6ODc14PCFbz/mbxnBQ2tWCNaljqghK6dqCJ232Y8PROofWvI8RDJ4/7v pZhQ== X-Gm-Message-State: AOAM533RHeTCuXckTG3PuaYhsEDojhMc1lU9su04hYyd2GFedCppxLfX yLnO0EHJ5fvnwonhTP+C42ypx5dXJK4Y7RjSVq0N6A== X-Google-Smtp-Source: ABdhPJyOf1wpUVfs0gCivEGj2a8ioJ+IbmdgBEjfkAPRBGWlgaTn1uZ4fQFuonoi5GQzrbfNrjU8FCeWROpEb+zQ6PI= X-Received: by 2002:a9d:1909:: with SMTP id j9mr1228704ota.283.1602625027832; Tue, 13 Oct 2020 14:37:07 -0700 (PDT) MIME-Version: 1.0 References: <20201012224814.10472-1-rmody@marvell.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 13 Oct 2020 14:36:51 -0700 Message-ID: To: Ferruh Yigit Cc: Jerin Jacob , Rasesh Mody , dpdklab , Jerin Jacob , dpdk-dev , dpdk stable , GR-Everest-DPDK-Dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnx2x: fix to add QLogic vendor id X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Tue, Oct 13, 2020 at 1:43 PM Ferruh Yigit wrote: > > On 10/13/2020 7:28 PM, Jerin Jacob wrote: > > On Tue, Oct 13, 2020 at 4:18 AM Rasesh Mody wrote: > >> > >> Add QLogic vendor id support for BCM57840 device ids. > >> > >> Fixes: 9fb557035d90 ("bnx2x: enable PMD build") > >> Cc: stable@dpdk.org > >> > >> Reported-by: Souvik Dey > >> Signed-off-by: Rasesh Mody > > > > > > There was an error from CI on Broadcom CI, > > Since this patch is about Broadcom PMD fix, Do we need to worry about this? > > http://mails.dpdk.org/archives/test-report/2020-October/158246.html > > > > Errors shouldn't be related to this patch, so I think error can be ignored for > this patch. +1 > > But added Ajit & lab for the issue. I have seen this behavior earlier. It showed up randomly on some patches which are not even related to Broadcom PMD. I will try to keep an eye on it. > > > > >> --- > >> drivers/net/bnx2x/bnx2x_ethdev.c | 4 ++++ > >> 1 file changed, 4 insertions(+) > >> > >> diff --git a/drivers/net/bnx2x/bnx2x_ethdev.c b/drivers/net/bnx2x/bnx2x_ethdev.c > >> index 40225b2f4..ce9df8748 100644 > >> --- a/drivers/net/bnx2x/bnx2x_ethdev.c > >> +++ b/drivers/net/bnx2x/bnx2x_ethdev.c > >> @@ -17,6 +17,7 @@ > >> * The set of PCI devices this driver supports > >> */ > >> #define BROADCOM_PCI_VENDOR_ID 0x14E4 > >> +#define QLOGIC_PCI_VENDOR_ID 0x1077 > >> static const struct rte_pci_id pci_id_bnx2x_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57800) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57711) }, > >> @@ -24,11 +25,13 @@ static const struct rte_pci_id pci_id_bnx2x_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_OBS) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_4_10) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_2_20) }, > >> #ifdef RTE_LIBRTE_BNX2X_MF_SUPPORT > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_MF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_MF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_MF) }, > >> #endif > >> { .vendor_id = 0, } > >> }; > >> @@ -38,6 +41,7 @@ static const struct rte_pci_id pci_id_bnx2xvf_map[] = { > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57810_VF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57811_VF) }, > >> { RTE_PCI_DEVICE(BROADCOM_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > >> + { RTE_PCI_DEVICE(QLOGIC_PCI_VENDOR_ID, CHIP_NUM_57840_VF) }, > >> { .vendor_id = 0, } > >> }; > >> > >> -- > >> 2.18.0 > >> >