From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 32D5CA04BB; Thu, 24 Sep 2020 21:25:31 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id A632E1DEFA; Thu, 24 Sep 2020 21:25:29 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id AD2591DEEF for ; Thu, 24 Sep 2020 21:25:28 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id h17so32645otr.1 for ; Thu, 24 Sep 2020 12:25:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=/7xDyik8MRv+1IwZPwXjNzvMO/5QMjqbTu9k44UJ6ps=; b=ZDruG45w8u3Wu9FoNYom/akoeRJdyhX0kxLYdpxPyVYIX9WaAmIJuqbZr6WdhmIOC9 Yov7k4qK5TbaLqPPUL9eO8p/vY4DR3bawIlV2aYaKT3cCkw9KKWlXvyqL/Bae+a3Y3hH 5z8y/2FsM5aNa1Tk4gt5MhvMxfA9yyPYEkEOQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=/7xDyik8MRv+1IwZPwXjNzvMO/5QMjqbTu9k44UJ6ps=; b=didkvbG8IQ6u5xKfwMx+yjNFAD5r7HtPbeNljIVw6f/SsqN7bBdJTGR/WQgcvFMMEa TlnN5fOTk0J6EOxcwNsxdNlSozJosBVQK9QpVimwJLPCP81wR5M632CxTtKWL6x96zNt vU9A8PcsEcxI4lYUrZd95ZUanlfscN/6vIUZ3U+125Pgyz89Z4dU6wCenG989ikqstl9 mhx7MYRRZFuS0+Gac0ghbYSvl8TOKcE+uqxqN/cCN9hO4wl+F0MTfxQDFivc/n38ABOp a9Vj0sCTYbOS+kemwC+4xbd/ntTB49XJNTtlbtcRkqYU7KNHrcDsmYZhnyZ3KnA9fc1h e6uA== X-Gm-Message-State: AOAM532jynxidOQNWzYeoSEB+oRB05dsaDgOt3+XhbcYI47smMwZ4UOh pJWy1mEevnmCIrf5GdC/7HjZTi/nLlZUQRpi70habA== X-Google-Smtp-Source: ABdhPJxuXnDl2suxVn5wJJxye7Sb3X2w1ahoNaGolVgmb/6wDp1jtDTRtKSG3LgVex87HNwItsT05a87qygoB2n5C5o= X-Received: by 2002:a9d:5e4:: with SMTP id 91mr453039otd.95.1600975527817; Thu, 24 Sep 2020 12:25:27 -0700 (PDT) MIME-Version: 1.0 References: <20200702120511.16315-1-andreyv@mellanox.com> <20200708213946.30108-1-andreyv@mellanox.com> <20200708213946.30108-2-andreyv@mellanox.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 24 Sep 2020 12:25:11 -0700 Message-ID: To: Ori Kam Cc: Andrew Rybchenko , Andrey Vesnovaty , NBU-Contact-Thomas Monjalon , Slava Ovsiienko , "jerinj@marvell.com" , dpdk-dev , "jer@marvell.com" , Jerin Jacob , Ferruh Yigit , Stephen Hemminger , Bruce Richardson , Ori Kam , Viacheslav Ovsiienko , "andrey.vesnovaty@gmail.com" , Ray Kinsella , Neil Horman , Thomas Monjalon , Samik Gupta Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Sep 17, 2020 at 9:03 AM Ori Kam wrote: > > > > > -----Original Message----- > > From: Andrew Rybchenko > > Sent: Thursday, September 17, 2020 6:34 PM > > > > Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API > > > > On 9/16/20 10:20 PM, Ajit Khaparde wrote: > > > On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty > > wrote: > > >> > > >> Hi Ajit > > >> > > >> For shared action configuration I have following suggestion: > > >> > > >> struct rte_flow_shared_action_conf { > > >> uint32_t no_ingress: 1; > > >> uint32_t no_egress: 1; > > >> }; > > >> /*...*/ > > >> rte_flow_shared_action_create(..., const struct > > rte_flow_shared_action_conf *conf, ...); > > >> > > >> What do you think? > > > Andrey, I think this is good. > > > Application can specify the direction and PMD can decide whether if > > > it needs to honor it or ignore it. > > > Please send the updated version of the patch. > > > > Personally I dislike negative flags, offloads, fields etc. > > Don't we have a policy to avoid it. At least we have it for > > offloads. I see no string reasons here to use negative > > instead of positive here. > > Agree I think it is better to use positive values and the same names as the > attribute in the flow. Has a new version of the patch been submitted? Thanks >