From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 99EBFA0C47; Sun, 31 Oct 2021 17:04:47 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 245324068E; Sun, 31 Oct 2021 17:04:47 +0100 (CET) Received: from mail-io1-f49.google.com (mail-io1-f49.google.com [209.85.166.49]) by mails.dpdk.org (Postfix) with ESMTP id 956C140689 for ; Sun, 31 Oct 2021 17:04:46 +0100 (CET) Received: by mail-io1-f49.google.com with SMTP id v65so18777031ioe.5 for ; Sun, 31 Oct 2021 09:04:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=dof1rFcBtm6yXtVbT9BpT1cbuKVzyGA+v+jZu0CWmNY=; b=H2D7gRrou5la6/iS6fjRInQuwtYJHF+3YlpMTu4m+4ev57X0881Gc7re9tFiTXYmpK Y9ma5oKdVrp9xi1V4yvckI69mtXCGke1TejQ5xwqaTXcT/uzdFTLJ94phqqW6cToAS51 Kih4tXqOCwcDjNl57wTOiYNSD5VqUxsQpO1VI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=dof1rFcBtm6yXtVbT9BpT1cbuKVzyGA+v+jZu0CWmNY=; b=oER0DFpJN9F+MvHlzq9NtPgUV2rKC+Or7fZ7oEAlkRzpE96OGt40aF27WI6pELDqI/ 10ZdrOXm2bSLatHOSsWtcz+zRE0CQFqC6fmiZh7K7wpe7BL+jIe0AbzUJaVVLJxkpyWW FkvJk9Fbm2gd2XqhaF3xa0izrs5p5vJ1uKPJTQx98pL8Ik4/NK9ZC/16mmj4rczEpqLq djxRJ3y1NG0fBPatwkn6Gjw9vlxNOrniClc/IeCbFzEvaEiGWrDSIgitqCob35l1M0+r KeDrRU5qHVm8iuylAf8GoYK+nPib0wWzYiP3+/wC+YVEWovMWhD0weEhj8L1H9PlcQu0 HlMw== X-Gm-Message-State: AOAM532/VYpZS+SqObVZqWk7j5ck0CJMYGgo/r6hkFgpvEw2OuFvss3F bnfnKY+6TxdqRY/3GG7EPmx6W81bI1O823KFajU+RA== X-Google-Smtp-Source: ABdhPJxHKqOKVYtxZ7SBD3r1bVycXYa7kuIunioujt9zfZkc2zoTUAPaa6jKb0J5HtQyf8Xx9oFTaYrI6eJCYFc04bQ= X-Received: by 2002:a05:6638:2115:: with SMTP id n21mr17719860jaj.33.1635696285868; Sun, 31 Oct 2021 09:04:45 -0700 (PDT) MIME-Version: 1.0 References: <20211030035020.31813-1-kalesh-anakkur.purayil@broadcom.com> In-Reply-To: <20211030035020.31813-1-kalesh-anakkur.purayil@broadcom.com> From: Ajit Khaparde Date: Sun, 31 Oct 2021 09:04:29 -0700 Message-ID: To: Kalesh A P Cc: dpdk-dev , Ferruh Yigit Content-Type: text/plain; charset="UTF-8" Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: fix freeing aggregation rings X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 29, 2021 at 8:30 PM Kalesh A P wrote: > > From: Kalesh AP > > During port stop, we clear "eth_dev->data->scattered_rx" at the > beginning. As a result, in bnxt_free_hwrm_rx_ring() the check > bnxt_need_agg_ring() returns false and we end up not freeing > the Rx aggregation rings which results in resource leak in the FW. > > Fixes: 657c2a7f1dd4 ("net/bnxt: create aggregation rings when needed") > > Signed-off-by: Kalesh AP > Reviewed-by: Ajit Khaparde > Reviewed-by: Somnath Kotur Patch applied to dpdk-next-net-brcm.Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 668e3aa..91f114e 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1476,7 +1476,6 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev) > int ret; > > eth_dev->data->dev_started = 0; > - eth_dev->data->scattered_rx = 0; > > /* Prevent crashes when queues are still in use */ > eth_dev->rx_pkt_burst = &bnxt_dummy_recv_pkts; > @@ -1533,6 +1532,8 @@ static int bnxt_dev_stop(struct rte_eth_dev *eth_dev) > if (BNXT_FLOW_XSTATS_EN(bp)) > bp->flow_stat->flow_count = 0; > > + eth_dev->data->scattered_rx = 0; > + > return 0; > } > > -- > 2.10.1 >