From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 6BBE2A0A0C; Mon, 2 Aug 2021 23:32:00 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D749E4117A; Mon, 2 Aug 2021 23:31:59 +0200 (CEST) Received: from mail-qk1-f181.google.com (mail-qk1-f181.google.com [209.85.222.181]) by mails.dpdk.org (Postfix) with ESMTP id 5815E41147 for ; Mon, 2 Aug 2021 23:31:58 +0200 (CEST) Received: by mail-qk1-f181.google.com with SMTP id az7so18070685qkb.5 for ; Mon, 02 Aug 2021 14:31:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=FTXJ2FIs4e2i4YtngtcOGQMg9HqMCBt3vnwvEMSzM34=; b=GudGzjWcStBUt0X7FSiS2kEzXGt1tBJRkf3kiTvnHs7ovUy6oqVSWBaiq9/LC5rS3x sp/qv0PrC6JG285+9ZRZ3iJmj/yZHhmWS8phMOUxzg9e8dUMVraHQjs8OCuYeUay5CJj kCsixhZqCv6aumNayIgeTLAWwPdOzCPgPUvls= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=FTXJ2FIs4e2i4YtngtcOGQMg9HqMCBt3vnwvEMSzM34=; b=XM5NRMt034OTkKnxwr8GapU2qa/NLZEjq8P6SKJ2z1cgq2QmXKD7TcVcu7i83eMGqc Mxb/yaYvKs8nzPN4iH1V3uf4RPMM0h37oeyK8TQVMfT6F9S9CGTTTg7JPS4FTr5IWbqS My8NY13NU0T4QcFY2EUNBOdHbO6Emvzu+UGYkvdD/6SUk6Up39vpB1f6ISOvZkNrN3w9 5MshdgowSrkzTXiOVkOIFHTNNd7GrTY1jttIPWgYwb4jVZEWIk1iT0QSBKFHGhTdBnMB toSys2iQAdrWMSCzghHvFoGuFIzjaNv2DYLsykorsmBoDeR3sKT5n8Pyos4HVqIBpJM/ rfSw== X-Gm-Message-State: AOAM533Re4+ylAQ4+MTnj4V+3e8Jb9sQbHK+8qws4TWLrjKue8cU3AzG NZpJtHrodU8paHnrKFWGJYfgMKZKjPDjfIUjdpkoLw== X-Google-Smtp-Source: ABdhPJxvyErTfYF17i9A1Nqihh8+2dZO9HubPgyCCLXfOTs0VPIm7oqXf+rv+2Y7MD5O/Kp7sAzxkSwKPqb0QqVamCo= X-Received: by 2002:a05:620a:120b:: with SMTP id u11mr17276807qkj.455.1627939917652; Mon, 02 Aug 2021 14:31:57 -0700 (PDT) MIME-Version: 1.0 References: <20210730155700.32574-1-olivier.matz@6wind.com> In-Reply-To: From: Ajit Khaparde Date: Mon, 2 Aug 2021 14:31:41 -0700 Message-ID: To: Andrew Rybchenko Cc: Olivier Matz , dpdk-dev , Ray Kinsella Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000085907905c89a4c79" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] doc: announce renaming of mbuf offload flags X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --00000000000085907905c89a4c79 Content-Type: text/plain; charset="UTF-8" On Sat, Jul 31, 2021 at 5:15 AM Andrew Rybchenko wrote: > > On 7/30/21 6:57 PM, Olivier Matz wrote: > > The mbuf offload flags do not match the DPDK namespace (they are > > not prefixed by RTE_). Announce their rename in 21.11, and the > > removal of the old names in 22.11. > > > > A draft coccinelle script is provided to anticipate what the > > renaming will be. > > > > Signed-off-by: Olivier Matz > > Acked-by: Andrew Rybchenko > > [snip] > > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > > index 9584d6bfd7..04cb141de7 100644 > > --- a/doc/guides/rel_notes/deprecation.rst > > +++ b/doc/guides/rel_notes/deprecation.rst > > @@ -147,3 +147,8 @@ Deprecation Notices > > * cmdline: ``cmdline`` structure will be made opaque to hide platform-specific > > content. On Linux and FreeBSD, supported prior to DPDK 20.11, > > original structure will be kept until DPDK 21.11. > > + > > +* mbuf: The mbuf offload flags ``PKT_*`` will be renamed as ``RTE_MBUF_F_*``. > > + A compatibility layer will be kept until DPDK 22.11, except for the flags > > + that are already deprecated (ex: ``PKT_RX_L4_CKSUM_BAD``), which will > > + be removed. > > > > I think it is better to be explicit with defines to be removed: > PKT_RX_L4_CKSUM_BAD, PKT_RX_IP_CKSUM_BAD, PKT_TX_QINQ_PKT, > PKT_RX_EIP_CKSUM_BAD. +1 Acked-by: Ajit Khaparde --00000000000085907905c89a4c79--