From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 7D964A04B5; Sun, 1 Nov 2020 04:18:58 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1376672EF; Sun, 1 Nov 2020 04:18:57 +0100 (CET) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 07D0072EE for ; Sun, 1 Nov 2020 04:18:55 +0100 (CET) Received: by mail-ot1-f65.google.com with SMTP id m26so9360286otk.11 for ; Sat, 31 Oct 2020 20:18:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=YPmJmo7RPV/HxyXcHiwnwI+yuSX+/A40koSNOU1K9iw=; b=Xvw9N84d0u6ehFcCuJFmw+FkEZ6ZFX6yWqiC/3jjf3upGENKHgCJduJAtPbQyk3VnU UFFgQrpuRYTpW+1QJiTVuvnahzltKEvMlPQIANIbWUcKxe3xB8af0SLRaTv++x+/xlQm kmI25ccj5fT5XmOTDCtnklTOSiR+hOHAdC24Y= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=YPmJmo7RPV/HxyXcHiwnwI+yuSX+/A40koSNOU1K9iw=; b=XnHmU9ZwH5q2+LzlrHQTNYIHKXEfgdX8RU2huUxp19LYQstC6AOPqoI3w8ChKaDFD7 o44tB777CUqCfJ91HBFynDl6bEEapMcauo0/aq+TAiI56ii1CQOE3jIIG9V7wb9iNTRU fUk6b7D4cMOS/7VtPcDfeL9dIXvQko/oPnXRM0hzx3owwvkNdgoor+hFQUjxFmzRlfex HQbrpU2CJPWRIqXFfCU+CR7Ecn/slKB1rpBpl47TWaLhcS6wnv2WRU9kNGGHzkYg3mhS DKVYP+RZawPTfgJg72sudR6Dl4IXVGPTmJaYKsUuOuFEYapX3EvvFg/xBXOyIT6HWp4b EpBA== X-Gm-Message-State: AOAM532NKT09sOG0XSULrdPlubPka+GpLawkSGHPKXFnu5Miiz2AsF+J JrMuZFMw0JjROFFPD+nwgfhyys9V2XqaMMg1ijf6Uw== X-Google-Smtp-Source: ABdhPJwUFgKcIAciDrGZMV1bLOpSyTc01buvGBwzwOwXEpSMAyrhiqgYUVjsKn0L7TmVkwRxnD9tqgZKfBMRJXDdLvI= X-Received: by 2002:a9d:4d83:: with SMTP id u3mr2714498otk.283.1604200733239; Sat, 31 Oct 2020 20:18:53 -0700 (PDT) MIME-Version: 1.0 References: <20201030070304.22318-1-somnath.kotur@broadcom.com> In-Reply-To: <20201030070304.22318-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Sat, 31 Oct 2020 20:18:36 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , dpdk stable , Kalesh Anakkur Purayil Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/2] net/bnxt: log failure for switch domain free X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 12:11 AM Somnath Kotur wrote: > > Check and log an error message if switch domain free API fails > > Coverity issue: 362757 > > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > Cc: stable@dpdk.org > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh Anakkur Purayil Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++++-- > 1 file changed, 8 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index b2f72ea..31e94f2 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1343,8 +1343,14 @@ static int bnxt_dev_set_link_down_op(struct rte_eth_dev *eth_dev) > > static void bnxt_free_switch_domain(struct bnxt *bp) > { > - if (bp->switch_domain_id) > - rte_eth_switch_domain_free(bp->switch_domain_id); > + int rc = 0; > + > + if (bp->switch_domain_id) { > + rc = rte_eth_switch_domain_free(bp->switch_domain_id); > + if (rc) > + PMD_DRV_LOG(ERR, "free switch domain:%d fail: %d\n", > + bp->switch_domain_id, rc); > + } > } > > /* Unload the driver, release resources */ > -- > 2.7.4 >