From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D990A0548; Mon, 29 Mar 2021 16:18:48 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 8FA6A406B4; Mon, 29 Mar 2021 16:18:47 +0200 (CEST) Received: from mail-qk1-f182.google.com (mail-qk1-f182.google.com [209.85.222.182]) by mails.dpdk.org (Postfix) with ESMTP id 05CA34069D for ; Mon, 29 Mar 2021 16:18:45 +0200 (CEST) Received: by mail-qk1-f182.google.com with SMTP id o5so12553988qkb.0 for ; Mon, 29 Mar 2021 07:18:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZZkK8zNdvM8c8TG8lkJZe6ERVH8pvPfUWsvZKjkHuQA=; b=HvOsaVvasSqAKY56bHZi5NZ+zdoxlOhXXLgRT364qYlBqUKnQOaKvBHvdhvKgp5YwE L1zBwycKVsK56cV5I6XT4f0DC8nW80ump/s9pqOvdOEGa5tXO1sFNlk50bI9i8JqaKyT 2U8WR1YnUIdFuEyAtDveJ0vmM18j2NAkPXsuM= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZZkK8zNdvM8c8TG8lkJZe6ERVH8pvPfUWsvZKjkHuQA=; b=bppNOp3WfsfABVRtFZHSKN1oFjY9RhzLBnfo4L4/oO/7Ns7pnOSw4/O9LNAYD2KBM9 C7DWFXEUfZGZNVDmFz3PHGt7G4r9zZeGT6A7GK5+r15YLxxQU3py4AU5YK6L8HjLn/pr g0TeVRRZhuiv9mJxA3kEeuf4+s/snWL6CoQrqcXxpaaKIR/fUnWtK4fLWoFkh1K8xPkf ngLDGFztDsjbavbtHwEmRL+T3rFT/rScW/bc1tlIs0toN1AumiPu+vMCoqjzWt0HbsKq rkiic7g2lThRS93n+Y2CyJr/DFI0C3NmcoSYuZVXo/H9WQGR1YgwE9bHJsDhCXoSpFpg U7xw== X-Gm-Message-State: AOAM532rtGgSBgzOjz11VWuopmL4cp+ztgGNZNw4WXSIrQI+OWOxmOtT f/s3vvvjpJvb+dZ09LRyUOYpvvjZJZgaV8SaIJgGUA== X-Google-Smtp-Source: ABdhPJzOhXrmuH+5v1v4J8jKdWC7ZYja3AsYZroVfbwKbbOo88cgX0nk8JeTyuxXrsK0R7BPrF8NgbmmLYtdwi5fA5o= X-Received: by 2002:a37:7985:: with SMTP id u127mr25668375qkc.333.1617027524979; Mon, 29 Mar 2021 07:18:44 -0700 (PDT) MIME-Version: 1.0 References: <2a9f3c44-44da-854b-8b25-772a3570baa4@huawei.com> <9105928.7imIDBDKWL@thomas> <7245184.973KLNHvPo@thomas> In-Reply-To: <7245184.973KLNHvPo@thomas> From: Ajit Khaparde Date: Mon, 29 Mar 2021 07:18:29 -0700 Message-ID: To: Thomas Monjalon Cc: Huisong Li , dpdk-dev , Ferruh Yigit , Andrew Rybchenko , Jerin Jacob Kollanukkaran Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003ce86c05bead8ffc" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] Questions about reporting auto-negotiation capability X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000003ce86c05bead8ffc Content-Type: text/plain; charset="UTF-8" On Mon, Mar 29, 2021 at 12:19 AM Thomas Monjalon wrote: > > 29/03/2021 09:03, Thomas Monjalon: > > 29/03/2021 06:02, Huisong Li: > > > 'speed_capa' in struct rte_eth_dev_info is defined as follows: > > > > > > uint32_t speed_capa; /**< Supported speeds bitmap (ETH_LINK_SPEED_). */ > > > > > > > > > Most PMD drivers use this field to report the speeds capability > > > supported by the device to the upper-layer app. > > > > > > But it seems that few NICs report their auto-negotiation capability > > > through this field. If NIC also uses it to report > > > their auto-negotiation capability through this field, and should set it > > > to ETH_LINK_SPEED_AUTONEG(0) based on > > > the definition of ETH_LINK_SPEED_xxx. In this case, it conflicts the > > > report of the speeds capability . > > > > > > I don't know how to correctly report the auto-negotiation capability of > > > the device. Thanks for your reply. > > > > ETH_LINK_SPEED_AUTONEG is not for capabilities. > > Anyway, if it is set, it changes nothing (0) in the bitmap. > > I see mlx5 is wrongly using it. > > > > speed_capa is only for enumerating speeds. > > I see some drivers are advertising ETH_LINK_SPEED_FIXED in speed_capa > if the device cannot support autonegotiation. > Should we add a note in doxygen? I think we should do that. > > --0000000000003ce86c05bead8ffc--