From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 344A0A0C47; Wed, 22 Sep 2021 22:21:45 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id F2D9B411EC; Wed, 22 Sep 2021 22:21:44 +0200 (CEST) Received: from mail-io1-f48.google.com (mail-io1-f48.google.com [209.85.166.48]) by mails.dpdk.org (Postfix) with ESMTP id 23309411A8 for ; Wed, 22 Sep 2021 22:21:43 +0200 (CEST) Received: by mail-io1-f48.google.com with SMTP id y197so5042795iof.11 for ; Wed, 22 Sep 2021 13:21:43 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=6A4jLGjkg9/sek8TtwbOKCA86PchLbFeB2EP5tgGJWM=; b=ORI1QvU96o5kRGybOplrddpocJQsynoTEYNDytdhw1GesUWyjQTolhNCXtxClj2uIc CKTrq++Gaay0Y0a9ZaZxIt5C9IfONCO6RJbtuMD+ZJVDJ0VcTpBSSfYtuT6REFFapbdQ Evyb6jVlMaANE27FaJfRJzPxvp2Y41h9iOdV4= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=6A4jLGjkg9/sek8TtwbOKCA86PchLbFeB2EP5tgGJWM=; b=QPgXgem5Lj15/a37pQvfx6N0b7P9io3A8YxoPUzsho0+5qogxzj4Ji3S6KeTF2urrP 7eoxY0mV35UeSsg3/x3KG5UTL6uPfnhIO7TxTevt8cZjcPOD7Hn3nMcwHavQeqznH7ov QPUwow8WwTGnwObMui0jF1GBed8YQ2UzcntEppxIuoGk9dSifJlOuoRuPU7kwQ9GvcYw jskUHw+MKveOAGcAyjx139ofzyJ6+kr0ThJX/iebbqGE9oj1HqWk4RJuppZrpEqM/vBL 1Hi6btrGsbTTi6WoYRQ7VL0zWZZ9N/94DgjNuTBJEhP/WvgCr69Pw8MdXN9ge7I66j3V 3jBw== X-Gm-Message-State: AOAM532FK/AQiVNliSw275k+DUg//MzfM8yyFJCkdENzMLfo0i9z154p icUWnrniMyHdc2Ka2X+lugsNuQ/ooqWiHs3f4LXHHg== X-Google-Smtp-Source: ABdhPJyTscQ7J/JxPZoQWhSy/y6dKFvh+jd5WvEIHCO+0OCmFaWpeh0rRkSeD52b8cJesrMXTARbDP7PK0D311k08kU= X-Received: by 2002:a05:6638:3890:: with SMTP id b16mr813203jav.65.1632342102237; Wed, 22 Sep 2021 13:21:42 -0700 (PDT) MIME-Version: 1.0 References: <20210908050643.9989-1-venkatkumar.duvvuru@broadcom.com> <20210920074214.23747-1-venkatkumar.duvvuru@broadcom.com> <48401ae7-eeb8-9283-3894-747c89fd963a@intel.com> In-Reply-To: <48401ae7-eeb8-9283-3894-747c89fd963a@intel.com> From: Ajit Khaparde Date: Wed, 22 Sep 2021 13:21:26 -0700 Message-ID: To: Ferruh Yigit Cc: Venkat Duvvuru , dpdk-dev , David Marchand , Aaron Conole Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000002ebe2805cc9b43a9" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH v4 00/13] enhancements to host based flow table management X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000002ebe2805cc9b43a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Sep 22, 2021 at 10:36 AM Ferruh Yigit wrot= e: > > On 9/21/2021 5:50 AM, Ajit Khaparde wrote: > > On Mon, Sep 20, 2021 at 12:42 AM Venkat Duvvuru > > wrote: > >> > >> This patch set adds support for new offload features/enhancments for > >> Thor adapters like VF representor support, new flow matches/actions > >> & dynamic SRAM manager support. > >> > >> Farah Smith (4): > >> net/bnxt: updates to TF core index table > >> net/bnxt: add SRAM manager model > >> net/bnxt: change log level to debug > >> net/bnxt: add SRAM manager shared session > >> > >> Jay Ding (1): > >> net/bnxt: add flow meter drop counter support > >> > >> Kishore Padmanabha (6): > >> net/bnxt: add flow template support for Thor > >> net/bnxt: add support for tunnel offload API > >> net/bnxt: add support for dynamic encap action > >> net/bnxt: add wild card TCAM byte order for Thor > >> net/bnxt: add flow templates for Thor > >> net/bnxt: add enhancements to TF ULP > >> > >> Peter Spreadborough (1): > >> net/bnxt: enable dpool allocator > >> > >> Randy Schacher (1): > >> net/bnxt: dynamically allocate space for EM defrag function > > > > For the patchset, > > Acked-by: Ajit Khaparde > > > > Patchset applied to dpdk-next-net-brcm. > > 1) Changed instance of TF to TRUFLOW during merge in patch 1/13 and 13/= 13. > > > > Please apply to dpdk-next-net. Thanks > > > > Hi Ajit, > > The github actions fails on build for gcc, please check it on my personal= github > repo: > https://github.com/ferruhy/dpdk/actions/runs/1262767538 > > I don't have this error in my environment, this can be related to the sli= ghtly > older compiler in the github (gcc 7.5) Yes, even I did not see this. Looks genuine and likely because of some different compiler. I will try to submit a fix. Will you be able to squash it with the relevant commit? FAILED: drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.= c.o ccache gcc -Idrivers/a715181@@tmp_rte_net_bnxt@sta -Idrivers -I../drivers -Idrivers/net/bnxt -I../drivers/net/bnxt -Idrivers/net/bnxt/tf_ulp -I../drivers/net/bnxt/tf_ulp -Idrivers/net/bnxt/tf_ulp/generic_templates -I../drivers/net/bnxt/tf_ulp/generic_templates -Idrivers/net/bnxt/tf_core -I../drivers/net/bnxt/tf_core -Idrivers/net/bnxt/hcapi/cfa -I../drivers/net/bnxt/hcapi/cfa -Ilib/ethdev -I../lib/ethdev -I. -I../ -Iconfig -I../config -Ilib/eal/include -I../lib/eal/include -Ilib/eal/linux/include -I../lib/eal/linux/include -Ilib/eal/x86/include -I../lib/eal/x86/include -Ilib/eal/common -I../lib/eal/common -Ilib/eal -I../lib/eal -Ilib/kvargs -I../lib/kvargs -Ilib/telemetry/../metrics -I../lib/telemetry/../metrics -Ilib/telemetry -I../lib/telemetry -Ilib/net -I../lib/net -Ilib/mbuf -I../lib/mbuf -Ilib/mempool -I../lib/mempool -Ilib/ring -I../lib/ring -Ilib/meter -I../lib/meter -Idrivers/bus/pci -I../drivers/bus/pci -I../drivers/bus/pci/linux -Ilib/pci -I../lib/pci -Idrivers/bus/vdev -I../drivers/bus/vdev -fdiagnostics-color=3Dalways -pipe -D_FILE_OFFSET_BITS=3D64 -Wall -Winvalid-pch -Werror -O2 -g -include rte_config.h -Wextra -Wcast-qual -Wdeprecated -Wformat -Wformat-nonliteral -Wformat-security -Wmissing-declarations -Wmissing-prototypes -Wnested-externs -Wold-style-definition -Wpointer-arith -Wsign-compare -Wstrict-prototypes -Wundef -Wwrite-strings -Wno-missing-field-initializers -D_GNU_SOURCE -fPIC -march=3Dcorei7 -DALLOW_EXPERIMENTAL_API -DALLOW_INTERNAL_API -Wno-format-truncation -DRTE_LIBRTE_BNXT_TF -DSUPPORT_CFA_HW_ALL=3D1 -DCC_AVX2_SUPPORT -DRTE_LOG_DEFAULT_LOGTYPE=3Dpmd.net.bnxt -MD -MQ 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' -MF 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o= .d' -o 'drivers/a715181@@tmp_rte_net_bnxt@sta/net_bnxt_tf_core_tf_sram_mgr.c.o' -c ../drivers/net/bnxt/tf_core/tf_sram_mgr.c ../drivers/net/bnxt/tf_core/tf_sram_mgr.c: In function =E2=80=98tf_sram_mgr= _bind=E2=80=99: ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:418:19: error: =E2=80=98slice_lis= t=E2=80=99 may be used uninitialized in this function [-Werror=3Dmaybe-uninitialized] slice_list->tail =3D NULL; ^ ../drivers/net/bnxt/tf_core/tf_sram_mgr.c:574:29: note: =E2=80=98slice_list= =E2=80=99 was declared here struct tf_sram_slice_list *slice_list; ^~~~~~~~~~ cc1: all warnings being treated as errors > > Can you please check the build error? I will keep the set in next-net for= now, > but won't mark it to pull to main until issue is resolved. > If the fix is trivial, we can update it in the next-net (after issue reco= rded in > mail list), if it is not trivial may require a new version of the set. > > > btw, in git history 'TruFlow' is used, so I continue to use it, fyi. No problem. Thanks > > Thanks, > ferruh > --0000000000002ebe2805cc9b43a9--