From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 1E7BE5A62 for ; Fri, 26 Aug 2016 17:32:09 +0200 (CEST) Received: by mail-qk0-f175.google.com with SMTP id t7so79859160qkh.1 for ; Fri, 26 Aug 2016 08:32:09 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=CdJk+1qvFLc2cg5fIQmagDS23WnXws7BbJRhroAh/iM=; b=HXkiY+fAO3UxgbjptR1NJqcIrbthnUDZ3LoE3SO/rgZfJBFndQvEkxpx9YiO4uskyS 6tFN7a6Lf4rihJhs/Y8qLYbbzMjHXZ/UKyXPG8JDHLzq37ar8bqKpcYIXDJoFwY92kUY I8ZcEnl3TvDpKOGWfqykfju0izpulgQKKPz6I= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=CdJk+1qvFLc2cg5fIQmagDS23WnXws7BbJRhroAh/iM=; b=ijXPghvicsmkVjtqZCH/L++l6UJrKwKLvbLxh9572K9jnPz5diWMqqwaq4L8YNmPzg 97ls7gE7dCcLrSCYIQh9LrShTN0LBkcVZrZJb4vVasW8TT6XdhmcjfIPUoFGOf+BWNAy 26LznJwB2TfmaGD6VYUDSdpFtHK+TVblkRVy8Bc0GA9SR54C72rf2dOmRVkMmNLWLlJY Y+hexSdhh+y94M+QUmyTHb2TxUnaqsBpCC+zbZcUPBulPwi088HY4lf8eIPEeWMY55Hp 95fIhyY+3xoSAUe1EZz5L4K8baTLG5lL7lw4fsyA8CJQi1Qdnw11hKsLvd/egAveguZI WS3g== X-Gm-Message-State: AE9vXwOk3nJQ4EXEPDaCOdGY4SKlE0pNxAwGqNU9NmJI3F27ygaIxla6gCpgTvrjFrhg5uSPo4T7tjWoUs/zOQ5+ X-Received: by 10.55.148.193 with SMTP id w184mr3917487qkd.181.1472225528367; Fri, 26 Aug 2016 08:32:08 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.55.4 with HTTP; Fri, 26 Aug 2016 08:31:37 -0700 (PDT) In-Reply-To: <57C0004D.8030706@intel.com> References: <1472123147-22997-1-git-send-email-ferruh.yigit@intel.com> <57C0004D.8030706@intel.com> From: Ajit Khaparde Date: Fri, 26 Aug 2016 10:31:37 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hurd Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: make driver less verbose X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 26 Aug 2016 15:32:09 -0000 On Fri, Aug 26, 2016 at 3:39 AM, Ferruh Yigit wrote: > On 8/25/2016 8:03 PM, Ajit Khaparde wrote: > > > > > > On Thu, Aug 25, 2016 at 6:05 AM, Ferruh Yigit > > wrote: > > > > This line printed for every application even if driver is not used = at > > all. Removing the line to reduce the noise. > > > > Signed-off-by: Ferruh Yigit > > > > --- > > drivers/net/bnxt/bnxt_ethdev.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > > b/drivers/net/bnxt/bnxt_ethdev.c > > index 3795fac..37d0322 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1056,7 +1056,6 @@ static struct eth_driver bnxt_rte_pmd =3D { > > > > static int bnxt_rte_pmd_init(const char *name, const char *params > > __rte_unused) > > { > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", > name); > > > > How about changing the log level to DEBUG? > > > > - RTE_LOG(INFO, PMD, "bnxt_rte_pmd_init() called for %s\n", name)= ; > > + RTE_LOG(DEBUG, PMD, "bnxt_rte_pmd_init() called for %s\n", name= ); > > > > That should reduce the noise till the user explicitly changes the log > level. > > This will give similar result, this log is useless if you are not > debugging this driver, but debug log level can be enabled for many reason= s. > > Other drivers use PMD_INIT_FUNC_TRACE() macros, which requires > specifically enabled in config for that driver. > There are other messages to aid tracing and debugging elsewhere in the code= . So here goes.. Acked-by: Ajit Khaparde =E2=80=8B > > > > > Thanks > > =E2=80=8B > > > > > > rte_eth_driver_register(&bnxt_rte_pmd); > > return 0; > > } > > -- > > 2.7.4 > > > > > >