From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 9161145BC0; Tue, 29 Oct 2024 19:41:33 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 6867142ECA; Tue, 29 Oct 2024 19:41:33 +0100 (CET) Received: from mail-pl1-f170.google.com (mail-pl1-f170.google.com [209.85.214.170]) by mails.dpdk.org (Postfix) with ESMTP id 668F742E48 for ; Tue, 29 Oct 2024 19:41:32 +0100 (CET) Received: by mail-pl1-f170.google.com with SMTP id d9443c01a7336-20cb47387ceso54030525ad.1 for ; Tue, 29 Oct 2024 11:41:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1730227291; x=1730832091; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=vJdrmx1V1F3XSrTLVeCzvTM2n3d+3fkwFVTWRJizm0U=; b=Bgy8t4Y/MbL1C4XTkjzAM+9WImv1YzCWG4qhlM45brisYetC9xwdd69xcmQCVRog3l DjM8Edq2zSDVllSkqU5mivC0nC6hHLrmZ/L/CM2mAdsks6u/yUzGa4kPgd6tvP/AsOIW TksZeem19xfvi1+fUoZD1dREsEDM4gzD8f6eo= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1730227291; x=1730832091; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=vJdrmx1V1F3XSrTLVeCzvTM2n3d+3fkwFVTWRJizm0U=; b=cidChcKHRm6MMxTPA8LSCEO+xgLn971A22uL0iYAcpfezkRUUcHszHJuSx63feV5YO +dwF6tdcUWy0fjfIlZ7DOsrPlLPjvSUNjIsO4fpJTOUVZVMQhzgCHs1guNaumLJ2He3+ Zm4SBdjhuR/3UC0G8+zHDveyjEMIGUXkd2pXxkMDNkplHmukIOpuDFrgoX/uH9fBF4fy CHWRBZqW0Kr5coM0twG3EBoTfCAnwYejvuV1OeRodia+N1meDa44V96hJFNQSnQbC7IL Kej48FHf1Dm3rd2FN/bJdpIDSi6Vgh7fr+4QNRw8M4BkTatykOFbpQJ924PkbKgjMPpH LJbw== X-Forwarded-Encrypted: i=1; AJvYcCX/wTK3VTohhuXA+FPTfkAtRo9sVrc6GvOUJ/V/e/6gCchaWiQpAQvdUyrrGlQLAfjcOkU=@dpdk.org X-Gm-Message-State: AOJu0YzLfQfFjz8Eln38PWWKevbRpOF2jj7JdvocIuBw4GZOnYoKsV9+ LO8kdzF5cArImilmasEFqDbGX0YBku6j1E43vl3114LNrMbkwIPPkUdWidcHMAJQDFSNQPfDp67 aB8L+aYP3Ork24UtYQwul9uhX0sU91CdTH5js X-Google-Smtp-Source: AGHT+IHGy+40u8r6wxFB4scQ+RlWCBa4pyHFHhZRCrgWEJXpBxbfUu8V+yQf4rXoL2ZlkjkHnzesPxGB4ABPZh6gP3I= X-Received: by 2002:a17:902:d492:b0:20b:cae5:dec4 with SMTP id d9443c01a7336-210c68c2c35mr171642965ad.24.1730227291349; Tue, 29 Oct 2024 11:41:31 -0700 (PDT) MIME-Version: 1.0 References: <20240822153218.3782170-1-akozyrev@nvidia.com> In-Reply-To: From: Ajit Khaparde Date: Tue, 29 Oct 2024 11:41:14 -0700 Message-ID: Subject: Re: [PATCH] mbuf: add transport mode ESP packet type To: Ori Kam Cc: Alexander Kozyrev , "olivier.matz@6wind.com" , Nithin Dabilpuram , David Marchand , "dev@dpdk.org" , Dariusz Sosnowski , "NBU-Contact-Thomas Monjalon (EXTERNAL)" , Matan Azrad , "jerinj@marvell.com" , "rbhansali@marvell.com" , "ferruh.yigit@amd.com" Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000001a56620625a1ef76" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000001a56620625a1ef76 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Tue, Oct 29, 2024 at 7:48=E2=80=AFAM Ori Kam wrote: > > Hi Ajit, Nithin and Olivier > > > -----Original Message----- > > From: Ajit Khaparde > > Sent: Friday, October 25, 2024 2:33 AM > > > > On Thu, Oct 24, 2024 at 12:30=E2=80=AFPM Alexander Kozyrev > > wrote: > > > > > > >>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP > > support. > > > >Isn't this already taken care when mbuf->packet_type =3D > > > >(RTE_PTYPE_L4_UDP | RTE_PTYPE_TUNNEL_ESP) ? > > > > > > This is ambigous. And both UDP and ESP are L4 headers, > > > which can lead to the undefined behavior when we specify both of them= . > > > They are mutually exclusive in our hardware, for example. > > > That is why we have RTE_PTYPE_TUNNEL_MPLS_IN_GRE and > > > RTE_PTYPE_TUNNEL_MPLS_IN_UDP for MPLS. > > > We could go and indroduce RTE_PTYPE_TUNNEL_ESP_IN_UDP > > > to resolve the ambiguity, or have RTE_PTYPE_INNER_L4_ESP. > > > I choose the second variant to have a generic way for > > > ESP packets over any type of encapsulation. > > The choice sounds reasonable to me. > > > > > > > Let's understand the issue. > We have 3 possible options for the ESP: > 1. as L4 outer, in this case, the ESP replaces the UDP/TCP protocol > 2. as L4 inner, in this case, the ESP replaces the UDP/TCP inner protocol= . > 3. the ESP comes after UDP and is considered a tunnel. > > As far as I see the request is to give the application the ability to kno= w what is the packet type, so > Alexander's original patch fully fulfills this requirement. What am I mis= sing? > Do you have a different suggestion that matches the requirement? I was indicating that RTE_PTYPE_INNER_L4_ESP was a better approach. Just document the usage on how it can be used and I feel we should be ok. > > Best, > Ori > > --0000000000001a56620625a1ef76 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEICDWIHLNXzGxkuCh8EXC VlCaHPHzeJDzNNUkxp2OZPl/MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI0MTAyOTE4NDEzMVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBJ726uHZiBLjCNchQ1PLZHRsXq1ge/iVJnXjtC sxWXVjt+LQyh6VwrufU5Z9ciE4/W12nbFPmjygThuN0FUnooqE+elUynfnPcRl+7KYa19agscUvd /moMFg6zBNdinwOaT6BOm8uwJWXj73k8fcgy8Q6Hx8EcmXvxv//2Pal9JIj9Ss8lTlG0rfX9RyQJ LisrTDviif+2VkL8DurWg9wFHynweooIjf8IOXNEBxgLC6adyHEdm/zi/M6De+fGMLIn83w7qlPc b4ttX5Y+JbVfWWN6FeSiioSheJXxFq8k06kPKZTNdGHRRQfzu9u1bkauNKUsSQ0NfhdhI371CVo8 --0000000000001a56620625a1ef76--