From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: Alexander Kozyrev <akozyrev@nvidia.com>
Cc: Nithin Dabilpuram <nithind1988@gmail.com>,
David Marchand <david.marchand@redhat.com>,
"dev@dpdk.org" <dev@dpdk.org>,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Ori Kam <orika@nvidia.com>,
"olivier.matz@6wind.com" <olivier.matz@6wind.com>,
"NBU-Contact-Thomas Monjalon (EXTERNAL)" <thomas@monjalon.net>,
Matan Azrad <matan@nvidia.com>,
"jerinj@marvell.com" <jerinj@marvell.com>,
"rbhansali@marvell.com" <rbhansali@marvell.com>,
"ferruh.yigit@amd.com" <ferruh.yigit@amd.com>
Subject: Re: [PATCH] mbuf: add transport mode ESP packet type
Date: Thu, 24 Oct 2024 16:32:35 -0700 [thread overview]
Message-ID: <CACZ4nhtkpjE6-BdiY1SF0CGyyMuQwvsCd9iCzMXM3cWwEyVw8A@mail.gmail.com> (raw)
In-Reply-To: <DM4PR12MB75013750F24574ABE3638EC3AF4E2@DM4PR12MB7501.namprd12.prod.outlook.com>
[-- Attachment #1: Type: text/plain, Size: 828 bytes --]
On Thu, Oct 24, 2024 at 12:30 PM Alexander Kozyrev <akozyrev@nvidia.com> wrote:
>
> >>And we definitely need RTE_PTYPE_INNER_L4_ESP for ESP over UDP support.
> >Isn't this already taken care when mbuf->packet_type =
> >(RTE_PTYPE_L4_UDP | RTE_PTYPE_TUNNEL_ESP) ?
>
> This is ambigous. And both UDP and ESP are L4 headers,
> which can lead to the undefined behavior when we specify both of them.
> They are mutually exclusive in our hardware, for example.
> That is why we have RTE_PTYPE_TUNNEL_MPLS_IN_GRE and
> RTE_PTYPE_TUNNEL_MPLS_IN_UDP for MPLS.
> We could go and indroduce RTE_PTYPE_TUNNEL_ESP_IN_UDP
> to resolve the ambiguity, or have RTE_PTYPE_INNER_L4_ESP.
> I choose the second variant to have a generic way for
> ESP packets over any type of encapsulation.
The choice sounds reasonable to me.
>
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4218 bytes --]
prev parent reply other threads:[~2024-10-24 23:32 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-22 15:32 Alexander Kozyrev
2024-09-02 8:43 ` Nithin Dabilpuram
2024-09-04 21:09 ` Alexander Kozyrev
2024-10-15 14:40 ` Dariusz Sosnowski
2024-10-17 20:47 ` Thomas Monjalon
2024-10-18 13:44 ` David Marchand
2024-10-22 13:19 ` Alexander Kozyrev
2024-10-23 4:54 ` Nithin Dabilpuram
2024-10-24 19:30 ` Alexander Kozyrev
2024-10-24 23:32 ` Ajit Khaparde [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CACZ4nhtkpjE6-BdiY1SF0CGyyMuQwvsCd9iCzMXM3cWwEyVw8A@mail.gmail.com \
--to=ajit.khaparde@broadcom.com \
--cc=akozyrev@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=ferruh.yigit@amd.com \
--cc=jerinj@marvell.com \
--cc=matan@nvidia.com \
--cc=nithind1988@gmail.com \
--cc=olivier.matz@6wind.com \
--cc=orika@nvidia.com \
--cc=rbhansali@marvell.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).