From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 021F2A04DD; Fri, 20 Nov 2020 00:12:52 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id B501A4C90; Fri, 20 Nov 2020 00:12:49 +0100 (CET) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 6A251F3E for ; Fri, 20 Nov 2020 00:12:47 +0100 (CET) Received: by mail-oi1-f196.google.com with SMTP id q206so8271845oif.13 for ; Thu, 19 Nov 2020 15:12:47 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=ZAr1VmkTW6YuSDkbyWFRLRBL/odEO0w0pZb0oXv8i2c=; b=BuSDprCGjE8TMtJcFs628c1FkzLNIMZnbJlTq1E++q39m0yjUAeTZor7AYeR0tGQOy kH32loRreyaAlOiFMs78cDcafg2gZXlkxC4Z5W7mFqM9x3+Jo0F+ZAag287rYnLftPkZ wYM8jgfjq4IumjRCTMs8pT+zxrCbdyVqvWKCk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=ZAr1VmkTW6YuSDkbyWFRLRBL/odEO0w0pZb0oXv8i2c=; b=Ewn1kH8Uj5sB5g2B38bJWhcPNuEal/2VvZUbmnRzGHxxIBLdny+VFG0YSOEjHjf92B B/bzXNyVqXh1RNDVKzHapdH8/l6qXUtk5C7trBW07VizsVfTnNl4LI1OmqUQAkFM1sK5 WFpym3+wVcTAulzcz8so80SdZHsRBVoHV3XlpDJkQaMCGxUgdHzj3X0mSqpMKeE2PMql QNGFJEva9zur69KwVEkncrcHFDONbJiSsj2PieGAtFlxLK9IWH/ynEF7XVTILKwkXWBq 3gK5jUrVwfmSwvd1zh+VWkoMPD+AoN9ZlOh2Y/9YJZQfqTthBFWWcblhGIvbeX3VSpcq UiQg== X-Gm-Message-State: AOAM533ll2A6+cmQy6OpEkpJrqm4HutuXQzaFvhSmB3IYUP4HTNPZE6o pcbHOxOUJn3rBL0eqJSbqaHHs7l4uwE1C/+dVVJCeA== X-Google-Smtp-Source: ABdhPJzYy3QvZfueV405g3qmq9y8Jy4w5TVBY2X73pFmOqaijPyUbNVjszVJfOuVxDehb5YorHOapEGhCdVZw+fLAYU= X-Received: by 2002:aca:ecca:: with SMTP id k193mr4604151oih.27.1605827565413; Thu, 19 Nov 2020 15:12:45 -0800 (PST) MIME-Version: 1.0 References: <20201118181103.3865787-1-conor.walsh@intel.com> <20201119101700.3869583-1-conor.walsh@intel.com> <20201119101700.3869583-3-conor.walsh@intel.com> In-Reply-To: <20201119101700.3869583-3-conor.walsh@intel.com> From: Ajit Khaparde Date: Thu, 19 Nov 2020 15:12:29 -0800 Message-ID: To: Conor Walsh Cc: Bruce Richardson , Somnath Kotur , Luca Boccassi , Randy Schacher , Venkat Duvvuru , Michael Wildt , dpdk-dev , dpdk stable , linglix.chen@intel.com, Thomas Monjalon Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v3 2/2] net/bnxt: fix format characters for unsigned values X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Nov 19, 2020 at 2:17 AM Conor Walsh wrote: > > &device requires the %u format specifer not the %d specifier, as > &device is unsigned. > > Fixes: a46bbb57605b ("net/bnxt: update multi device design") > Cc: michael.wildt@broadcom.com > > Signed-off-by: Conor Walsh Acked-by: Ajit Khaparde > --- > drivers/net/bnxt/tf_core/tf_core.c | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff --git a/drivers/net/bnxt/tf_core/tf_core.c b/drivers/net/bnxt/tf_core/tf_core.c > index 0f49a00256..24d49096a7 100644 > --- a/drivers/net/bnxt/tf_core/tf_core.c > +++ b/drivers/net/bnxt/tf_core/tf_core.c > @@ -44,7 +44,7 @@ tf_open_session(struct tf *tfp, > > /* Verify control channel and build the beginning of session_id */ > rc = sscanf(parms->ctrl_chan_name, > - "%x:%x:%x.%d", > + "%x:%x:%x.%u", > &domain, > &bus, > &slot, > @@ -57,7 +57,7 @@ tf_open_session(struct tf *tfp, > > /* Check parsing of bus/slot/device */ > rc = sscanf(parms->ctrl_chan_name, > - "%x:%x.%d", > + "%x:%x.%u", > &bus, > &slot, > &device); > @@ -102,7 +102,7 @@ tf_attach_session(struct tf *tfp, > > /* Verify control channel */ > rc = sscanf(parms->ctrl_chan_name, > - "%x:%x:%x.%d", > + "%x:%x:%x.%u", > &domain, > &bus, > &slot, > @@ -115,7 +115,7 @@ tf_attach_session(struct tf *tfp, > > /* Verify 'attach' channel */ > rc = sscanf(parms->attach_chan_name, > - "%x:%x:%x.%d", > + "%x:%x:%x.%u", > &domain, > &bus, > &slot, > -- > 2.25.1 >