From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id AC6ADA00C5; Mon, 6 Jul 2020 01:55:18 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id DBADD1D738; Mon, 6 Jul 2020 01:55:17 +0200 (CEST) Received: from mail-ot1-f68.google.com (mail-ot1-f68.google.com [209.85.210.68]) by dpdk.org (Postfix) with ESMTP id 831BA1D737 for ; Mon, 6 Jul 2020 01:55:16 +0200 (CEST) Received: by mail-ot1-f68.google.com with SMTP id d4so30449507otk.2 for ; Sun, 05 Jul 2020 16:55:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=G4wRDsRjZbNOwV94Abw9+ZMyhZewLaKeClD89GPpmQo=; b=TjLVMAxWqgjTguq9iJnHtNJVegbiMzZu7viH4j8rvB+jZaiQvKhjEgtgQPE9EcLSU9 3FLL2VCUlm+8dP7FKbVRCp3bX/mU3JvF/JTfYijGfDrR6CTKwjTJ0bC5BsVhhp7+ruLh UpriDPwxFFIPG8EJF7QSjpMTrc9c7pWErMGYA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=G4wRDsRjZbNOwV94Abw9+ZMyhZewLaKeClD89GPpmQo=; b=nc/670HiXObnTmBSFaQ7Zb390JoGs0IAJlHpltfwGPzf+s7sW6ENHkvM0aTNRcXkpy 0ZngentAWUvDma0dYp+NeUNJNFOm/5cfzJAIerT8stArRCu+4gbDDkL225+aFwDyicWo btKt4Fx64s+CdGaeQmcOf9TqyAXvjIuborA/sHohykT5w+yNTRrIqdSb22fcKihZ1qn0 GdqvfPMBisaxaLNbsO/Gl6ww0qaDzlUqYG/4EnRE2dWmSdk+ClCMfL6wOsUkOAKjXV+/ Vrt6HpMaIW7UnfLKPnxd1Pk2xSIV+5QbuVP20GIPkOLxqg1XhEICnWFaHM8T1C5eCt9R kkFw== X-Gm-Message-State: AOAM530Y8hPajW7G9DuKhw6FnBTL/+NSaN7HVW2kJkbVuK6FOEG8UVK4 Perwc+/4PrBXVeXOeODP97gHHYXKd3DrJ9GI/zkEtQ== X-Google-Smtp-Source: ABdhPJyCxNWyfKEQV7ExtkgNLliy2Zwy52L05w4ulEwp62Rvg4bWZH/ZRXy9Nezwz6kcwJc/AhoBTBc3idhiRwFGFng= X-Received: by 2002:a9d:3b1:: with SMTP id f46mr36554261otf.154.1593993315578; Sun, 05 Jul 2020 16:55:15 -0700 (PDT) MIME-Version: 1.0 References: <1593102379-400132-1-git-send-email-jiaweiw@mellanox.com> <3958339.50gt9z0IZg@thomas> In-Reply-To: <3958339.50gt9z0IZg@thomas> From: Ajit Khaparde Date: Sun, 5 Jul 2020 16:54:58 -0700 Message-ID: To: Thomas Monjalon Cc: Jerin Jacob , Jiawei Wang , Ori Kam , Slava Ovsiienko , Matan Azrad , dpdk-dev , Raslan Darawsheh , ian.stokes@intel.com, fbl@redhat.com Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 1/7] ethdev: introduce sample action for rte flow X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Sun, Jul 5, 2020 at 1:55 AM Thomas Monjalon wrote: > 04/07/2020 16:44, Ajit Khaparde: > > On Thu, Jul 2, 2020 at 11:40 PM Jerin Jacob > wrote: > > > When adding overlapping API(rte_eth_mirror_rule_set()) in the same > > > library(ethdev). > > > Please depreciate the old API. > > > We should not have two separate paths for the same function in the > > > same ethdev library. It is pain for app and driver developers. > > > > > > With the above deprecation notice, > > > Acked-by: Jerin Jacob > > > > > I am fine with the proposed RTE_FLOW_ACTION_TYPE_SAMPLE. But.. > > > > When rte_eth_mirror_rule_set() is deprecated, are we going to add > > RTE_FLOW_ACTION_TYPE_MIRROR for full fledged mirror action? > > Or we are proposing to use RTE_FLOW_ACTION_TYPE_SAMPLE with > > ratio of 1 to mirror all packets, thereby doing away with the need for > > a separate RTE_FLOW_ACTION_TYPE_MIRROR? > > The idea is to use RTE_FLOW_ACTION_TYPE_SAMPLE with ratio=1 for mirroring. > Thanks for clarifying.