From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E2C53A0350; Sat, 23 May 2020 05:52:52 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 358571D919; Sat, 23 May 2020 05:52:52 +0200 (CEST) Received: from mail-ot1-f65.google.com (mail-ot1-f65.google.com [209.85.210.65]) by dpdk.org (Postfix) with ESMTP id 869A11D8FB for ; Sat, 23 May 2020 05:52:51 +0200 (CEST) Received: by mail-ot1-f65.google.com with SMTP id z3so9808939otp.9 for ; Fri, 22 May 2020 20:52:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=LPoF6dKnWZMXx4yI3hb2cMn7fJ82WawJfqITSGj8d70=; b=HVFrfrSUXX03ZW5WGfmMvAJac37FxhQo8Eljh0hr1mmM1+EL2/VxkhQlaI1ELu3fl5 0+do+2soF2g7jTk5qZf2VdZ3hhgZcd4G6BKqfXfUMc4gn3wr85bj8T+4fDMFduaoUITF WXXfNKh07suvQOOXdzlx9rj+O8m2tsckvSDTk= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=LPoF6dKnWZMXx4yI3hb2cMn7fJ82WawJfqITSGj8d70=; b=oQD6jo36A12r/ZIf59Oo+h4C2A6M/zsS1M8Qsut4oQLZTr2SZwafJJ5HVoP+t8cOUi Z1uXEAUrCMq4hPJrxCvEk2RLFy0sjqqioNrArubn2BTMWmQzQEC07DYJEGhKlfsa4SMW L0+nM/JFi12F3L/DYgIlfOr5tGiubboYmpYeoihyx1L22Y3wMZ0WN7fHxqY7mVY0mrSb xB7BnUbo3TEHxr/RFD6cXma5pYgEGU/R26tEySGQEnBMqZfGfhQ40a03rdOuxEh2BLVV htzDy3Yr4PATP460yAzwsXUaqQ9k8DhSQaCYerrTvsm9NjaLSm25YaAsfO4Fs/SzTdjK +OWg== X-Gm-Message-State: AOAM53227IMtgIrPxYrb/P0aSiJ0vYw8xnEWim6pjbdaHs28KgIrfWWW 4xbnVntZXFFgrytMRtaJc5HwvizJzEU001JAEz6JDw== X-Google-Smtp-Source: ABdhPJxrJ81t6WEkUV98ijUOBpp6+241VtTCg790GJH9q4Hg8QYol3Ky38t7n56jZWGcJZ4nV6Mcgt2/zRQg3QwNMRE= X-Received: by 2002:a05:6830:61b:: with SMTP id w27mr10734048oti.154.1590205970535; Fri, 22 May 2020 20:52:50 -0700 (PDT) MIME-Version: 1.0 References: <1590191701-8420-1-git-send-email-michael.baucom@broadcom.com> In-Reply-To: <1590191701-8420-1-git-send-email-michael.baucom@broadcom.com> From: Ajit Khaparde Date: Fri, 22 May 2020 20:52:34 -0700 Message-ID: To: Mike Baucom Cc: dpdk-dev Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: allow the mark to use a cfa code of zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, May 22, 2020 at 4:55 PM Mike Baucom wrote: > The mark code was too restrictive by disallowing a cfa_code of zero. > This code loosens the requirement and allows zero. > > Fixes: b87abb2e55cb ("net/bnxt: support marking packet") > > Signed-off-by: Mike Baucom > Reviewed-by: Kishore Padmanabha > Applied to dpdk-next-net-brcm with updated commit headline [1]. [1] net/bnxt: fix mark action > --- > drivers/net/bnxt/bnxt_rxr.c | 20 +++++++++----------- > 1 file changed, 9 insertions(+), 11 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_rxr.c b/drivers/net/bnxt/bnxt_rxr.c > index ee1acb1..91ff729 100644 > --- a/drivers/net/bnxt/bnxt_rxr.c > +++ b/drivers/net/bnxt/bnxt_rxr.c > @@ -465,17 +465,15 @@ static inline struct rte_mbuf *bnxt_tpa_end( > break; > } > > - if (cfa_code) { > - rc = ulp_mark_db_mark_get(bp->ulp_ctx, gfid, > - cfa_code, &mark_id); > - if (!rc) { > - /* Got the mark, write it to the mbuf and return */ > - mbuf->hash.fdir.hi = mark_id; > - mbuf->udata64 = (cfa_code & 0xffffffffull) << 32; > - mbuf->hash.fdir.id = rxcmp1->cfa_code; > - mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID; > - return; > - } > + rc = ulp_mark_db_mark_get(bp->ulp_ctx, gfid, > + cfa_code, &mark_id); > + if (!rc) { > + /* Got the mark, write it to the mbuf and return */ > + mbuf->hash.fdir.hi = mark_id; > + mbuf->udata64 = (cfa_code & 0xffffffffull) << 32; > + mbuf->hash.fdir.id = rxcmp1->cfa_code; > + mbuf->ol_flags |= PKT_RX_FDIR | PKT_RX_FDIR_ID; > + return; > } > > skip_mark: > -- > 1.9.1 > >