From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 269D4A0352;
	Wed,  6 May 2020 04:50:04 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 766051D67A;
	Wed,  6 May 2020 04:50:03 +0200 (CEST)
Received: from mail-ot1-f67.google.com (mail-ot1-f67.google.com
 [209.85.210.67]) by dpdk.org (Postfix) with ESMTP id 66B8E1D66B
 for <dev@dpdk.org>; Wed,  6 May 2020 04:50:01 +0200 (CEST)
Received: by mail-ot1-f67.google.com with SMTP id c3so207366otp.8
 for <dev@dpdk.org>; Tue, 05 May 2020 19:50:01 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google;
 h=mime-version:references:in-reply-to:from:date:message-id:subject:to
 :cc; bh=JFhrYAYXjbbJQbYWOjHoRgUNyvKNII2Fuyg4/wug8F8=;
 b=YHaAPhRflRNumXu3O3AsIL6BudYkASE17FT0E/Ed6MEjdABQIJotV9DVIyhsSTGtMC
 PkUmFMy55PHgRlh9+AGCkn6NWbY1XxvajAfXPxbxvcAMBW5D0h4/Qv2QnwfQ+yPJVNIO
 UY8imVHESPiIjGB+ATYf8oV7K436S9+LZQdeI=
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:mime-version:references:in-reply-to:from:date
 :message-id:subject:to:cc;
 bh=JFhrYAYXjbbJQbYWOjHoRgUNyvKNII2Fuyg4/wug8F8=;
 b=csUUCPSO/r0u5qnxeTMwMR9GL16sxTE3h+rBoHZ8yJcWW2E0V1FBbKVzlvU98z8ISx
 /5I7FuiihpwG3QHgIRFjLrzVueEFWmO6kzYQwLzgPTTj6LDG4QjEJohRhfABhtE5Ktq1
 z6+Kw83eA4V0I86RAZrvCXy210atFkBZ44SyYStAHT7bK7dB0d6+mls9sURZoJCsDHVW
 GSGZ/93/k+vT9qhBtNiH6ur0M5jSOxKZxI26lEYLpl0UEvgLwVRopPBvd2Etr2xXX88w
 EXBkSIFny8y6g6QMO4TOUu0E2VuE3aV59EG375l2anEvZjrClUeesfLCGZyf6wFOPKVU
 RFdA==
X-Gm-Message-State: AGi0PubmGt1Bk6krThcEmfwVKRUFh8Xl91+fxuUOaNnuO2Q3KPBWYqta
 3SgNE08IKEjUTAXZoxIEYM2qcut9TC+fE7zJFSIoeQ==
X-Google-Smtp-Source: APiQypIJvnQsKLK5EhNcVYC4N+XywVKSJoaAWgrus/j2ajdkvbakOF/4d4jFTrM+qcfpRJNWYPhUCFMRzoAmJBvk5E4=
X-Received: by 2002:a05:6830:1613:: with SMTP id
 g19mr4359065otr.95.1588733400466; 
 Tue, 05 May 2020 19:50:00 -0700 (PDT)
MIME-Version: 1.0
References: <20200430093249.6772-2-wisamm@mellanox.com>
 <20200430103341.1845-1-wisamm@mellanox.com>
 <20200430103341.1845-2-wisamm@mellanox.com>
 <c90cbd60-84d8-2952-899e-2aa910708b22@solarflare.com>
In-Reply-To: <c90cbd60-84d8-2952-899e-2aa910708b22@solarflare.com>
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
Date: Tue, 5 May 2020 19:49:44 -0700
Message-ID: <CACZ4nhu5JmshRi=qseNxV43+x9kD5k2JD2WLefTzytLyXU2Mcw@mail.gmail.com>
To: Andrew Rybchenko <arybchenko@solarflare.com>
Cc: Wisam Jaddo <wisamm@mellanox.com>, dpdk-dev <dev@dpdk.org>,
 jackmin@mellanox.com, 
 Thomas Monjalon <thomas@monjalon.net>, Jerin Jacob <jerinjacobk@gmail.com>,
 gerlitz.or@gmail.com, l.yan@epfl.ch
Content-Type: text/plain; charset="UTF-8"
X-Content-Filtered-By: Mailman/MimeDel 2.1.15
Subject: Re: [dpdk-dev] [PATCH v4 1/5] app/test-flow-perf: add flow
 performance skeleton
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

::snip::


> > +             },
> > +             .rx_adv_conf = {
> > +                     .rss_conf.rss_hf =
> > +                                     ETH_RSS_IP  |
> > +                                     ETH_RSS_UDP |
>
> May be it is better to remove ETH_RSS_UDP by default,
> since it is less common that RSS for TCP because of
> possible fragmentation and packets from the same
> stream delivered to different CPU cores.
>
If we want to enable RSS on L4 headers, then UDP and TCP should be fine.
Its an example app anyway?
Otherwise we can just stick with L3 hash like some of the other examples.
::snip::