From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 4D6EBA0C41; Thu, 18 Nov 2021 05:55:41 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0FEC440687; Thu, 18 Nov 2021 05:55:41 +0100 (CET) Received: from mail-il1-f180.google.com (mail-il1-f180.google.com [209.85.166.180]) by mails.dpdk.org (Postfix) with ESMTP id C15E640395 for ; Thu, 18 Nov 2021 05:55:39 +0100 (CET) Received: by mail-il1-f180.google.com with SMTP id w15so5220942ill.2 for ; Wed, 17 Nov 2021 20:55:39 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=b52TB+gBG0KaCG/wG2/K145ZjdfpuTxp4Q8XB+9NHGM=; b=MEkg0WnIiReZ2G+8jDVe1IA+6cJPLoZyw76XpcyTAPF7x1yTEobXhOTIDXlDPeJOW1 w+60NBEfmwdITgUVaJnKgg06A15cpMaeHfoKnM4yfwPMd1YkCJ1t/m521BZgmVj8yHPJ IQ8LbAf7yJqn0K91oD1/740LtTGsY9/BqWLXA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=b52TB+gBG0KaCG/wG2/K145ZjdfpuTxp4Q8XB+9NHGM=; b=0++zMu1UUrsJQLlgPyC0mzNdNJ76iuVnPRY7nCX+Csuy8tXZHfdjQH5yWbrKTIrmDf np4KiwyMRGRhaxqImAERxuYqbiB4meYV6wJTW1zwC1951KPeAS3eO0RlRMUkwh6rTJJH rq+Uvl/Fr2uQGTnV1XBRyQK5OtVuoPt5saMp81ZLOLRhxSR3Q2xNclHH9AvKQ0Jfjh8I ttDpYtOi7noGHV0VFs5hwh4VFqiv+JZbb0c7uJ/cOD9XDdva5fo4EV9RYslfvwFJFpKu yZAPsFywIPWFQs+BEtS5EJotPJtfGtTrRId6p3rpuPy7Qab4BgGq/S9vCwxg62g8bBq1 I76w== X-Gm-Message-State: AOAM530I5d0cIXAJZ72PQtAkMO4re962fbAQR5Jno7f0+tudDPyaslex oa1Migqow4NLxSsRHmKWHUJmLADYTkvfaYSRYURTHQ== X-Google-Smtp-Source: ABdhPJxDbgOaKC0xF6Icn/wkJasVR8pkGFysn/bUNVkhFoS65tMzy2fUO4JA+ac7cXTmA/z9nv9gxunHCkcX5xhYfhY= X-Received: by 2002:a92:d5c1:: with SMTP id d1mr14329716ilq.311.1637211339155; Wed, 17 Nov 2021 20:55:39 -0800 (PST) MIME-Version: 1.0 References: <20211118040439.24583-1-somnath.kotur@broadcom.com> In-Reply-To: <20211118040439.24583-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Wed, 17 Nov 2021 20:55:23 -0800 Message-ID: Subject: Re: [PATCH] net/bnxt: fix autoneg on PAM4 links To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , Charlie Brtee , dpdk stable Content-Type: text/plain; charset="UTF-8" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On Wed, Nov 17, 2021 at 8:11 PM Somnath Kotur wrote: > > If autonegotiation was enabled, driver was not passing the > 'auto_pam4_link_speeds' obtained during init and stored in bp->link_info > to bnxt_hwrm_port_phy_cfg(). This would result in an incorrect setting > being passed to the HW during PHY configuration. This in turn, would > result in invalid settings being retrieved and configured in subsequent > application loads resulting in launch failures. > > Fixes: c23f9ded0391 ("net/bnxt: support 200G PAM4 link") > > Reported-by: Charlie Brtee > Reviewed-by: Ajit Khaparde > Signed-off-by: Somnath Kotur Merged in dpdk-next-net-brcm. Fixed up typo in Charle's name. Added Bugzilla ID and stable@dpdk.org Thanks Ajit > --- > drivers/net/bnxt/bnxt_hwrm.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.c > index 67ed807dad..df75047e2d 100644 > --- a/drivers/net/bnxt/bnxt_hwrm.c > +++ b/drivers/net/bnxt/bnxt_hwrm.c > @@ -3247,6 +3247,8 @@ int bnxt_set_hwrm_link_config(struct bnxt *bp, bool link_up) > link_req.auto_link_speed_mask = > bnxt_parse_eth_link_speed_mask(bp, > dev_conf->link_speeds); > + link_req.auto_pam4_link_speeds = > + bp->link_info->auto_pam4_link_speeds; > } else { > if (bp->link_info->phy_type == > HWRM_PORT_PHY_QCFG_OUTPUT_PHY_TYPE_BASET || > -- > 2.28.0.497.g54e85e7 >