From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f180.google.com (mail-qt0-f180.google.com [209.85.216.180]) by dpdk.org (Postfix) with ESMTP id E50F45699 for ; Wed, 31 May 2017 16:28:11 +0200 (CEST) Received: by mail-qt0-f180.google.com with SMTP id v27so13324675qtg.2 for ; Wed, 31 May 2017 07:28:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=wAvHKj0HCH8bd3twqqm18CbNUiRwldtAfWz2cmyz8YQ=; b=S0T91QQSb9IhmapnBvIyrgejgLDI3ELHMDgR9YhPdYFO5o09O1ZehTaps/S8xRsViY dL6reEpJ1wxdjsw/6A4oU5y6PQj+BB9WaWNDyemJzqQzdb0eEQt3FP4nN10HSOAL5ppa 8/4iKK13SAij49sWNFPL2frKiags/1fkaTUBg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=wAvHKj0HCH8bd3twqqm18CbNUiRwldtAfWz2cmyz8YQ=; b=Niwvq/2KcRE1gPTOzhYMmgdvMdDEkTrfk4Xz6g3E5z7wvI8n39D5e7TA0AQ3vp7pPX /H6+Icrwxob1YduNiWNJGpfqpI9YWkSY3SBQEHLBBGINFhBcM+TfLXyC17tzn1DY5BTn GUA71Q/PzpHcAzc+/VZv+WE9IPShyNBbPx+ZY/efs5Z1MTZ9Rcnh9SeA3lxOTwhHs6Vf 3Q6K/x4sCZ/N0KQKK1tXCv15TqbeOBxe6p2P0bIsfAND+YS7R0IbJpVzuhKU3VQHvbNF Ciho1M8C9gJNsPe8QDEORrb2Bcpcwn2YfkjpIxeQ2u4ZhuB8Vx5C8SleCGfx1FpSHGzR tU9Q== X-Gm-Message-State: AODbwcAT89ZDAYxET/9RxxqTYnbM084f6UKj82+jw5tuSXuHxMRgQqUC DYAESUQxMzmubwYAmOpW5FOkZVy4W0eR X-Received: by 10.237.53.149 with SMTP id c21mr32817701qte.191.1496240891165; Wed, 31 May 2017 07:28:11 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.52.165 with HTTP; Wed, 31 May 2017 07:27:30 -0700 (PDT) In-Reply-To: <759bde90-b1e2-1a69-f98e-a02e164608c8@intel.com> References: <20170526183941.80678-1-ajit.khaparde@broadcom.com> <20170526183941.80678-21-ajit.khaparde@broadcom.com> <3d568535-8eda-d79f-bbe5-43f9f1071184@intel.com> <759bde90-b1e2-1a69-f98e-a02e164608c8@intel.com> From: Ajit Khaparde Date: Wed, 31 May 2017 09:27:30 -0500 Message-ID: To: Ferruh Yigit Cc: dev@dpdk.org, Stephen Hurd Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH v2 20/25] bnxt: add support to get and clear VF specific stats X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 31 May 2017 14:28:12 -0000 On Wed, May 31, 2017 at 4:57 AM, Ferruh Yigit wrote: > On 5/31/2017 3:12 AM, Ajit Khaparde wrote: > > > > On Mon, May 29, 2017 at 12:43 PM, Ferruh Yigit > > wrote: > > > > > +int rte_pmd_bnxt_get_tx_drop_count(uint8_t port, uint64_t *count= ) > > > +{ > > > + struct rte_eth_dev *dev; > > > + struct rte_eth_dev_info dev_info; > > > + struct bnxt *bp; > > > + > > > + dev =3D &rte_eth_devices[port]; > > > + rte_eth_dev_info_get(port, &dev_info); > > > + bp =3D (struct bnxt *)dev->data->dev_private; > > > + > > > + return bnxt_hwrm_func_qstats_tx_drop(bp, 0xffff, count); > > > +} > > > > This function is not to get VF stats from PF. As far as I can see > this > > just gets queue stats, does this really needs to be PMD specific AP= I, > > isn't this something generic? > > > > > > =E2=80=8BYes. That is right. It returns a count of number of packets wh= ich were > > not transmitted > > because it did not pass the MAC/VLAN spoof check. > > It does not > > necessarily mean "failure to transmit" and so I don't think it is right > > to map it to oerrors. > > So in the current form I don't see a way to make a generic function out > > of it.=E2=80=8B > > I see, this is implemented because there is no place in basic stats to > put tx_drop_pkts. > > Can xstats be used to get this value? Can new .xstats_get_by_id help here= ? > =E2=80=8BMay be we could. Do we have time for that?=E2=80=8B