From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 26E0C436E5; Wed, 13 Dec 2023 20:09:24 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C9096402D7; Wed, 13 Dec 2023 20:09:23 +0100 (CET) Received: from mail-pg1-f179.google.com (mail-pg1-f179.google.com [209.85.215.179]) by mails.dpdk.org (Postfix) with ESMTP id D4D0C402C3 for ; Wed, 13 Dec 2023 20:09:22 +0100 (CET) Received: by mail-pg1-f179.google.com with SMTP id 41be03b00d2f7-5ca0b968d8dso1708520a12.1 for ; Wed, 13 Dec 2023 11:09:22 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1702494562; x=1703099362; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=eNFjYX/xGiC5C+CdBWt+VLhMUo891EBRk35TuqR+Xgk=; b=Lhp5aiRVC7Ga2hv/ItZyavEun1sdpcV/Mpttj56PwsAT7wUc2jyCc0PjBhfIdCDKvv 4KWglb6pE9f2NUqTeOYqruuiY8EBcpFrMCtJuzVJQapKADvZ7hIX9GO5Ps4i+hT7Xy6R 7L1LPfJMPPmJ7BTotbp3WLYubp7skiA+0eeZI= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702494562; x=1703099362; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=eNFjYX/xGiC5C+CdBWt+VLhMUo891EBRk35TuqR+Xgk=; b=fm035YGX0aIclxNq+4QoW6iyjI/vemSsyElr/VxBBjlDDf8ZX0U3vQ8bkQBOPgoKhO kJrRKEWT7Vra+H2WRFP9y4XdCUlgZlGQIryf5CzIJiyQyMuFwXodR9sb/Z57umVHMsg6 ab5K8KxtgHKCbzMWYMUReWcBDIi9tDbAcj+lRJxHF5zjQX51xoePLnrENRlae85sDZT8 VBwLPrSCrgMG8SzkTvaIlH6DVXEE4HJogfxnV2mJbOJa7HYWavP0IHurWhJu+BWn8rlL cJZKIZPR5Di5nmJltJulf9CqwzMIKKWSm9GNaWbGN2XHlc5ayPae2WrNVSyBElx1yAue rmcw== X-Gm-Message-State: AOJu0YwQkWDZG4jqRjawJ1TFMH+0ycmPuoD/Xqm7qRMNEDIm7uQkwwoQ c/uYemcMF6m7oQv39l+zbUlEjfmxFlDYVA8e+7lF5A== X-Google-Smtp-Source: AGHT+IG24tOjVjodeb67ruUFKAYYzPzx1k7gg6A5lbo60Z2teNm/XD4BaKqeFm9SGgDV/FQcKmwimPseZY1nPv+5HFY= X-Received: by 2002:a05:6a20:938c:b0:18f:97c:5b88 with SMTP id x12-20020a056a20938c00b0018f097c5b88mr4218069pzh.86.1702494561898; Wed, 13 Dec 2023 11:09:21 -0800 (PST) MIME-Version: 1.0 References: <20231210012455.20229-1-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Wed, 13 Dec 2023 11:09:04 -0800 Message-ID: Subject: Re: [PATCH v2 00/14] support new 5760X P7 devices To: David Marchand Cc: dev@dpdk.org, Ferruh Yigit , Thomas Monjalon Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000009e9e38060c68e7a9" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000009e9e38060c68e7a9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Wed, Dec 13, 2023 at 6:49=E2=80=AFAM Ajit Khaparde wrote: > > On Tue, Dec 12, 2023 at 11:57=E2=80=AFPM David Marchand > wrote: > > > > On Wed, Dec 13, 2023 at 6:34=E2=80=AFAM Ajit Khaparde > > wrote: > > > > > > On Sat, Dec 9, 2023 at 5:31=E2=80=AFPM Ajit Khaparde wrote: > > > > > > > > While some of the patches refactor and improve existing code, > > > > this series adds support for the new 5760X P7 device family. > > > > Follow-on patches will incrementally add more functionality. > > > > > > > > v1->v2: > > > > - Fixed unused variable error > > > > - Fixed some spellings > > > > - Code refactoring and fixes in backing store v2 > > > > > > Patchset applied to dpdk-next-net-brcm for-next-net branch. > > > Thanks > > > > In case you did not read my mail about mirroring in github, this > > for-next-net branch has been mirrored (cool). > > And now GHA runs on this branch, but it failed (not cool). > > https://github.com/DPDK/dpdk/actions/runs/7191182897/job/19585464602 > Hmm. It tested ok on my setup. Let me take a look. > > > > > > > Looking at the error, I think you applied the v2 (series 30499) and > > not the v3 (series 30511) of this work. > Let me check. I spent some time trying to dig this up. It turns out that I had not updated my staging branch after I mailed the v3 patchset. And that's how v2 ended up getting merged. Thanks for catching it and pointing it out. I pushed the v3 to the dpdk-next-net-brcm for-next-net branch and the GHA completed successfully. https://github.com/DPDK/dpdk/actions/runs/7199579031 Please pick this version from the subtree. ---- While some of the patches refactor and improve existing code, this series adds support for the new 5760X P7 device family. Follow-on patches will incrementally add more functionality. v1->v2: - Fixed unused variable error - Fixed some spellings - Code refactoring and fixes in backing store v2 v2->v3: - Addressed review comments - Fixed unused arg error > > > > > $ git diff ovsrobot/series_30499..ovsrobot/series_30511 > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_eth= dev.c > > index 8aca3c6fba..75e968394f 100644 > > --- a/drivers/net/bnxt/bnxt_ethdev.c > > +++ b/drivers/net/bnxt/bnxt_ethdev.c > > @@ -1312,7 +1312,7 @@ bnxt_receive_function(struct rte_eth_dev *eth_dev= ) > > } > > > > static eth_tx_burst_t > > -bnxt_transmit_function(struct rte_eth_dev *eth_dev) > > +bnxt_transmit_function(__rte_unused struct rte_eth_dev *eth_dev) > > { > > #if defined(RTE_ARCH_X86) || defined(RTE_ARCH_ARM64) > > uint64_t offloads =3D eth_dev->data->dev_conf.txmode.offloads; > > @@ -2929,7 +2929,7 @@ bnxt_dev_set_mc_addr_list_op(struct rte_eth_dev *= eth_dev, > > bp->nb_mc_addr =3D nb_mc_addr; > > > > if (nb_mc_addr > BNXT_MAX_MC_ADDRS) { > > - PMD_DRV_LOG(INFO, "Number of Mcast MACs added (%d) > > exceeded Max supported (%d)\n", > > + PMD_DRV_LOG(INFO, "Number of Mcast MACs added (%u) > > exceeded Max supported (%u)\n", > > nb_mc_addr, BNXT_MAX_MC_ADDRS); > > PMD_DRV_LOG(INFO, "Turning on Mcast promiscuous mode\n"= ); > > vnic->flags |=3D BNXT_VNIC_INFO_ALLMULTI; > > diff --git a/drivers/net/bnxt/bnxt_hwrm.c b/drivers/net/bnxt/bnxt_hwrm.= c > > index c6d774bd14..e56f7693af 100644 > > --- a/drivers/net/bnxt/bnxt_hwrm.c > > +++ b/drivers/net/bnxt/bnxt_hwrm.c > > @@ -5653,8 +5653,6 @@ int > > bnxt_hwrm_func_backing_store_types_count(struct bnxt *bp) > > req.type =3D rte_cpu_to_le_16(type); > > rc =3D bnxt_hwrm_send_message(bp, &req, sizeof(req), > > BNXT_USE_CHIMP_MB); > > HWRM_CHECK_RESULT(); > > - if (rc !=3D 0) > > - return rc; > > > > flags =3D rte_le_to_cpu_32(resp->flags); > > type =3D rte_le_to_cpu_16(resp->next_valid_type); > > > > > > -- > > David Marchand > > --0000000000009e9e38060c68e7a9 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIGZ/QQKZDxufHnYbPkEQ GWFiXJng/Nno6ruT1MAeaU76MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIzMTIxMzE5MDkyMlowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQB5JhgSsRzynFSVRlEChDm2hm4KKDRPzS5bFPaf pqnXfWH9P9VGR/dN7k0QgHxEzS+fNgENkLnAvHWpAEvn0H6PdvT1cgOxMeXZl1B46VHuEacWBFAp PVRtyfoO+eJQbXH9gLPloBlteVAdxrPL9POqEOUX/euS9q/u6S3d2MO4tGKk+sC0uwa37lwxWlgS F/y8uQ/G2/cRjyqpukhhd35WACcj2X9nL4TII0uY7Vw86CpkJP+djfVGCeaokSMMX+m5JYdzuy/T s9WB+DZJSDA8c2nsyXEjFd1BkwQvC03w2ldLpe+7OxRaMoEM6N2QrwQMBUnsK/bFvWKUtC8AAIYs --0000000000009e9e38060c68e7a9--