From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9300A04B5; Sun, 1 Nov 2020 04:19:49 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 8D4019AEB; Sun, 1 Nov 2020 04:19:48 +0100 (CET) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 0D65072EE for ; Sun, 1 Nov 2020 04:19:45 +0100 (CET) Received: by mail-oi1-f196.google.com with SMTP id m13so1950945oih.8 for ; Sat, 31 Oct 2020 20:19:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0HDIL6l/yB0k649l/meSyYgFln3c40oxa/fQq2o+PKE=; b=CRkNH2cgHvzRMFdRCxUjo/WbTcMER6tChN91IYQK/1IIxWvqRe/le/1K295J/dr+Kx JsJ8IeYCgVjfQ4vkEe/YeSGdEjOikiHqABUWKgCiSG0z0J2lsGtSm42FD0QY0JSy98/o odXz2j4FIftZH+8dxpP37wedmhpDxCDwEyRAw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0HDIL6l/yB0k649l/meSyYgFln3c40oxa/fQq2o+PKE=; b=Yh8QJ7JW1bCfUyrsmNrVAy85pZx/me9b74Rw+PS1lKTjF0/xxr2TKACROPQcsd89p3 9ZqzvWw9vyTQ6WC07kDkRBuBqTR89wW7Aztql6643sVryqcCL9x4msI7KIpztOrHmbT4 HtLDdxermj+MVnn5WTRASPjcKtCa5PggXTCfBymXG/xflEujRFFyLMXyy896vdRjVm5d zVIZMUQNpIXqbOeZk0OVVpa8J682Iy8SnYp1JSYdEKZ6rY/HlgGMbqzQJDbUAUVKOBWk 2iQcda/Mhiq0lOcIGLIMiSjLbVV9DvuWPn+1o93BPwY92kT7+CMW1C79i55YJtj+UF4o Uyow== X-Gm-Message-State: AOAM5309sh/MRp3Rz9c/ZJBH7LYg0/t6GpGIX2NX73MNnXd8itc6pC0S pzvilPTx0gQ23EKyAOy8u3VxTJLWCIQ6tOhHBX0xwA== X-Google-Smtp-Source: ABdhPJxOvlgcIG80PzrozI/37dod6cC02dbX3K0rGTDLVR8xNtLQF230/96JmRn8Vum61zGpIIx6y6hz0tktGWOy4/I= X-Received: by 2002:aca:38c6:: with SMTP id f189mr6439984oia.27.1604200785133; Sat, 31 Oct 2020 20:19:45 -0700 (PDT) MIME-Version: 1.0 References: <20201030070304.22318-1-somnath.kotur@broadcom.com> <20201030070304.22318-2-somnath.kotur@broadcom.com> In-Reply-To: <20201030070304.22318-2-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Sat, 31 Oct 2020 20:19:28 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , dpdk stable , Kalesh Anakkur Purayil Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 2/2] net/bnxt: pass dev args by reference X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, Oct 30, 2020 at 12:11 AM Somnath Kotur wrote: > > Pass 'eth_da' pointer instead of pass by value to > bnxt_rep_port_probe() > > Coverity issue: 360841 > > Fixes: 322bd6e70272 ("net/bnxt: add port representor infrastructure") > Cc: stable@dpdk.org > > Signed-off-by: Somnath Kotur > Reviewed-by: Kalesh Anakkur Purayil Patch applied to dpdk-next-net-brcm. > --- > drivers/net/bnxt/bnxt_ethdev.c | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 31e94f2..6a77e57 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -6288,7 +6288,7 @@ static int bnxt_init_rep_info(struct bnxt *bp) > } > > static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, > - struct rte_eth_devargs eth_da, > + struct rte_eth_devargs *eth_da, > struct rte_eth_dev *backing_eth_dev, > const char *dev_args) > { > @@ -6299,7 +6299,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, > int i, ret = 0; > struct rte_kvargs *kvlist = NULL; > > - num_rep = eth_da.nb_representor_ports; > + num_rep = eth_da->nb_representor_ports; > if (num_rep > BNXT_MAX_VF_REPS) { > PMD_DRV_LOG(ERR, "nb_representor_ports = %d > %d MAX VF REPS\n", > num_rep, BNXT_MAX_VF_REPS); > @@ -6329,7 +6329,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, > > for (i = 0; i < num_rep; i++) { > struct bnxt_representor representor = { > - .vf_id = eth_da.representor_ports[i], > + .vf_id = eth_da->representor_ports[i], > .switch_domain_id = backing_bp->switch_domain_id, > .parent_dev = backing_eth_dev > }; > @@ -6342,7 +6342,7 @@ static int bnxt_rep_port_probe(struct rte_pci_device *pci_dev, > > /* representor port net_bdf_port */ > snprintf(name, sizeof(name), "net_%s_representor_%d", > - pci_dev->device.name, eth_da.representor_ports[i]); > + pci_dev->device.name, eth_da->representor_ports[i]); > > kvlist = rte_kvargs_parse(dev_args, bnxt_dev_args); > if (kvlist) { > @@ -6505,7 +6505,7 @@ static int bnxt_pci_probe(struct rte_pci_driver *pci_drv __rte_unused, > return ret; > > /* probe representor ports now */ > - ret = bnxt_rep_port_probe(pci_dev, eth_da, backing_eth_dev, > + ret = bnxt_rep_port_probe(pci_dev, ð_da, backing_eth_dev, > pci_dev->device.devargs->args); > > return ret; > -- > 2.7.4 >