From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ajit.khaparde@broadcom.com> Received: from mail-qk0-f175.google.com (mail-qk0-f175.google.com [209.85.220.175]) by dpdk.org (Postfix) with ESMTP id 1416D374E for <dev@dpdk.org>; Tue, 23 May 2017 19:59:12 +0200 (CEST) Received: by mail-qk0-f175.google.com with SMTP id k74so136816651qke.1 for <dev@dpdk.org>; Tue, 23 May 2017 10:59:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=C6so1BY2fg70ppdRmcvML2sLVwmIrT/jibgWwcJM7z0=; b=BT1kz53X2CT9JKdw1NTwFj62z52IQ6qrp7b1GF5oqFK4E1kY4fIl0tAsZO2msHDUzv IrimgJaUzxrKwsPni8QrQIH9LW2dSkY1pzpVCT2ZOCx9lWO1wkNQuBhXZ5Xl2EhIuZq5 zotyu9bq0iLeoZ4nIz0GjDOhPNeda+rmVv8S0= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=C6so1BY2fg70ppdRmcvML2sLVwmIrT/jibgWwcJM7z0=; b=plVcKneQ1xH5fMG3qh2Yb/KuQwr1L7zw+WThLKQoiDJpDPsj3QDC8haXW2ySdwHzuN 7zednoZCyMHQHI4EHoarQhbYurO4eRDBCpXYPXAAR5t6CQGW/vfh1SMVwMc8dhHVy0j8 HDvRXvghw8Lbaolcgckfsdk036VJb+uvoAahbJhoaZHBfv3FAxifA+idbAMGZNfSw2cg wmMSS82B98x6zmFz+h37DUvicxiIF3LCLbdZonwRbnS5NaYBuwGrXFEVweRYuJ6+0m2E /yowY7M2JLXtZ87/g1bvFtpsrSBrdCRYHp9770SatqMifz+nNZr168SVD3ru7aGKtaII xpsw== X-Gm-Message-State: AODbwcACRxqXdk2NGUhskMBiNITIkV9kEYx/xezojcRNGoGus1u81ptK hB+ELuPjE9epSlzaozu6JdBMsNF8Gt1y X-Received: by 10.55.135.67 with SMTP id j64mr26156123qkd.151.1495562352261; Tue, 23 May 2017 10:59:12 -0700 (PDT) MIME-Version: 1.0 Received: by 10.237.47.37 with HTTP; Tue, 23 May 2017 10:58:31 -0700 (PDT) In-Reply-To: <c3f25416-e81e-e56f-0956-8f45f9c37269@intel.com> References: <20170518015813.7862-1-ajit.khaparde@broadcom.com> <c3f25416-e81e-e56f-0956-8f45f9c37269@intel.com> From: Ajit Khaparde <ajit.khaparde@broadcom.com> Date: Tue, 23 May 2017 12:58:31 -0500 Message-ID: <CACZ4nhuCdAoJJtmi2joaHf9+4+MzVFz87S-XO_J-HRBGUdiEFg@mail.gmail.com> To: Ferruh Yigit <ferruh.yigit@intel.com> Cc: dev@dpdk.org, Thomas Monjalon <thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 00/23] bnxt patchset X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Tue, 23 May 2017 17:59:13 -0000 On Mon, May 22, 2017 at 5:55 AM, Ferruh Yigit <ferruh.yigit@intel.com> wrote: > On 5/18/2017 2:57 AM, Ajit Khaparde wrote: > > This patchset amongst other changes adds support few more dev_ops, > > updates HWRM to version 1.7.5, switches to polling stats from the > > hardware, support for LRO etc.. > > > > bnxt: add various hwrm input/output structures > > bnxt: code reorg to properly allocate resources in PF/VF modes > > bnxt: add tunneling support > > bnxt: support lack of huge pages > > bnxt: add functions for tx_loopback, set_vf_mac and queues_drop_en > > bnxt: add support for set VF QOS and MAC anti spoof > > bnxt: add support for VLAN stripq, VLAN anti spoof and VLAN filtering > for VFs > > bnxt: add support to get and clear VF specific stats > > bnxt: add code to determine the Rx status of VF > > bnxt: add support to add a VF MAC address > > bnxt: add support for xstats get/reset > > bnxt: Add support for VLAN filter and strip dev_ops > > bnxt: add code to configure a default VF VLAN > > bnxt: add support for set_mc_addr_list and mac_addr_set > > bnxt: add support for fw_version_get dev_op > > bnxt: add support to set MTU > > bnxt: add support for LRO > > bnxt: add rxq_info_get and txq_info_get dev_ops > > bnxt: add additonal HWRM debug info to error messages > > bnxt: reorg the query stats code > > bnxt: update to HWRM version 1.7.5 > > bnxt: Add support to set VF rxmode > > bnxt: add code to support vlan_pvid_set dev_op > > > 25 files changed, 10407 insertions(+), 3036 deletions(-) > > Hi Ajit, > > This is a big patch, and as far as I can see it does mainly three things: > > 1) Update base driver kind of updates (although bnxt doesn't have a base > =E2=80=8B=E2=80=8B > folder, there are files we can put into this category). > Since all the hardware specific code is abstracted by the HWRM api =E2=80=8B, we feel doing a base folder will be pretty much another abstraction above this HWRM.=E2=80=8B =E2=80=8BBut =E2=80=8B =E2=80=8BI will try to break down the bigger patch =E2=80=8B=E2=80=8B into smaller ones. =E2=80=8B=E2=80=8B Its just that I tried to keep the related code in one patch to keep the functionality together. 2) Add some new driver features. > 3) Add PMD specific APIs mainly to control VF from PF. > > - Is it possible to group patches in the patchset as above, currently > patches are all mixed and harder to understand? > =E2=80=8BI will do my best. =E2=80=8B > > - for 3), Some of the PMD specific APIs are common with exiting ones in > i40e and ixgbe, should we extract them into eth_dev_ops now? @Thomas, > any comment? > > - For 2), can you please update features/bnxt.ini file in each patch > that adds a feature, to enable that feature in the document. And finally > a release doc update in separate patch can be good. > =E2=80=8BOk. I will work on that. =E2=80=8B > > - Some commits has function names updated in the patch subject, can you > please update them to describe the feature added, function name detail > can be in commit log. You can use ./devtools/check-git-log.sh to verify > =E2=80=8B=E2=80=8B > commit logs, there are some set of errors now. > =E2=80=8BSure. =E2=80=8B > > Thanks, > ferruh >