[dpdk-dev] [PATCH] net/bnxt: fix seg fault on Thor

[dpdk-dev] [PATCH] net/bnxt: fix seg fault on Thor

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 970 bytes --]

In a few cases with Thor device, PMD can segfault when VF
representors are specified. Temporarily fix it by preventing
VF reps for Thor device. This will be addressed in next release.

Fixes: 3fe124d2536c ("net/bnxt: support Thor platform")
Cc: stable@dpdk.org

Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
---
 drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 5 +++++
 1 file changed, 5 insertions(+)

diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
index fa2148ead7..dbf85e4eda 100644
--- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
+++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
@@ -815,6 +815,11 @@ ulp_ctx_init(struct bnxt *bp,
 		goto error_deinit;
 	}
 
+	if (devid == BNXT_ULP_DEVICE_ID_THOR) {
+		ulp_data->ulp_flags &= ~BNXT_ULP_VF_REP_ENABLED;
+		BNXT_TF_DBG(ERR, "Enabled non-VFR mode\n");
+	}
+
 	/*
 	 * Shared session must be created before first regular session but after
 	 * the ulp_ctx is valid.
-- 
2.21.1 (Apple Git-122.3)

Re: [dpdk-dev] [PATCH] net/bnxt: fix seg fault on Thor

[Ajit Khaparde]

[-- Attachment #1: Type: text/plain, Size: 1291 bytes --]

On Fri, Jul 30, 2021 at 2:15 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> In a few cases with Thor device, PMD can segfault when VF
> representors are specified. Temporarily fix it by preventing
> VF reps for Thor device. This will be addressed in next release.
>
> Fixes: 3fe124d2536c ("net/bnxt: support Thor platform")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>

Updated the commit headline to
"net/bnxt: disable VF representors on Thor"
Merged to dpdk-next-net-brcm.

> ---
>  drivers/net/bnxt/tf_ulp/bnxt_ulp.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> index fa2148ead7..dbf85e4eda 100644
> --- a/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> +++ b/drivers/net/bnxt/tf_ulp/bnxt_ulp.c
> @@ -815,6 +815,11 @@ ulp_ctx_init(struct bnxt *bp,
>                 goto error_deinit;
>         }
>
> +       if (devid == BNXT_ULP_DEVICE_ID_THOR) {
> +               ulp_data->ulp_flags &= ~BNXT_ULP_VF_REP_ENABLED;
> +               BNXT_TF_DBG(ERR, "Enabled non-VFR mode\n");
> +       }
> +
>         /*
>          * Shared session must be created before first regular session but after
>          * the ulp_ctx is valid.
> --
> 2.21.1 (Apple Git-122.3)
>