From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 8C502A04B1; Wed, 23 Sep 2020 06:28:45 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 588861DBEA; Wed, 23 Sep 2020 06:28:45 +0200 (CEST) Received: from mail-oi1-f196.google.com (mail-oi1-f196.google.com [209.85.167.196]) by dpdk.org (Postfix) with ESMTP id 7BC141DB2E for ; Wed, 23 Sep 2020 06:28:42 +0200 (CEST) Received: by mail-oi1-f196.google.com with SMTP id w16so23586477oia.2 for ; Tue, 22 Sep 2020 21:28:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=pFs6MXbNPCTiDNMYobA/B2u0A/gCwbi2ANw7zkSCdP0=; b=G0XzYm5ItmpQYw7Qjw2j8vocNPkE4pSZv0llETswNc0Iju5n4pqdqY8+j3yKSyyxW3 KsfVj4Spdw38vkAJ+0TDNSeIlPmmYa4HTrpokOY7H8uZMhct8/DYIM9zjmas6VjbinSP sLjdrehSFUGv4H9faqfMutanfLBzRiCb0nVyQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=pFs6MXbNPCTiDNMYobA/B2u0A/gCwbi2ANw7zkSCdP0=; b=hYUsaae5lZMxZ1NDyStwmoG0PyLDkH+q+pXzsz4GHnar8NmWXq1kjXjR6wr52YD/WJ e+iCBSxDMf9nTUbA4jnSom4qmLMri/cyoL5OdGTt9HhbS2ui2L9ZpoBWUvJkAUwzu3nO HW90MuiBAAzE4NjVgDYCzvvrvmsnnkl4WQavJ7MQJtyTu/cRNLUyaOmSERjacKKCwOMg N5pLmbz0XHt169ZERpoD9lBEBwRsnLZTR7A9qx5JYvGN1c9dRvuum+Jjt7ZyrK2F/4Wm 3ScE+/fsVocp2+nVcydcSalbpMmMarLVGx0Wyad/csOsNO6lly2LZ803/fYIEFSXKnkK O+FQ== X-Gm-Message-State: AOAM532dULDRy7UzL8gp+S1cTVo/0F2iPdM9ycDpcNa+bI4yYZf1Ox1Z 28BHUsA9Rt1KNRpf4Gd/egfcgVqTUvb4+YFOivvgEA== X-Google-Smtp-Source: ABdhPJydt5Spi57hTe7oZ5TepW54D/5DYlzWzBaJizmwtaBrlecB1hTwnTEy6Oi9OCra6d+3ZxEz4S4BlBY4UCNuiS0= X-Received: by 2002:aca:4904:: with SMTP id w4mr4697671oia.179.1600835321720; Tue, 22 Sep 2020 21:28:41 -0700 (PDT) MIME-Version: 1.0 References: <20200922053416.16818-1-somnath.kotur@broadcom.com> In-Reply-To: <20200922053416.16818-1-somnath.kotur@broadcom.com> From: Ajit Khaparde Date: Tue, 22 Sep 2020 21:28:25 -0700 Message-ID: To: Somnath Kotur Cc: dpdk-dev , Ferruh Yigit , Kalesh AP , dpdk stable Content-Type: text/plain; charset="UTF-8" X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix to not bring link down during reset recovery X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Mon, Sep 21, 2020 at 10:41 PM Somnath Kotur wrote: > From: Kalesh AP > > Driver should not send the phy_cfg request to bring link down > during reset recovery. If the driver sends the phy_cfg request > in recovery process, then FW needs to re-establish the link which > in turn increases the recovery time based on PHY type and link partners. > > Fixes: df6cd7c1f73a ("net/bnxt: handle reset notify async event from FW") > Cc: stable@dpdk.org > > Signed-off-by: Kalesh AP > Reviewed-by: Somnath Kotur > Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 6 ++++-- > 1 file changed, 4 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c > b/drivers/net/bnxt/bnxt_ethdev.c > index 05e9a6a..e0afaac 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -1323,7 +1323,9 @@ static void bnxt_dev_stop_op(struct rte_eth_dev > *eth_dev) > > bnxt_cancel_fw_health_check(bp); > > - bnxt_dev_set_link_down_op(eth_dev); > + /* Do not bring link down during reset recovery */ > + if (!is_bnxt_in_error(bp)) > + bnxt_dev_set_link_down_op(eth_dev); > > /* Wait for link to be reset and the async notification to process. > * During reset recovery, there is no need to wait and > @@ -4377,7 +4379,7 @@ static void bnxt_write_fw_reset_reg(struct bnxt *bp, > uint32_t index) > > static void bnxt_dev_cleanup(struct bnxt *bp) > { > - bnxt_set_hwrm_link_config(bp, false); > + bp->eth_dev->data->dev_link.link_status = 0; > bp->link_info->link_up = 0; > if (bp->eth_dev->data->dev_started) > bnxt_dev_stop_op(bp->eth_dev); > -- > 2.10.1 > >