From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3985AA055B; Mon, 27 Jun 2022 00:24:18 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CC89040E78; Mon, 27 Jun 2022 00:24:17 +0200 (CEST) Received: from mail-il1-f169.google.com (mail-il1-f169.google.com [209.85.166.169]) by mails.dpdk.org (Postfix) with ESMTP id 70F2940E50 for ; Mon, 27 Jun 2022 00:24:16 +0200 (CEST) Received: by mail-il1-f169.google.com with SMTP id h20so4884795ilj.13 for ; Sun, 26 Jun 2022 15:24:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=5NU/6XsPNy0qJKe/DcdgMomf2lGKT/xXveC1UsHOv1s=; b=hTnvcsE+FiB9I++xziGp+wAEfmrf2T2dLN+ZsDXXKHiKlH8SyVDnuooohDRVVLqAj1 2uRjGTFRZvF2i0+KOsXQGV/l35AxjFtmZQbtWE9nXorD8a/2SxX1MY+WlaQcktqquLen b3hWb4Yqqv8uyq4bIEfQsrcxjDTmKi6zRppAA= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=5NU/6XsPNy0qJKe/DcdgMomf2lGKT/xXveC1UsHOv1s=; b=tkHTmi3GfhenkGyzSX+RtoZtYSFyzb2/jHJVXGjcARhFVcGnw3Ngu43E2YvDoq4/3T +33yS2EaYRjTS4wqZ5fpFiC/q5T210gM9/Jai8HhAyynEKOshLdW05OMoNyHNv1S1b19 RJ5D50aN2zxKaeVHEUOhmh/VFCxY0WJpkzKb09A/Rvdm88mt5pbDXV9I/7LSYD8WPfX9 Vd1s7gBwTjH5RtQWCyXq039sfNFko+R0i/w+wpoXcqrvz+6+kzKi1h0etTLHdqDLEYTF RxuakWWWj2Pbym2lZ3kjf+Hf7zDQmtn6E7LBOU9nuZSgsfbYEar18/Jm0uPyBR6Ir1BX oWrg== X-Gm-Message-State: AJIora8eQKKwH4jttfcWFdpZiMcgy2WIxFNZp/HDe3GGRHKb1RT7/KF+ reA/RWH+X0sesnPovbvytdg2/Cuw/nCDlrA3Gwhd/+qI6cc= X-Google-Smtp-Source: AGRyM1tvW54PtiF5bVgE93/+Rc5Y/IXVUX2B7o3Q4Sj9dPsDYEfbdD8nOYClAXGErAgiAASiJk6My2RDLCCCrLDpEGY= X-Received: by 2002:a92:c567:0:b0:2d1:6268:2fd5 with SMTP id b7-20020a92c567000000b002d162682fd5mr5470690ilj.255.1656282255684; Sun, 26 Jun 2022 15:24:15 -0700 (PDT) MIME-Version: 1.0 References: <20220511163310.50892-1-heinrich.schuchardt@canonical.com> <6192851.a9HWlOh95j@thomas> In-Reply-To: <6192851.a9HWlOh95j@thomas> From: Ajit Khaparde Date: Sun, 26 Jun 2022 15:23:59 -0700 Message-ID: Subject: Re: [PATCH 1/1] test/pmd_perf: handling of unknown connection speed To: Thomas Monjalon Cc: Heinrich Schuchardt , David Marchand , dpdk-dev , Chenbo Xia , Rosen Xu , Stephen Hemminger , Joyce Kong , Jie Zhou , konstantin.v.ananyev@yandex.ru, Ferruh Yigit , Andrew Rybchenko Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="00000000000083c39205e2614336" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --00000000000083c39205e2614336 Content-Type: text/plain; charset="UTF-8" On Sun, Jun 26, 2022 at 8:15 AM Thomas Monjalon wrote: > > 11/05/2022 18:33, Heinrich Schuchardt: > > When running DPDK in QEMU it cannot determine the connection speed. > > pmd_perf_autotest treats this as if the connection speed where > > UNIT32_MAX Mbps: > > > > RTE>>pmd_perf_autotest > > Start PMD RXTX cycles cost test. > > Allocated mbuf pool on socket 0 > > CONFIG RXD=1024 TXD=1024 > > Performance test runs on lcore 1 socket 0 > > Port 0 Address:52:54:00:12:34:57 > > Port 1 Address:52:54:00:12:34:58 > > Checking link statuses... > > Port 0 Link up at Unknown FDX Autoneg > > Port 1 Link up at Unknown FDX Autoneg > > IPv4 pktlen 46 > > UDP pktlen 26 > > Generate 4096 packets @socket 0 > > inject 2048 packet to port 0 > > inject 2048 packet to port 1 > > Total packets inject to prime ports = 4096 > > Each port will do 6391320379464 packets per second > > Test will stop after at least 25565281517856 packets received > > > > This will not allow the test to terminate in a reasonable timespan. > > Just assume 10 Gbps in this case instead: > > > > ... > > Test will stop after at least 59523808 packets received > > > > Signed-off-by: Heinrich Schuchardt > > --- > > app/test/test_pmd_perf.c | 15 +++++++++++---- > > 1 file changed, 11 insertions(+), 4 deletions(-) > > > > diff --git a/app/test/test_pmd_perf.c b/app/test/test_pmd_perf.c > > index 25611bfe9b..ee08c8aade 100644 > > --- a/app/test/test_pmd_perf.c > > +++ b/app/test/test_pmd_perf.c > > @@ -486,10 +486,17 @@ main_loop(__rte_unused void *args) > > } > > printf("Total packets inject to prime ports = %u\n", idx); > > > > - packets_per_second = (link_mbps * 1000 * 1000) / > > - ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT); > > - printf("Each port will do %"PRIu64" packets per second\n", > > - packets_per_second); > > + if (link_mbps != RTE_ETH_SPEED_NUM_UNKNOWN) { > > + packets_per_second = (link_mbps * 1000 * 1000) / > > + ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT); > > + printf("Each port will do %"PRIu64" packets per second\n", > > + packets_per_second); > > + total_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second; > > This is redundant with below. > > > + } else { > > + /* We don't know the speed. Pretend it is 10G */ > > + packets_per_second = ((uint64_t)RTE_ETH_SPEED_NUM_10G * 1000 * 1000) / > > + ((PACKET_SIZE + FRAME_GAP + MAC_PREAMBLE) * CHAR_BIT); > > + } > > > > total_packets = RTE_TEST_DURATION * conf->nb_ports * packets_per_second; > > Why not just inserting this: > > if (link_mbps == RTE_ETH_SPEED_NUM_UNKNOWN) > link_mbps = RTE_ETH_SPEED_NUM_10G; +1 I think this is better. > > > --00000000000083c39205e2614336 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDBCmE9BT7srhoNHDEDANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMTAyMjIxNDE4MjdaFw0yMjA5MjIxNDUxNDlaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEAwXsxfYF9jpj9zve1vXxD491SrWDVlcmLMdnOS1c7POMC8lbbgvp1o2kIu/3n xCVFTai5H6rHZgrFItNNVZ+XaJW9Ob9eiSuXdnAu5gVdTb+IFAf4S/PT2LXzpP07M7vyvm/yvA+8 HtVfapzqqTNYdNVUpq28MYsKEWbnyK94x5+C3oCAV4bpNnMoPNtKrMhvOdpTREQRyew8hyy3/Mz7 RIaCW0xx+14NTQe17dkH6CEEpmCjejneq/FU0gmbuorwHoP9mOiqeh23/ZKVpmFO/eiDtvMNAMDW 6LzhOk/pMklUPTHu/gQNW3OQebyhyFUHiBSp8rDkfWZT57Asd0PtdQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUPHif0ihgndR0 h7r3sANaOIu2yM8wDQYJKoZIhvcNAQELBQADggEBAAEuLXDnP0Xd2zAMpQobXLUyqbpqGMO6ycQc Xq4H2YYlSNKVwPA+ZAVdUOzbSimBKlx8mzAEHkI3Ll1yXlYeT4UwkfWV9fioyGuQelLN1sGzi5bm WEpaSIbR1eiJMtzxUPwpRTn19gHZVueIot2Gw0fEYgHiMJpUr6xBWv2QNXULu/E8qvbXIRh2iycq 5rWFggX/JHglO8nVqzb1ImzqzVMFnDN15h3j8ryy2MIvZ8VDQRP7l81IXaTvVwaKpWMgV6rfQOi6 aOQZuOKkad7qoCkS5N2oSsvxi+rZtDaJJNsDjs05y5JZZQtBlfAmdYS+mmvkPjZ1iaLTzk59o/Yo fNkxggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwQphPQ U+7K4aDRwxAwDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIFqwV6ONH158Nkr96wSp BWXGDERePVqgl6qttDdRZoFtMBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTIyMDYyNjIyMjQxNVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQC8rbrWE3o8W9gXlzTC/aWm8nDPENgzFPlxxgQZ 6A+r8Q5gwdkFm9lmOibnr789R8kVqxSJHLQknSzeG92mUDGpa8MGHgYTd1wfIu2c4wec6vpQXfFK FU2BMj4FDAfbRuifqade+DXUyXB/X0J6GRC7eHrCk8nJh9AKanykofVlklrIWjTSHByUYAmqx1rI nnjrUVJMIPtNOyiDH40wIHcm5mvAHWBVZ45r27kH6oeIrjVabW8/yytz1in9Z07vSEP8AO/lj0AZ RYDIuCBzrkEsWs5UIQBKa4xLoFT3N1k/dLQMFVx/QhkwJiKub0+dBTcCgFRsUD+AILHSKEbvgwaR --00000000000083c39205e2614336--