DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ajit Khaparde <ajit.khaparde@broadcom.com>
To: dpdk-dev <dev@dpdk.org>
Cc: dpdk stable <stable@dpdk.org>, Ferruh Yigit <ferruh.yigit@intel.com>
Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Tx queue startup state
Date: Sun, 26 Sep 2021 14:17:33 -0700	[thread overview]
Message-ID: <CACZ4nhuaFu2XtuemZEqsUKyfhFp7h2VP9L=DGiVF-AeMQO-vfA@mail.gmail.com> (raw)
In-Reply-To: <20210925005544.50518-1-ajit.khaparde@broadcom.com>

[-- Attachment #1: Type: text/plain, Size: 1981 bytes --]

On Fri, Sep 24, 2021 at 5:55 PM Ajit Khaparde
<ajit.khaparde@broadcom.com> wrote:
>
> Default queue state of Tx queues on startup is not correct.
> Fix this by setting the state when the port is started.
>
> Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code")
> Cc: stable@dpdk.org
>
> Signed-off-by: Ajit Khaparde <ajit.khaparde@broadcom.com>
> Reviewed-by: Lance Richardson <lance.richardson@broadcom.com>
Patch applied to dpdk-next-net-brcm. Thanks

> ---
>  drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++++++
>  drivers/net/bnxt/bnxt_txq.c    |  5 -----
>  2 files changed, 10 insertions(+), 5 deletions(-)
>
> diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c
> index 097dd10de9..eb9147927e 100644
> --- a/drivers/net/bnxt/bnxt_ethdev.c
> +++ b/drivers/net/bnxt/bnxt_ethdev.c
> @@ -814,6 +814,16 @@ static int bnxt_start_nic(struct bnxt *bp)
>                 }
>         }
>
> +       for (j = 0; j < bp->tx_nr_rings; j++) {
> +               struct bnxt_tx_queue *txq = bp->tx_queues[j];
> +
> +               if (!txq->tx_deferred_start) {
> +                       bp->eth_dev->data->tx_queue_state[j] =
> +                               RTE_ETH_QUEUE_STATE_STARTED;
> +                       txq->tx_started = true;
> +               }
> +       }
> +
>         rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL);
>         if (rc) {
>                 PMD_DRV_LOG(ERR,
> diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c
> index 830416af3d..3ffc334cff 100644
> --- a/drivers/net/bnxt/bnxt_txq.c
> +++ b/drivers/net/bnxt/bnxt_txq.c
> @@ -166,11 +166,6 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev,
>
>         eth_dev->data->tx_queues[queue_idx] = txq;
>
> -       if (txq->tx_deferred_start)
> -               txq->tx_started = false;
> -       else
> -               txq->tx_started = true;
> -
>         return 0;
>  err:
>         bnxt_tx_queue_release_op(txq);
> --
> 2.30.1 (Apple Git-130)
>

      reply	other threads:[~2021-09-26 21:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-09-25  0:55 Ajit Khaparde
2021-09-26 21:17 ` Ajit Khaparde [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CACZ4nhuaFu2XtuemZEqsUKyfhFp7h2VP9L=DGiVF-AeMQO-vfA@mail.gmail.com' \
    --to=ajit.khaparde@broadcom.com \
    --cc=dev@dpdk.org \
    --cc=ferruh.yigit@intel.com \
    --cc=stable@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).