From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id CFD96A0547; Sun, 26 Sep 2021 23:17:51 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id BFF3140E6E; Sun, 26 Sep 2021 23:17:51 +0200 (CEST) Received: from mail-io1-f45.google.com (mail-io1-f45.google.com [209.85.166.45]) by mails.dpdk.org (Postfix) with ESMTP id 62A9F4003D for ; Sun, 26 Sep 2021 23:17:50 +0200 (CEST) Received: by mail-io1-f45.google.com with SMTP id i62so4196524ioa.6 for ; Sun, 26 Sep 2021 14:17:50 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CDDpn17lPlWlhXnPS0ipeky2nC24k+6o22eHgIZNhZE=; b=LwalVvbAWB2iaPct/2E2PPzs1RVP9E2jrnW0s9Xomi5EgZEMt4G5QP1fUujknIUnCg 9BFD6FA5PDlODdDIPvKGUkZoHaQmDQvlqxnuLbkxF29XHEqx4n2fGWYhnb4/s771Bkk0 2nJ92MLM8pwH+iKKxXXYRpZvnA4lI8jo432TY= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CDDpn17lPlWlhXnPS0ipeky2nC24k+6o22eHgIZNhZE=; b=oTJs6BLS0vDF8UDYZgfYwweDhQRejVLqMnNa1t8Dye1igR4f6z2IODeZs1Jl+wAL7/ dbF4pEfPmCVtTkJUQn6G0nf/hGcJjNIDsiIbqEffmkNKbzuw42BfDAQIFBuLH2C97VT+ K2XuCznyOuLrnetbzASV5GXwbfg33RECAjrQXJprGRypXe9vhGn67StrDkSOGI1OHQlx YuNsoVj7lIi7WCyJYctG6X1qHuRtPfIZdcSfXPOOMf2WF1YnDpevQI5ShNz62pICnStb VnQqjAtHPnuZiuXzkFpZ2062LzPGA4Raw5zhgn1PHm8bH+WK6FNqZMg3X57sMzQ97FgC 0yYg== X-Gm-Message-State: AOAM530tL6OkEBQ7gl/kmOkOr5j3J+Pakcg9GP+ZAbPGb1ObO8dJuIJk vaJSuudrp/+ZJIwZQG8a8x/TUdncO0pS+B78n8/0Xdj6TtQ= X-Google-Smtp-Source: ABdhPJzuBtp3PtF7waNlR1UIhlL/96PnPb6xBQQfKcmgjL5Xi3QXRbOnLvwql6QzLz7YThQWAQHqeVYk2v5d8b+baTI= X-Received: by 2002:a05:6638:3890:: with SMTP id b16mr19362211jav.65.1632691069446; Sun, 26 Sep 2021 14:17:49 -0700 (PDT) MIME-Version: 1.0 References: <20210925005544.50518-1-ajit.khaparde@broadcom.com> In-Reply-To: <20210925005544.50518-1-ajit.khaparde@broadcom.com> From: Ajit Khaparde Date: Sun, 26 Sep 2021 14:17:33 -0700 Message-ID: To: dpdk-dev Cc: dpdk stable , Ferruh Yigit Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000003d347c05ccec8309" X-Content-Filtered-By: Mailman/MimeDel 2.1.29 Subject: Re: [dpdk-dev] [PATCH] net/bnxt: fix Tx queue startup state X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" --0000000000003d347c05ccec8309 Content-Type: text/plain; charset="UTF-8" On Fri, Sep 24, 2021 at 5:55 PM Ajit Khaparde wrote: > > Default queue state of Tx queues on startup is not correct. > Fix this by setting the state when the port is started. > > Fixes: 6eb3cc2294fd ("net/bnxt: add initial Tx code") > Cc: stable@dpdk.org > > Signed-off-by: Ajit Khaparde > Reviewed-by: Lance Richardson Patch applied to dpdk-next-net-brcm. Thanks > --- > drivers/net/bnxt/bnxt_ethdev.c | 10 ++++++++++ > drivers/net/bnxt/bnxt_txq.c | 5 ----- > 2 files changed, 10 insertions(+), 5 deletions(-) > > diff --git a/drivers/net/bnxt/bnxt_ethdev.c b/drivers/net/bnxt/bnxt_ethdev.c > index 097dd10de9..eb9147927e 100644 > --- a/drivers/net/bnxt/bnxt_ethdev.c > +++ b/drivers/net/bnxt/bnxt_ethdev.c > @@ -814,6 +814,16 @@ static int bnxt_start_nic(struct bnxt *bp) > } > } > > + for (j = 0; j < bp->tx_nr_rings; j++) { > + struct bnxt_tx_queue *txq = bp->tx_queues[j]; > + > + if (!txq->tx_deferred_start) { > + bp->eth_dev->data->tx_queue_state[j] = > + RTE_ETH_QUEUE_STATE_STARTED; > + txq->tx_started = true; > + } > + } > + > rc = bnxt_hwrm_cfa_l2_set_rx_mask(bp, &bp->vnic_info[0], 0, NULL); > if (rc) { > PMD_DRV_LOG(ERR, > diff --git a/drivers/net/bnxt/bnxt_txq.c b/drivers/net/bnxt/bnxt_txq.c > index 830416af3d..3ffc334cff 100644 > --- a/drivers/net/bnxt/bnxt_txq.c > +++ b/drivers/net/bnxt/bnxt_txq.c > @@ -166,11 +166,6 @@ int bnxt_tx_queue_setup_op(struct rte_eth_dev *eth_dev, > > eth_dev->data->tx_queues[queue_idx] = txq; > > - if (txq->tx_deferred_start) > - txq->tx_started = false; > - else > - txq->tx_started = true; > - > return 0; > err: > bnxt_tx_queue_release_op(txq); > -- > 2.30.1 (Apple Git-130) > --0000000000003d347c05ccec8309--