From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id DF23F43AA9; Thu, 8 Feb 2024 19:56:47 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 75F9C402D1; Thu, 8 Feb 2024 19:56:47 +0100 (CET) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com [209.85.210.181]) by mails.dpdk.org (Postfix) with ESMTP id 32EC540273 for ; Thu, 8 Feb 2024 19:56:46 +0100 (CET) Received: by mail-pf1-f181.google.com with SMTP id d2e1a72fcca58-6d9f94b9186so160037b3a.0 for ; Thu, 08 Feb 2024 10:56:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; t=1707418605; x=1708023405; darn=dpdk.org; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=Lgu2jCGZ7GhxZ/9edSjdal1sp+XF6iv54nu7J4YUhok=; b=K4ctSkPCJ8fcFtkJNJf6G8QNoQLfo9jv5hkgwFAGgV/laF3e3m5MZINrKoF+A9cCMg 2hGHaEc7Kw98XfAWJIof0JbXJiCgi1p5yy4yDGSnhQczlYIjK+GxMQg0oWFic6Savi2/ 7tS7P3S4ece1GcGM3ZQguyL7ZmAeSge/5SGzU= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1707418605; x=1708023405; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=Lgu2jCGZ7GhxZ/9edSjdal1sp+XF6iv54nu7J4YUhok=; b=KnZQQ2MFzolUWOcopPKZ9wyKPOmPwsM7NTzD/oIhJBbjW6oHW7BqfBA3VYE4+NaYHn OZ2Dl6MVolFTIXkpeyprrNBLfuwxLokOhN2p+aQ8yP7nEQbqA9xKc5IG9FswYv2d+DRV 47mnaUhUEBEm8cA4iB55qzd0MG85w+0tiUcyW29QXDDOFjIPKq0wO4FKitaPe1xUfr9+ GjCqhZ3YhAixMm+9CxFA4CYf/OMjRgsrMgMd1u+I4tNNe4yPxJTpRkfMaY8gqbULNwqP eXpJ/xoaxaw55KoloOoLAebYuUdip5nTBFwWisE5YjLqYVu/fxvuqq5dbRS4Be0orqCg 7bsA== X-Gm-Message-State: AOJu0YwJP2zaW2B3Zjq/QxsiF5Rg1rcW4/Ab4IB58Ph90KkH970SeFJy N3A6RVYP+bJWXn/3lRhoiuCV95WzgwZoX/YEOftsOloJiXOgBgPodaAbyPADYHuQ70nE63y3duh aCUglgupEnjRtfDZdIdACRS34VQBSCJtf7/Nk X-Google-Smtp-Source: AGHT+IHrXLvPy00aCmpmhjpvPmsBH30TH0bZ+oNkYt4EUJr2Alg/7i0Hd+8HtD76NZicOqjr72Jl/sgMvRimdvK6nxc= X-Received: by 2002:a05:6a20:7490:b0:19e:5683:e8d0 with SMTP id p16-20020a056a20749000b0019e5683e8d0mr633650pzd.12.1707418605198; Thu, 08 Feb 2024 10:56:45 -0800 (PST) MIME-Version: 1.0 References: <20240208054311.3642-1-ajit.khaparde@broadcom.com> In-Reply-To: From: Ajit Khaparde Date: Thu, 8 Feb 2024 10:56:27 -0800 Message-ID: Subject: Re: [PATCH 0/3] Support IPv6 flow label based RSS To: Ferruh Yigit Cc: dev@dpdk.org, ferruh.yigit@intel.com, andrew.rybchenko@oktetlabs.ru Content-Type: multipart/signed; protocol="application/pkcs7-signature"; micalg=sha-256; boundary="0000000000007836de0610e35fb9" X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org --0000000000007836de0610e35fb9 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable On Thu, Feb 8, 2024 at 10:47=E2=80=AFAM Ferruh Yigit = wrote: > > On 2/8/2024 5:43 AM, Ajit Khaparde wrote: > > The use of 5-tuple of the source address, destination address, > > source port, destination port, and the transport protocol type > > may not be possible due to IP fragmentation, encryption, or > > inability to parse past IPv6 extensions headers. > > > > Flow label values can be chosen such that they can be > > used as part of the input to a hash function used in a load > > distribution scheme. > > > > On supporting hardware, the 20-bit Flow Label field in the > > IPv6 header can be used to perform RSS in the ingress path. > > > > Please apply. > > > > Hi Ajit, > Thanks Ferruh. > First two patch looks OK but can you please combine them into single patc= h? Sure. Can do. > > There are two ways for RSS, config APIs and rte_flow based support, > testpmd patch only adds flow based support, I don't know if old method > support is required, but if you want to add you can check following sampl= e: > 'Commit 46914aa1c793 ("ethdev: add eCPRI RSS offload type")' Ok. Let me check. > > > Third patch, bnxt one, doesn't apply. It looks like it is on top of > different source code, if you prefer you can make it another patch and > get your tree. Yes. That's right. I had used the brcm-next-net for that and wanted to have a driver patch to show usability of the code. I think in v2, I will just send the ethdev + testpmd patch and add the driver patch in the PMD list/tree for cherry-pick. Thanks Ajit > > > > Example to configure IPv6 flow label based RSS: > > > > flow create 0 ingress pattern eth / ipv6 / tcp / end actions rss types = ipv6-flow-label end / end > > > > Ajit Khaparde (3): > > ethdev: add support for RSS based on IPv6 flow label > > app/testpmd: add IPv6 flow label to RSS types > > net/bnxt: add IPv6 flow label based RSS support > > > > app/test-pmd/config.c | 1 + > > drivers/net/bnxt/bnxt.h | 1 + > > drivers/net/bnxt/bnxt_ethdev.c | 2 ++ > > drivers/net/bnxt/bnxt_hwrm.c | 7 +++++++ > > drivers/net/bnxt/bnxt_vnic.c | 9 +++++++-- > > lib/ethdev/rte_ethdev.h | 1 + > > 6 files changed, 19 insertions(+), 2 deletions(-) > > > --0000000000007836de0610e35fb9 Content-Type: application/pkcs7-signature; name="smime.p7s" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="smime.p7s" Content-Description: S/MIME Cryptographic Signature MIIQdgYJKoZIhvcNAQcCoIIQZzCCEGMCAQExDzANBglghkgBZQMEAgEFADALBgkqhkiG9w0BBwGg gg3NMIIFDTCCA/WgAwIBAgIQeEqpED+lv77edQixNJMdADANBgkqhkiG9w0BAQsFADBMMSAwHgYD VQQLExdHbG9iYWxTaWduIFJvb3QgQ0EgLSBSMzETMBEGA1UEChMKR2xvYmFsU2lnbjETMBEGA1UE AxMKR2xvYmFsU2lnbjAeFw0yMDA5MTYwMDAwMDBaFw0yODA5MTYwMDAwMDBaMFsxCzAJBgNVBAYT AkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNhMTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBS MyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwMIIBIjANBgkqhkiG9w0BAQEFAAOCAQ8AMIIBCgKCAQEA vbCmXCcsbZ/a0fRIQMBxp4gJnnyeneFYpEtNydrZZ+GeKSMdHiDgXD1UnRSIudKo+moQ6YlCOu4t rVWO/EiXfYnK7zeop26ry1RpKtogB7/O115zultAz64ydQYLe+a1e/czkALg3sgTcOOcFZTXk38e aqsXsipoX1vsNurqPtnC27TWsA7pk4uKXscFjkeUE8JZu9BDKaswZygxBOPBQBwrA5+20Wxlk6k1 e6EKaaNaNZUy30q3ArEf30ZDpXyfCtiXnupjSK8WU2cK4qsEtj09JS4+mhi0CTCrCnXAzum3tgcH cHRg0prcSzzEUDQWoFxyuqwiwhHu3sPQNmFOMwIDAQABo4IB2jCCAdYwDgYDVR0PAQH/BAQDAgGG MGAGA1UdJQRZMFcGCCsGAQUFBwMCBggrBgEFBQcDBAYKKwYBBAGCNxQCAgYKKwYBBAGCNwoDBAYJ KwYBBAGCNxUGBgorBgEEAYI3CgMMBggrBgEFBQcDBwYIKwYBBQUHAxEwEgYDVR0TAQH/BAgwBgEB /wIBADAdBgNVHQ4EFgQUljPR5lgXWzR1ioFWZNW+SN6hj88wHwYDVR0jBBgwFoAUj/BLf6guRSSu TVD6Y5qL3uLdG7wwegYIKwYBBQUHAQEEbjBsMC0GCCsGAQUFBzABhiFodHRwOi8vb2NzcC5nbG9i YWxzaWduLmNvbS9yb290cjMwOwYIKwYBBQUHMAKGL2h0dHA6Ly9zZWN1cmUuZ2xvYmFsc2lnbi5j b20vY2FjZXJ0L3Jvb3QtcjMuY3J0MDYGA1UdHwQvMC0wK6ApoCeGJWh0dHA6Ly9jcmwuZ2xvYmFs c2lnbi5jb20vcm9vdC1yMy5jcmwwWgYDVR0gBFMwUTALBgkrBgEEAaAyASgwQgYKKwYBBAGgMgEo CjA0MDIGCCsGAQUFBwIBFiZodHRwczovL3d3dy5nbG9iYWxzaWduLmNvbS9yZXBvc2l0b3J5LzAN BgkqhkiG9w0BAQsFAAOCAQEAdAXk/XCnDeAOd9nNEUvWPxblOQ/5o/q6OIeTYvoEvUUi2qHUOtbf jBGdTptFsXXe4RgjVF9b6DuizgYfy+cILmvi5hfk3Iq8MAZsgtW+A/otQsJvK2wRatLE61RbzkX8 9/OXEZ1zT7t/q2RiJqzpvV8NChxIj+P7WTtepPm9AIj0Keue+gS2qvzAZAY34ZZeRHgA7g5O4TPJ /oTd+4rgiU++wLDlcZYd/slFkaT3xg4qWDepEMjT4T1qFOQIL+ijUArYS4owpPg9NISTKa1qqKWJ jFoyms0d0GwOniIIbBvhI2MJ7BSY9MYtWVT5jJO3tsVHwj4cp92CSFuGwunFMzCCA18wggJHoAMC AQICCwQAAAAAASFYUwiiMA0GCSqGSIb3DQEBCwUAMEwxIDAeBgNVBAsTF0dsb2JhbFNpZ24gUm9v dCBDQSAtIFIzMRMwEQYDVQQKEwpHbG9iYWxTaWduMRMwEQYDVQQDEwpHbG9iYWxTaWduMB4XDTA5 MDMxODEwMDAwMFoXDTI5MDMxODEwMDAwMFowTDEgMB4GA1UECxMXR2xvYmFsU2lnbiBSb290IENB IC0gUjMxEzARBgNVBAoTCkdsb2JhbFNpZ24xEzARBgNVBAMTCkdsb2JhbFNpZ24wggEiMA0GCSqG SIb3DQEBAQUAA4IBDwAwggEKAoIBAQDMJXaQeQZ4Ihb1wIO2hMoonv0FdhHFrYhy/EYCQ8eyip0E XyTLLkvhYIJG4VKrDIFHcGzdZNHr9SyjD4I9DCuul9e2FIYQebs7E4B3jAjhSdJqYi8fXvqWaN+J J5U4nwbXPsnLJlkNc96wyOkmDoMVxu9bi9IEYMpJpij2aTv2y8gokeWdimFXN6x0FNx04Druci8u nPvQu7/1PQDhBjPogiuuU6Y6FnOM3UEOIDrAtKeh6bJPkC4yYOlXy7kEkmho5TgmYHWyn3f/kRTv riBJ/K1AFUjRAjFhGV64l++td7dkmnq/X8ET75ti+w1s4FRpFqkD2m7pg5NxdsZphYIXAgMBAAGj QjBAMA4GA1UdDwEB/wQEAwIBBjAPBgNVHRMBAf8EBTADAQH/MB0GA1UdDgQWBBSP8Et/qC5FJK5N UPpjmove4t0bvDANBgkqhkiG9w0BAQsFAAOCAQEAS0DbwFCq/sgM7/eWVEVJu5YACUGssxOGhigH M8pr5nS5ugAtrqQK0/Xx8Q+Kv3NnSoPHRHt44K9ubG8DKY4zOUXDjuS5V2yq/BKW7FPGLeQkbLmU Y/vcU2hnVj6DuM81IcPJaP7O2sJTqsyQiunwXUaMld16WCgaLx3ezQA3QY/tRG3XUyiXfvNnBB4V 14qWtNPeTCekTBtzc3b0F5nCH3oO4y0IrQocLP88q1UOD5F+NuvDV0m+4S4tfGCLw0FREyOdzvcy a5QBqJnnLDMfOjsl0oZAzjsshnjJYS8Uuu7bVW/fhO4FCU29KNhyztNiUGUe65KXgzHZs7XKR1g/ XzCCBVUwggQ9oAMCAQICDAzZWuPidkrRZaiw2zANBgkqhkiG9w0BAQsFADBbMQswCQYDVQQGEwJC RTEZMBcGA1UEChMQR2xvYmFsU2lnbiBudi1zYTExMC8GA1UEAxMoR2xvYmFsU2lnbiBHQ0MgUjMg UGVyc29uYWxTaWduIDIgQ0EgMjAyMDAeFw0yMjA5MTAwODE4NDVaFw0yNTA5MTAwODE4NDVaMIGW MQswCQYDVQQGEwJJTjESMBAGA1UECBMJS2FybmF0YWthMRIwEAYDVQQHEwlCYW5nYWxvcmUxFjAU BgNVBAoTDUJyb2FkY29tIEluYy4xHDAaBgNVBAMTE0FqaXQgS3VtYXIgS2hhcGFyZGUxKTAnBgkq hkiG9w0BCQEWGmFqaXQua2hhcGFyZGVAYnJvYWRjb20uY29tMIIBIjANBgkqhkiG9w0BAQEFAAOC AQ8AMIIBCgKCAQEArZ/Aqg34lMOo2BabvAa+dRThl9OeUUJMob125dz+jvS78k4NZn1mYrHu53Dn YycqjtuSMlJ6vJuwN2W6QpgTaA2SDt5xTB7CwA2urpcm7vWxxLOszkr5cxMB1QBbTd77bXFuyTqW jrer3VIWqOujJ1n+n+1SigMwEr7PKQR64YKq2aRYn74ukY3DlQdKUrm2yUkcA7aExLcAwHWUna/u pZEyqKnwS1lKCzjX7mV5W955rFsFxChdAKfw0HilwtqdY24mhy62+GeaEkD0gYIj1tCmw9gnQToc K+0s7xEunfR9pBrzmOwS3OQbcP0nJ8SmQ8R+reroH6LYuFpaqK1rgQIDAQABo4IB2zCCAdcwDgYD VR0PAQH/BAQDAgWgMIGjBggrBgEFBQcBAQSBljCBkzBOBggrBgEFBQcwAoZCaHR0cDovL3NlY3Vy ZS5nbG9iYWxzaWduLmNvbS9jYWNlcnQvZ3NnY2NyM3BlcnNvbmFsc2lnbjJjYTIwMjAuY3J0MEEG CCsGAQUFBzABhjVodHRwOi8vb2NzcC5nbG9iYWxzaWduLmNvbS9nc2djY3IzcGVyc29uYWxzaWdu MmNhMjAyMDBNBgNVHSAERjBEMEIGCisGAQQBoDIBKAowNDAyBggrBgEFBQcCARYmaHR0cHM6Ly93 d3cuZ2xvYmFsc2lnbi5jb20vcmVwb3NpdG9yeS8wCQYDVR0TBAIwADBJBgNVHR8EQjBAMD6gPKA6 hjhodHRwOi8vY3JsLmdsb2JhbHNpZ24uY29tL2dzZ2NjcjNwZXJzb25hbHNpZ24yY2EyMDIwLmNy bDAlBgNVHREEHjAcgRphaml0LmtoYXBhcmRlQGJyb2FkY29tLmNvbTATBgNVHSUEDDAKBggrBgEF BQcDBDAfBgNVHSMEGDAWgBSWM9HmWBdbNHWKgVZk1b5I3qGPzzAdBgNVHQ4EFgQUbrcTuh0mr2qP xYdtyDgFeRIiE/gwDQYJKoZIhvcNAQELBQADggEBALrc1TljKrDhXicOaZlzIQyqOEkKAZ324i8X OwzA0n2EcPGmMZvgARurvanSLD3mLeeuyq1feCcjfGM1CJFh4+EY7EkbFbpVPOIdstSBhbnAJnOl aC/q0wTndKoC/xXBhXOZB8YL/Zq4ZclQLMUO6xi/fFRyHviI5/IrosdrpniXFJ9ukJoOXtvdrEF+ KlMYg/Deg9xo3wddCqQIsztHSkR4XaANdn+dbLRQpctZ13BY1lim4uz5bYn3M0IxyZWkQ1JuPHCK aRJv0SfR88PoI4RB7NCEHqFwARTj1KvFPQi8pK/YISFydZYbZrxQdyWDidqm4wSuJfpE6i0cWvCd u50xggJtMIICaQIBATBrMFsxCzAJBgNVBAYTAkJFMRkwFwYDVQQKExBHbG9iYWxTaWduIG52LXNh MTEwLwYDVQQDEyhHbG9iYWxTaWduIEdDQyBSMyBQZXJzb25hbFNpZ24gMiBDQSAyMDIwAgwM2Vrj 4nZK0WWosNswDQYJYIZIAWUDBAIBBQCggdQwLwYJKoZIhvcNAQkEMSIEIIDFOEr7TA2cXZUe6eIG Qwab2gizvMztfT7LxOu9c3e/MBgGCSqGSIb3DQEJAzELBgkqhkiG9w0BBwEwHAYJKoZIhvcNAQkF MQ8XDTI0MDIwODE4NTY0NVowaQYJKoZIhvcNAQkPMVwwWjALBglghkgBZQMEASowCwYJYIZIAWUD BAEWMAsGCWCGSAFlAwQBAjAKBggqhkiG9w0DBzALBgkqhkiG9w0BAQowCwYJKoZIhvcNAQEHMAsG CWCGSAFlAwQCATANBgkqhkiG9w0BAQEFAASCAQBonHzIduOZ0SWrGQBSaKXXfmlmEeBDiaZUqNYu IQ2Az+T48s9eNVm2hPjgBFtIxuuyy/pcZtvyE5TCgPsgIHguq3AW+bOctUHGfdQmbbGE0OJGDTku cHrmhCMs7ZSC6BtpPZ3BDwpl1CEc3Ni2UfkhIfxkNDS1ZN+PAbJboxw7K41zytxO4VaE9smFmS4h OJwBLS19XqoKzRdHsCoti2HRB0nX+OQuQmt6V4WNxdB5uMkgPtedz+OqlkhuvjvZODOhKR+/oEST QbHrBCHMAWRo/JliwdXN0C53WQXDzs5nGaFTrrzmoyVuMw4MwzhX//zG3Luc2qlisEx9UcebbMll --0000000000007836de0610e35fb9--